From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5B6C4332F for ; Fri, 12 Nov 2021 12:53:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 15AAA61054 for ; Fri, 12 Nov 2021 12:53:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15AAA61054 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 79AAF6B0074; Fri, 12 Nov 2021 07:53:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74AB86B0078; Fri, 12 Nov 2021 07:53:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639516B007B; Fri, 12 Nov 2021 07:53:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 5227E6B0074 for ; Fri, 12 Nov 2021 07:53:57 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 058D382499B9 for ; Fri, 12 Nov 2021 12:53:57 +0000 (UTC) X-FDA: 78800270514.22.E5DE6C5 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 5E41420019FD for ; Fri, 12 Nov 2021 12:53:57 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso6570548otf.12 for ; Fri, 12 Nov 2021 04:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zenB0fvF8v9LEnZLKkAsA85Z8KWObb5c13LjpylZxxw=; b=cXOZX0K1nhcFmPUEIIXRVUdPfxwyYSr9a6rksmFdq3b6996mc083FolKZJOyVzIFWl PmJvouVIirT7VEP+KABPoh3OOesDc7ZEt4yukXC2i0pC84XW7Ly5Nj9ZgFvn4pEdqa7c RfIIiLJy2RQS/j8G9wLGMDmW/MCj3l7+YOd4MCNXOvpkxkhym1Lc3HDVaO3QMzz04udp JlHGUaU2PDfwVfjLnJfl3NmvhSGuGOpJtuABiSwBuIBjlJCDejRYVpoykpCAz5oc8Atm /NtKZREIlmuoPdueGPkBDHmfEeq1f/MaaP9QfRmurz3xlF+CehLOrNTTrFfHx4Q+Jvf+ 7vEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zenB0fvF8v9LEnZLKkAsA85Z8KWObb5c13LjpylZxxw=; b=C3oNZCzChhShdcV9Oz/GqbgLs+PJ96BkBxR8B/9wpw5JloURwef4tC7kVWpbKBg5sI 7fDUSzb53SQCt7WnO1LSCUFT8mcfKnAWk5izeKLqCuO2t52XxFcvlnDuAB3duwyRlLBh KCJOPLy43m7cDl38jmpzG4aQbD0VrxsT+gBlmNwWKU4DxpzjLJja+F94BzRlBIlUOHFo j+WfbTJM7+kmrItRSJ1UcLR+OmdggPuc+M02629VbHgMsnarJXqeYdg3B7qid73ABJVv 664TzzRtRtvLC1MYSP56gLl/RMnxeddNNLWcJQdXr5wrntpwr7hSfBqGFiPhurxqVRl5 NJSQ== X-Gm-Message-State: AOAM531PcSzncwArQHkrrX6LBLH2ot+WJePtgKBWF7YDBvKF/Xt0gEjA jswPkbHoVqnIaI5wQddr6U7kZAfBFAp571T3chc= X-Google-Smtp-Source: ABdhPJzmd7ahakZtPsoVhUgCyvqXEVKmVd83v6byjVJ1cxhIvKY96Q+YLn6q51qSl+n9zl8wS3ZdED4FOFR4xuPqQZY= X-Received: by 2002:a9d:6f0e:: with SMTP id n14mr12287323otq.173.1636721635955; Fri, 12 Nov 2021 04:53:55 -0800 (PST) MIME-Version: 1.0 References: <20211112124411.1948809-1-roberto.sassu@huawei.com> <20211112124411.1948809-5-roberto.sassu@huawei.com> In-Reply-To: <20211112124411.1948809-5-roberto.sassu@huawei.com> From: Ajay Garg Date: Fri, 12 Nov 2021 18:23:43 +0530 Message-ID: Subject: Re: [RFC][PATCH 4/5] shmem: Avoid segfault in shmem_read_mapping_page_gfp() To: Roberto Sassu Cc: ebiggers@kernel.org, tytso@mit.edu, corbet@lwn.net, viro@zeniv.linux.org.uk, hughd@google.com, akpm@linux-foundation.org, linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5E41420019FD X-Stat-Signature: 44re9gcndx6snbucpa99uoatt84fuoxg Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cXOZX0K1; spf=pass (imf26.hostedemail.com: domain of ajaygargnsit@gmail.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=ajaygargnsit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1636721637-447615 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000220, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Roberto. Identical patch has been floated earlier via : https://lore.kernel.org/linux-mm/CAMZfGtUp6dkT4OWzLhL8whqNnXAbfVw5c6AQogHzY3bbM_k2Qw@mail.gmail.com/T/#m2189d135b9293de9b4a11362f0179c17b254d5ab Thanks and Regards, Ajay On Fri, Nov 12, 2021 at 6:15 PM Roberto Sassu wrote: > > Check the hwpoison page flag only if the page is valid in > shmem_read_mapping_page_gfp(). The PageHWPoison() macro tries to access > the page flags and cannot work on an error pointer. > > Signed-off-by: Roberto Sassu > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 23c91a8beb78..427863cbf0dc 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4222,7 +4222,7 @@ struct page *shmem_read_mapping_page_gfp(struct address_space *mapping, > else > unlock_page(page); > > - if (PageHWPoison(page)) > + if (!IS_ERR(page) && PageHWPoison(page)) > page = ERR_PTR(-EIO); > > return page; > -- > 2.32.0 >