From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC382C433EF for ; Thu, 11 Nov 2021 17:45:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C96061268 for ; Thu, 11 Nov 2021 17:45:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C96061268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C7FD86B006C; Thu, 11 Nov 2021 12:45:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2F056B0071; Thu, 11 Nov 2021 12:45:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1DD86B0072; Thu, 11 Nov 2021 12:45:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id A3F186B006C for ; Thu, 11 Nov 2021 12:45:20 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 62F7B80E9D01 for ; Thu, 11 Nov 2021 17:45:20 +0000 (UTC) X-FDA: 78797376000.08.04810C6 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 1E1C230000B6 for ; Thu, 11 Nov 2021 17:45:05 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id v15-20020a9d604f000000b0056cdb373b82so2009322otj.7 for ; Thu, 11 Nov 2021 09:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=+LpyPIoZTKI9UToEAiLTdSPomWKgk1C2icqdbicCgnc=; b=BW/VDT7VHtQPLLVudjdLklsUw34VamOFBVSTwdoSlF7QOfMR7lBmwsh1DKV/DK9SxW XCITELNN+LNqajmFI2m48h24/wdW2G0RcmKu82cdQgWQWDPUd+8lWnhO1gnhF7l+GpTg VJW5w/TQFbA1S2hoqV+dfjBG+BtiyvHecv5pI/yXDJWWaYkcGgPQAzwM7cM3Nx3wr8Hz EUs0liLj9LiSFWn3GX6tZAzalCdxjMbbNQ/RwTAufZObjl00kBSWzVv54CiifK8CMOsc 3ZwNj935wD+J9OtFontXTgRjZiQSsYRKM25DP1PkXhf0d1tXCCiJ1g6/htrOBcgG75WV Jfvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=+LpyPIoZTKI9UToEAiLTdSPomWKgk1C2icqdbicCgnc=; b=epPmnFfe48g1JliVbgOffxufmnD+SZQQuHbHVa7pTWzUMEvWgUh6v6LsD97MkVe2OL KNv53okwPFPBlNz0K6U1bbPU8+j33dNfvalZVaYwL9U2pK8kguzEOKhzJXmP/xDDLZXB DZkClElktULJpJFKqJ6gDdIdlvdH/RsW8nQqWEmsn2yhC0QsEb29SuYHIUb3RcMgme4C P8pgln686TrAtDAOTfWOQpUruz3VVJwcb71yEs3XXWf2He9DHRqMr+nGs68mrAOFv7ok 2k0suhPkUeuomhmvj3iLBSytIgh4WsNpPJ3k9QwiBvlP79WHXD6cHGv6Sa5PMILFjSy2 0gKQ== X-Gm-Message-State: AOAM531UUzrAykxN0EhEd6edjbvkWagtPtDW1AKi8hZCEcm2wsqBXXhW 79yhIsPHOTNxlu3l+gTKrFbcrc2ZHqXsemibJ0M= X-Google-Smtp-Source: ABdhPJwhU6/85AHCrZderRz4f6gsysgalGuYs3mFuR7mgKdtwcALY5Qo7BvzSgkqqCO8XL0+K9WK3ay6Ery7UlUHR9c= X-Received: by 2002:a9d:6f0e:: with SMTP id n14mr7305130otq.173.1636652719114; Thu, 11 Nov 2021 09:45:19 -0800 (PST) MIME-Version: 1.0 References: <20211111084617.6746-1-ajaygargnsit@gmail.com> In-Reply-To: <20211111084617.6746-1-ajaygargnsit@gmail.com> From: Ajay Garg Date: Thu, 11 Nov 2021 23:15:07 +0530 Message-ID: Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page To: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jens Axboe Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1E1C230000B6 X-Stat-Signature: qgoujpxrxfqoxgg44uqqnx5ch4ihtdch Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="BW/VDT7V"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of ajaygargnsit@gmail.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=ajaygargnsit@gmail.com X-HE-Tag: 1636652705-509184 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Another report of the issue (different call-flow, but the same error at "shmem_read_mapping_page_gfp") at : https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m52d98b6bdb05764524a118b15cec048b34e5ca76 with a tentative approval for the patch : https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m24c2888a879d428cde5b34c43838301de544eb7e Thanks and Regards, Ajay On Thu, Nov 11, 2021 at 2:16 PM Ajay Garg wrote: > > commit b9d02f1bdd98 > ("mm: shmem: don't truncate page if memory failure happens") > > introduced a PageHWPoison(page) call in "shmem_read_mapping_page_gfp" > in shmem.c. > > Now, if "shmem_getpage_gfp" returns an error, page is set to ERR-page. > Therafter, calling PageHWPoison() on this ERR-page, causes KASAN to OOP > the kernel : > > ############################# > BUG: unable to handle page fault for address: fffffffffffffff4 > PF: supervisor read access in kernel mode > PF: error_code(0x0000) - not-present page > PGD 18e019067 P4D 18e019067 PUD 18e01b067 PMD 0 > Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN PTI > CPU: 0 PID: 4836 Comm: MATLAB Not tainted 5.15.0+ #18 > Hardware name: Dell Inc. Latitude E6320/0GJF11, BIOS A19 11/14/2013 > RIP: 0010:shmem_read_mapping_page_gfp+0xd3/0x140 > Code: 4c 89 ff e8 6f eb ff ff 5a 59 85 c0 74 64 48 63 d8 48 89 5d 98 be 08 00 00 00 48 89 df e8 e5 67 0c 00 48 89 df e8 6d 5c 0c 00 <48> 8b 13 48 c7 c0 fb ff ff ff f7 c2 00 00 80 00 74 30 48 ba 00 00 > RSP: 0018:ffff88806b33f998 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: fffffffffffffff4 RCX: ffffffffb7a37ba3 > RDX: 0000000000000003 RSI: dffffc0000000000 RDI: fffffffffffffff4 > RBP: ffff88806b33fa20 R08: 1ffffffffffffffe R09: fffffffffffffffb > R10: fffffbffffffffff R11: 0000000000000001 R12: 1ffff1100d667f33 > R13: 00000000001120d2 R14: 00000000000005db R15: ffff88814e64e2d8 > FS: 00007f379a384640(0000) GS:ffff888161a00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: fffffffffffffff4 CR3: 00000000269dc004 CR4: 00000000000606f0 > Call Trace: > > ? shmem_fault+0x480/0x480 > ? __cond_resched+0x1c/0x30 > ? __kasan_check_read+0x11/0x20 > shmem_get_pages+0x3a4/0xa70 [i915] > ? shmem_writeback+0x3b0/0x3b0 [i915] > ? i915_gem_object_wait_reservation+0x330/0x560 [i915] > ... > ... > ################################ > > So, we proceed with PageHWPoison() call, only if the page is not a > ERR-page. > > > P.S. : Alternative (optimised) solution : > =========================================== > > We could save some CPU cycles, if we directly replace > > if (error) > page = ERR_PTR(error); > else > unlock_page(page); > > with > > if (error) > return ERR_PTR(error); > > > Fixes: b9d02f1bdd98 ("mm: shmem: don't truncate page if memory failure happens") > Signed-off-by: Ajay Garg > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 23c91a8beb78..427863cbf0dc 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4222,7 +4222,7 @@ struct page *shmem_read_mapping_page_gfp(struct address_space *mapping, > else > unlock_page(page); > > - if (PageHWPoison(page)) > + if (!IS_ERR(page) && PageHWPoison(page)) > page = ERR_PTR(-EIO); > > return page; > -- > 2.30.2 >