From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05155C433F5 for ; Thu, 11 Nov 2021 12:21:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A605B61268 for ; Thu, 11 Nov 2021 12:21:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A605B61268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4BFA96B0082; Thu, 11 Nov 2021 07:21:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46F156B0083; Thu, 11 Nov 2021 07:21:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35EDD6B0085; Thu, 11 Nov 2021 07:21:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 2822E6B0082 for ; Thu, 11 Nov 2021 07:21:19 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DC7A11851201E for ; Thu, 11 Nov 2021 12:21:18 +0000 (UTC) X-FDA: 78796559436.17.37AAA9E Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 04670801AB00 for ; Thu, 11 Nov 2021 12:21:17 +0000 (UTC) Received: by mail-oi1-f170.google.com with SMTP id n66so11207991oia.9 for ; Thu, 11 Nov 2021 04:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XNCNosYC3u6u2Mjz7khzOIp97EFpsZKMODemK/MK/ZI=; b=AXMpIhK/6muumVJud8eHYw6MxUOfdBCuofMOaTKVf6BVuARJVXwn96pmLWIUAaHR94 MX4P+DHduSzKQQG+4hgdOxGWiH0bkBLa5Ax2d0mSfh8XPOP2AW8+6eO552Nhjgs+V+Gl puOv+fA2is+iLY2tZlfChJCNL3zSXYbN2AXWQtGgF3zxarLAO9xGv3JmdBrwG1vG4j1Y 1cUuWWjukz6hdgOmEBn4COHL9UW2mURMxiWOD8mFid+62uClLy6s35v6nryxVeI4eCT7 T8zVrAqJSktwbSpMDRl3RKn8HguyvsCqhCbS1mXJshs6AY1wLXrcE8OfoJkFf03nueKj 21UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XNCNosYC3u6u2Mjz7khzOIp97EFpsZKMODemK/MK/ZI=; b=CjV7Zqy7Up6yu3NOPECeIzgUbglRld1zl/LeVNrlGNjKA6EVywF5QmWKDkQ9QCRLGf EQN2rL3LVTYP11gN8zY/pRiyBVTWQRYDSMz9YSAe2mAouqctFPGr4oND1WCqbXIITHdP MRSpyR/Pdc/GEr5zzmpZfcm1pasq+r+MYVz0WqiuhXzP2SPgTZYK9AQYIT8dmM0BT9mE /1jmsl99XPeD3DhKWv8j6tUU8oUs21RYcyE5SkHcLWBofCRr6N4G3pwlzKVpiswT3N0O b1wh24MDpMXCezgxnpSh7yIRJe/VwrNq8gBDBy9yPJSWYXOoWMLl5fr29mCe6pPXYNA2 KPng== X-Gm-Message-State: AOAM532ws3rPl49CmCuUT93yMuQ6VIcRQcCKF5XVRNuhyiIY48+aHH+o +5YmY8Hj+Yil2ml9zGOgLKkH9w0d6IEN47tLs08= X-Google-Smtp-Source: ABdhPJxPC+xhOyBF+tcDC+eGVh8fZqAT5jd7ubOPAfbG1qB1LsVtNZ9jo6CnbTauWP/IUdBWzbWnLLAjal/SmsNZOKc= X-Received: by 2002:aca:a989:: with SMTP id s131mr6048527oie.71.1636633277302; Thu, 11 Nov 2021 04:21:17 -0800 (PST) MIME-Version: 1.0 References: <20211111084617.6746-1-ajaygargnsit@gmail.com> <6864f744-ca3e-f328-8793-2adb0146db03@bytedance.com> In-Reply-To: From: Ajay Garg Date: Thu, 11 Nov 2021 17:51:05 +0530 Message-ID: Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page To: Muchun Song Cc: Hugh Dickins , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 04670801AB00 X-Stat-Signature: ycqbb9iu13gtx8t777yuw5yguy7w9hkg Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="AXMpIhK/"; spf=pass (imf06.hostedemail.com: domain of ajaygargnsit@gmail.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=ajaygargnsit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1636633277-39731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > What? I put "if (PageHWPoison(page))" into the else branch, > it should be added braces since it's not 1-line blocks. Oh, ok. > Why do > you think it does not address the issue? What am I missing > here? That might work, however I haven't tested it. Upto the reviewers to see what they see as the best way going forward. Thanks and Regards, Ajay