From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD7DC25B74 for ; Mon, 27 May 2024 23:20:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96F606B0088; Mon, 27 May 2024 19:20:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91F606B008A; Mon, 27 May 2024 19:20:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E6CF6B008C; Mon, 27 May 2024 19:20:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 611DD6B0088 for ; Mon, 27 May 2024 19:20:43 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 10288C1080 for ; Mon, 27 May 2024 23:20:43 +0000 (UTC) X-FDA: 82165747566.26.847859F Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf13.hostedemail.com (Postfix) with ESMTP id 517F32000D for ; Mon, 27 May 2024 23:20:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SxBhuIo+; spf=pass (imf13.hostedemail.com: domain of rgbi3307@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=rgbi3307@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716852041; a=rsa-sha256; cv=none; b=NPzHPw7xtJwY7MVFQxgsxdIanTUalxgfkCyFp7Q0ljUuyl7+9EkYdaQj8G1bko2qJeZcRG 3MMIy5teay6z3rZb6i8h+gDHUvyXVOrtJzfjuVp0lKe2Dtu4XvEzDKNnjlhTqw7RRkoXV+ pLhA6QHy/srJLGVGRjWhchidII7nWfE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SxBhuIo+; spf=pass (imf13.hostedemail.com: domain of rgbi3307@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=rgbi3307@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716852041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7v8nyfneetP058M0TF7TFC6gyu5q7DfMf80A5cRq4GY=; b=b+HiN5+DiCD5kNzGbDp9FbhTZvNQZD48R6KLQT0W/fxKKPs6N7XIN8ke0xxTif3dt+GkWP zbeHYM5cMXZTTDKWo50tZkNr6TKtL1tXF7MwzITkqopww0zRFzXA7v1wpnXXEVYhJL7jIV xYmdPX/LnaJeYk8MZhouJYGQ4eZ345A= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a5dcb5a0db4so29712166b.2 for ; Mon, 27 May 2024 16:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716852040; x=1717456840; darn=kvack.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=7v8nyfneetP058M0TF7TFC6gyu5q7DfMf80A5cRq4GY=; b=SxBhuIo+VSnbcBcW29DSWl5FRsMr9yAsNP8q3Lc4fmVzGMc4+rz5GgRey/ciJGFQ0k ia4DfxN2UhxszeN52T1ZS9BpihlBSSBVA0VNEdM44CjDNRd+oZcW7s+u1FQXzU4LlxO+ HTdENn+v//Tsz+GX++BWVtcAMVDM+AdTjGFRWMOjMe7oRyofzBSRj9MOn4dlSfCr6+T7 4wZlXdwoTa1y/dVFUw6bz5oG5lMCyoZ0pMtFSlaG303dEwcDKQvGk3IjvxnifCh2hcZB v02naasLKa0ioOSl1WesXNgVbQRwRaGTx/AYMBcZYdhSF5ne6HfhEjI5MYjZNJoX5/1K QmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716852040; x=1717456840; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7v8nyfneetP058M0TF7TFC6gyu5q7DfMf80A5cRq4GY=; b=dA0YXE7w7EtREPLjpbSKZOh/2sa5W61DzLyqLRwO49Id+94JtOhE2dddZnsraWXDga yyymr+uMGaq2v/6FM5qfkOX1G82Zy7jEtvUxLJv0GGgU90EwLkfCmTUp9rjlJwIEldLG 9JXD/QYDGpJ/QnvBI11ECmXhbY2XyjUY2UJUtJ+dO9sRYTWijw5S1WRLSVpdn6i+2Z8j 1GK8hTDie+ebammDrLnPXPezzQQcFEmEjTnUu/N7cYpq4vaExkzgrSc7a8Yfwlx1YLqN sGIuHJooUrAKhe776Zbyrh7BHf6Gw3MkKus3KMpY/QxrOkL06I5Byxu3FtySibGiA+O/ cEMQ== X-Forwarded-Encrypted: i=1; AJvYcCVK4XnI2TnJpfVB2pyMGWbYPJ5g63nkpZr4Odjz1B0638wZHZisGaxtN8yx78Y+SivrFTfwIf8D5mAxasTCmLT3MjA= X-Gm-Message-State: AOJu0Yxo6wbWrkhumLoWm6WCdTIGS8I7t2UuIQTkSwyg6LAR8KXtYiTP +LzI1JimH/2Z8qJQ3Td1YGWfGnecL5kJ0m+HbyuFh8F/Ls3NjmtwhRAC2vLnJHz8obgSTeyJjdo fRiBZyFruWTbjMu2X9fHoj5AQOoQ= X-Google-Smtp-Source: AGHT+IGrRbaj+fNgmNraE/lQCqbggMELagqivzQh//6K8V8qFCHvqTHod/bsN63C4sPeX+s7TwVF75zwFYwaFJeALfA= X-Received: by 2002:a17:906:491a:b0:a59:c844:beea with SMTP id a640c23a62f3a-a626511622emr604826066b.73.1716852039560; Mon, 27 May 2024 16:20:39 -0700 (PDT) MIME-Version: 1.0 References: <20240525010223.1704-1-rgbi3307@naver.com> In-Reply-To: From: JaeJoon Jung Date: Tue, 28 May 2024 08:20:27 +0900 Message-ID: Subject: Re: [PATCH] maple_tree: modified return type of mas_wr_store_entry() To: "Liam R. Howlett" , JaeJoon Jung , maple-tree@lists.infradead.org, "" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 517F32000D X-Stat-Signature: uobm5jzsapiz89mdqcob9i5eq4sgqnxx X-HE-Tag: 1716852041-267009 X-HE-Meta: U2FsdGVkX1+rDpH/ChGeq8y5vxSy/pIYSvErELFOZPTxqJtJ27qD3diDUedTg5w+i8ODQBcBGFJW2Srg6Zc8Wk3uOrdN0Dl7p+y1QMCelAjbgkYGFjSY04sUwuVpXBrf4MzFldKSEakyxau6/t5F9A4jE3d+Rld2vuxI8JHk/zd24jTUnDnhQGtIgQf0KbHM93NKn/ji1FEBafQsWNdIaTblxUj2tSf0ICqsqVyvBEYMoDtb5zgG1z+UhKr6M/khfEiDr+Dd6dOpOwRQPYITpTAaV8W4r3aBA658WEGfjyelfNTbyv5cLDTvNrilbkx+/5i4QN0XCtguHsdH48aWiHMU2TrNdD/v2xIUZZRCG8Jc5umtU4/KCY2uUQCfYe0HmCHXyhRsWa5AOT6v3HtPvQVrRHuHZ08oeg5FhrrBJzv6UzJhuQuOuQcjSCoHND8ZOKt1G/eM1yOHwjjkCGvD2rIOPGWDDX0iUthdwvPzZLqSvMjjsl71Ey5J7wkGoemJqefbErTHzXbk9FBq1Ms+G5pMduF7tu0WDNCHpI+qRzh+jqcDswxvD2evhkmLwju44uZnRLHQbo26Ojx6BYjRn4LaJ9YEPt60llCk0iSTWpW0BvVqbx7X9Gq1b45w7z76a1+jPm/GvWJuPpoybK2648wQVbzRs2j7dl0a1hIfWYWBnKSi7zbZwJivBTRGVIgxTPIY16kr1s86wbnzdAcF/C7f1ekGXwSP/N5jHK/N6M7ISXj+FomJpjGHHC8VB0V76HX+c6UfQSwSqymuVZiJ3WV4l8XhxRPIBKItAX3dSe9222g42W0n+/nYjGQJvGaC8Bp5Gimj6XgUpq5JZJZEQeLkHAoR5xxZWRhDDKFC2/XaugQxxzShaGczWLvVBWxrxuhDNbnIG/NkrD1ZhpG3wXwzJI5gqG8oPBl+2RDqbN0s5EUvhj+YNMZiV0pBeNOAJOXwe9jxjCcoWAcuMZx xUPGjeYs ZyTq5aimMfLTFlY9ztPBT/9/WLAvZTany+LlDNCHCI92Sz/sfTBr/36lPeb7NPH87FRqEL61Mm7rYmsJFgRNEjZ9LvqjnzO9beH837g/H1n3SfagZjALJoQrvZuK+i+6KO+RRVWtepBqjkFbse3yT2HSlT6J/eur4u4x8lLww2Kl7xm/wE6l8s+a05pTGJPUkLgQIR0nawW45tyCuYH6DMn8nC1T9orgLVW5f02r8UFiy/NqEE0nNn7R5a44QeuM4zGoP6WLwbyqIep2yNp09sN9VnMxqcjV/0eyXEergvWr46yxel8lBBk3bSKgmu4TNWj6IKM7uI1Xp9603t0BcxwDdmH6LIp2V2L6QRGbCH8C0M+GA0OY1ycmf5pbj2LMkev/2ZaHUPDWKtFxPQyo2CZUupgfE9vyfBMqPmlhy1w/+VXn4oR57HUqxBRPFHpxLXrfH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thank you so much for clarifying and correcting my comments and sharing it with relevant groups. On Tue, 28 May 2024 at 00:08, Liam R. Howlett wrote: > > * JaeJoon Jung [240524 21:02]: > > From: Jung-JaeJoon > > > > Thank you for your cleanup patch. > > I have added two more mailing lists to the Cc. Please Cc them on any > other patches related to the maple tree and mm area. > > > Since there is no place to use the return value of the mas_wr_store_entry() function, > > it is correct to modify it to void. > > This comment isn't clear. > > Maybe something like (please, modify it to your liking): > "Since the return value of mas_wr_store_entry() is not used, the return > type can be changed to void" > > > > > Signed-off-by: JaeJoon Jung > > --- > > lib/maple_tree.c | 15 ++++++--------- > > 1 file changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > > index 2d7d27e6ae3c..da30977aab0f 100644 > > --- a/lib/maple_tree.c > > +++ b/lib/maple_tree.c > > @@ -4203,31 +4203,28 @@ static inline void mas_wr_modify(struct ma_wr_state *wr_mas) > > * > > * Return: The contents that was stored at the index. > > */ > > -static inline void *mas_wr_store_entry(struct ma_wr_state *wr_mas) > > +static inline void mas_wr_store_entry(struct ma_wr_state *wr_mas) > > { > > struct ma_state *mas = wr_mas->mas; > > > > wr_mas->content = mas_start(mas); > > if (mas_is_none(mas) || mas_is_ptr(mas)) { > > mas_store_root(mas, wr_mas->entry); > > - return wr_mas->content; > > + return; > > } > > > > if (unlikely(!mas_wr_walk(wr_mas))) { > > mas_wr_spanning_store(wr_mas); > > - return wr_mas->content; > > + return; > > } > > > > /* At this point, we are at the leaf node that needs to be altered. */ > > mas_wr_end_piv(wr_mas); > > /* New root for a single pointer */ > > - if (unlikely(!mas->index && mas->last == ULONG_MAX)) { > > + if (unlikely(!mas->index && mas->last == ULONG_MAX)) > > mas_new_root(mas, wr_mas->entry); > > - return wr_mas->content; > > Please keep this return statement, as you did above, for consistency and > code clarity. > > > - } > > - > > - mas_wr_modify(wr_mas); > > - return wr_mas->content; > > + else > > + mas_wr_modify(wr_mas); > > } > > > > /** > > -- > > 2.17.1 > >