From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF189CD5BBD for ; Tue, 19 Sep 2023 13:43:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A4A26B0520; Tue, 19 Sep 2023 09:43:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 754256B0522; Tue, 19 Sep 2023 09:43:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F56F6B0523; Tue, 19 Sep 2023 09:43:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4F7E86B0520 for ; Tue, 19 Sep 2023 09:43:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 222EB40D14 for ; Tue, 19 Sep 2023 13:43:03 +0000 (UTC) X-FDA: 81253463046.09.F98C5C0 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 651DC14002E for ; Tue, 19 Sep 2023 13:43:01 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dya0to7n; spf=pass (imf09.hostedemail.com: domain of matteorizzo@google.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=matteorizzo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695130981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GMlnkrwj3wlCF+Jb6rf6z2cdXhhcVQub12RMSixV2mg=; b=6nhsEq3qDO1sW5W3Xy6YmlTdQJBEHUT4NpR97JpIJTfVxt6OaK2B7JrdEdPXwX3i5azvTC XIvumw/RTa1QS0XUh5L0omTV9Jd2Ac1qulhd2OeZ6ErxEdwPwV5CsM40q/IDY8y06e4XmJ Aw9ht7PZ/zf1F2xL88AiM3kCwXBDB+w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695130981; a=rsa-sha256; cv=none; b=owhUQKVp1FeQroLejuYyCwVgl+jI38xdSwSY3bpHqPdg5D0quQzh8VasYMLFgw4lL2pvoA 22QCk0dhM4q8oy7wkvdxCvY8b0Hoiy21/u3B70Pqq8jwME9f7JS4nJ5S9A9rcxBSD5Kyph 3lhdYHyPiM9krF0Bu97jF/iwkuL3+BA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dya0to7n; spf=pass (imf09.hostedemail.com: domain of matteorizzo@google.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=matteorizzo@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-76dc77fd01fso366950585a.3 for ; Tue, 19 Sep 2023 06:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695130980; x=1695735780; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GMlnkrwj3wlCF+Jb6rf6z2cdXhhcVQub12RMSixV2mg=; b=dya0to7nayx5zP4dLlQ0cNgjEP6TPn+ijHmRNnR6NKwBpSIDfn45FmUISLAsdqVokS VcgZOh5ncS9B5hV7uG4INwFGSVbwb6ZkveFn4vsuycrv0M8t0UCNw/VoxwuEgAWr78I8 EZOistQlOOmn4pTculQX9knr7fcd14+Pb0hbobySpcT8H+D1QwZTycpKUDBIcpkkYNWw fSy9sW3H8tb2XT+muvJpY4SIBNHwEMS2fcCeIXrAIfC49ncYoWerngXFu7ubY9PR8LW3 cZE6/U58CcQPj2VqyM0QDU6T9BfEmypSaD7s7aFvr1yoyHvlz4hRmBGdXQLEKRMWKUoV GvzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695130980; x=1695735780; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GMlnkrwj3wlCF+Jb6rf6z2cdXhhcVQub12RMSixV2mg=; b=MpdCO9eO/f4Zcv3imaUwc+ZckT6xaVPyq0lRr05wJGD+PalsXP8vHsBY9dCrpuCOeh J7Ms7XLUtKF2gL7gR620gHEKTDD2RlCi0D6AeVV/2nFS1C6vQLpuAmusHjLSpu+YKvqy IE0OGJor75KcZ7hKl/kRPmjrdk+Oku5hbBr+/nKLK/y+cduuIGEIpoYi5AB9fvMAS9pR GSLdX1ofLS80JyvIE0l8QlouIqOzf0rwSQniRCLtQ7vOWmhkWIqxAg755+VL3+IY/1eT jUxmc7tmFwvJ2xk29RBEHbB1Khat1ty7nT7KelH1SFAxH6HQs92uJCwJWGnaAXVvcihV UDfg== X-Gm-Message-State: AOJu0YwF7SPCNKX/R/oFEgAxFZWuap6qnziFwoPxjZWRYP9ZnQA5/Qv1 nLs0P2c4Owlk7+jhKGJ1Xs2C/+e7Tz9av4uVVr9mog== X-Google-Smtp-Source: AGHT+IEBV3N8+n/NZSfgTWS93NUWWOWhyAOuBw19vOjva0Icj9fEk+JQoETUIyeMKRf77QWVoAC03ml2/2E73G6yHRA= X-Received: by 2002:a0c:b384:0:b0:64f:8d4c:1c0b with SMTP id t4-20020a0cb384000000b0064f8d4c1c0bmr11206027qve.43.1695130980241; Tue, 19 Sep 2023 06:43:00 -0700 (PDT) MIME-Version: 1.0 References: <20230915105933.495735-1-matteorizzo@google.com> <7a4f5128-28fd-3c5f-34c2-1c34f4448174@intel.com> <1d7573c0-ebbc-6ed2-f152-1045eb0542f9@os.amperecomputing.com> In-Reply-To: From: Matteo Rizzo Date: Tue, 19 Sep 2023 15:42:47 +0200 Message-ID: Subject: Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator To: Ingo Molnar Cc: "Lameter, Christopher" , Dave Hansen , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, corbet@lwn.net, luto@kernel.org, peterz@infradead.org, jannh@google.com, evn@google.com, poprdi@google.com, jordyzomer@google.com, Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 651DC14002E X-Rspam-User: X-Stat-Signature: c6yuzdcj1ozt7ijb6km6h8pxtergrcei X-Rspamd-Server: rspam03 X-HE-Tag: 1695130981-374802 X-HE-Meta: U2FsdGVkX18jLUonZ/X8CHoNN1xF3EDqEr4aS3iG+j+Mz46yKiUlr0H2u98vhpOMlUVzNXElPgIuBCJuB4nk0tAljY97ATyXozNw++r5BLSYW+RFtPgcEhfqoDzoS5doCjR9vYXxb/LDFUa+Dc9DqqIx/gGbSR8CsKBp9euRdRHUDPV6Vi3Ygu2c1JgD5XkGD+8jVzjHmaBnDWg3zVUVjMll0dxhtPPOD8RoACIX2PZ0X0debtOxQ+Qm7hrBxZbtXRFihqVV8INuwZMIklbLOf/6GCEgf9EOeUGeosYDcmrPuq4wiPgVu9yVxZOe9o8m3pxAYVWAeww+y5ar+22LtK02ShLcPM8QEdUwqTobu53S69pvuQ/8NTjMm8yKEC6uiCbsPbevxHfoUCM+XqGj9llwVrUokfFmFuDasNWL0EjSX7qiwJwjg5YJdEZ2JneJ+GIdfpkezVF0Q0CO5x5qnz2eXkY6FmDTcG3AGxo+nt+NX82rhPQJAOexmBpylqbfRXJH1MYr6XMQ1lH2tXhRaC5cg0ToXW+seTF0vsPSSs/tIcodne/SzeiJ9c2TXNWCW73o1JbwQdQJHUxDXxH2/OVQEeBZXMFlvB05H+LsYRPXTH46iid1u0VH9aYuZSi1fjpz9AdFKpL7LYJNZ1+mnM4bUzU6H9k3EdSC2Nf48+Qu3dpNyaegiiAoJQnlrhA2qH1rKvDmyz2oDPhOOUlvTT3Q44xZ0qp9Virb2ARw3A7Jt0qMhY55Sg0/NPz+Oth4/uG10jbm4/b4jrTCTQDm6o7wlXM+8PTzzQWX8fJRCf1cV3H1lXv7GgsAnYol3irvXXDyrbAZ3981oU3OzlUmuRrM+REfgiDFsMEYAAb6E0ZWqM0/yeOEy5tn1w2Hfe0nXK1hnscID3Q4dFWdevmk5YrNAogj+sdXoznWlsBSmFdxLbb8NAoD0/DceKlt7p+u/7LhlmJZecG7x0gt3Q6 hE5yhrLf 9PAUL7MzGSVeeBKSRww0H8NbphYSJ1aJnyGG6ccr/mYWNO3y36y80FI+Ko+O9jmhLCJC6/7jUpVRRI7hggC0iU2q5MSkpNWJT0kKHf1GPkPoQ5yeqZ7o+t6oi21gOn8MHWriKPx9KCN4sFiYGeIqUDd4fK1jvfVGlP4zFzgtTXDcwEAak9r3T3XG5/MdnAJ5FL/TRWOpZtMHTAOlXGoyvl28GB9bETGkUaxgmGqcH3l9ttI4nrfGzipq+Yfoc5HGS+ZlR4k++ZxNNMkatLgfal9d7LrmyadH431pnokV6SztkJGGMm+Flq85AsIzQIgTmPvqNtKHypeXKyjeaykyr7/XHUz41/p1HvhYO1I2/gKFA/mI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 18 Sept 2023 at 19:39, Ingo Molnar wrote: > > What's the split of the increase in overhead due to SLAB_VIRTUAL=y, between > user-space execution and kernel-space execution? > Same benchmark as before (compiling a kernel on a system running the patched kernel): Intel Skylake: LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV ---------------+-------+----------+----------+----------+----------+-------- wall clock | | | | | | SLAB_VIRTUAL=n | 150 | 49.700 | 51.320 | 50.449 | 50.430 | 0.29959 SLAB_VIRTUAL=y | 150 | 50.020 | 51.660 | 50.880 | 50.880 | 0.30495 | | +0.64% | +0.66% | +0.85% | +0.89% | +1.79% system time | | | | | | SLAB_VIRTUAL=n | 150 | 358.560 | 362.900 | 360.922 | 360.985 | 0.91761 SLAB_VIRTUAL=y | 150 | 362.970 | 367.970 | 366.062 | 366.115 | 1.015 | | +1.23% | +1.40% | +1.42% | +1.42% | +10.60% user time | | | | | | SLAB_VIRTUAL=n | 150 | 3110.000 | 3124.520 | 3118.143 | 3118.120 | 2.466 SLAB_VIRTUAL=y | 150 | 3115.070 | 3127.070 | 3120.762 | 3120.925 | 2.654 | | +0.16% | +0.08% | +0.08% | +0.09% | +7.63% AMD Milan: LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV ---------------+-------+----------+----------+----------+----------+-------- wall clock | | | | | | SLAB_VIRTUAL=n | 150 | 25.480 | 26.550 | 26.065 | 26.055 | 0.23495 SLAB_VIRTUAL=y | 150 | 25.820 | 27.080 | 26.531 | 26.540 | 0.25974 | | +1.33% | +2.00% | +1.79% | +1.86% | +10.55% system time | | | | | | SLAB_VIRTUAL=n | 150 | 478.530 | 540.420 | 520.803 | 521.485 | 9.166 SLAB_VIRTUAL=y | 150 | 530.520 | 572.460 | 552.825 | 552.985 | 7.161 | | +10.86% | +5.93% | +6.15% | +6.04% | -21.88% user time | | | | | | SLAB_VIRTUAL=n | 150 | 2373.540 | 2403.800 | 2386.343 | 2385.840 | 5.325 SLAB_VIRTUAL=y | 150 | 2388.690 | 2426.290 | 2408.325 | 2408.895 | 6.667 | | +0.64% | +0.94% | +0.92% | +0.97% | +25.20% I'm not exactly sure why user time increases by almost 1% on Milan, it could be TLB contention. -- Matteo