From: Greg Thelen <gthelen@google.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Tejun Heo <tj@kernel.org>,
Dave Chinner <david@fromorbit.com>,
Sha Zhengju <handai.szj@gmail.com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-fsdevel@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] memcg: add per cgroup dirty page accounting
Date: Wed, 11 Mar 2015 15:57:33 -0400 [thread overview]
Message-ID: <CAHH2K0beuz+w71dh5U4FnB522xBW2mf4VhcvJsX2k+wQkLx5GQ@mail.gmail.com> (raw)
In-Reply-To: <55006C75.2050604@yandex-team.ru>
On Wed, Mar 11, 2015 at 12:25 PM, Konstantin Khlebnikov
<khlebnikov@yandex-team.ru> wrote:
> This patch conflicts with my cleanup which is already in mm tree:
> ("page_writeback: clean up mess around cancel_dirty_page()")
> Nothing nontrivial but I've killed cancel_dirty_page() and replaced
> it which account_page_cleaned() symmetrical to account_page_dirtied().
Fair enough. I'll rebase.
> I think this accounting can be done without mem_cgroup_begin_page_stat()
> All page cleaning happens under page is lock.
> Some dirtying is called without page-lock when kernel moves
> dirty status from pte to page, but in this case acconting happens
> under mapping->tree_lock.
>
> Memcg already locks pages when moves them between cgroups,
> maybe it could also lock mapping->tree_lock?
Good suggestion. I'll try it out and report back.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-03-11 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 4:50 Greg Thelen
2015-03-09 13:52 ` Tejun Heo
2015-03-09 15:29 ` Greg Thelen
2015-03-09 15:31 ` Tejun Heo
2015-03-11 16:25 ` Konstantin Khlebnikov
2015-03-11 19:57 ` Greg Thelen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHH2K0beuz+w71dh5U4FnB522xBW2mf4VhcvJsX2k+wQkLx5GQ@mail.gmail.com \
--to=gthelen@google.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=handai.szj@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox