From: Greg Thelen <gthelen@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Konstantin Khebnikov <khlebnikov@yandex-team.ru>,
Dave Chinner <david@fromorbit.com>,
Sha Zhengju <handai.szj@gmail.com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-fsdevel@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] memcg: add per cgroup dirty page accounting
Date: Mon, 9 Mar 2015 11:29:05 -0400 [thread overview]
Message-ID: <CAHH2K0aFJ1Ti+gWkHM1VC=mdLZQE2Yn+8gpvthOnv89DjmVAAQ@mail.gmail.com> (raw)
In-Reply-To: <20150309135234.GU13283@htj.duckdns.org>
On Mon, Mar 9, 2015 at 9:52 AM, Tejun Heo <tj@kernel.org> wrote:
> Hello, Greg.
>
> On Sun, Mar 08, 2015 at 09:50:32PM -0700, Greg Thelen wrote:
>> When modifying PG_Dirty on cached file pages, update the new
>> MEM_CGROUP_STAT_DIRTY counter. This is done in the same places where
>> global NR_FILE_DIRTY is managed. The new memcg stat is visible in the
>> per memcg memory.stat cgroupfs file. The most recent past attempt at
>> this was http://thread.gmane.org/gmane.linux.kernel.cgroups/8632
>
> Awesome. I had a similar but inferior (haven't noticed the irqsave
> problem) patch in my series. Replaced that with this one. I'm
> getting ready to post the v2 of the cgroup writeback patchset. Do you
> mind routing this patch together in the patchset?
I don't object to routing this patch with the larger writeback series.
But I do have small concern that merging the writeback series might
take a while and this patch has independent value. For now, I'd say:
go for it. If the series gets stalled we might want to split it off.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-09 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 4:50 Greg Thelen
2015-03-09 13:52 ` Tejun Heo
2015-03-09 15:29 ` Greg Thelen [this message]
2015-03-09 15:31 ` Tejun Heo
2015-03-11 16:25 ` Konstantin Khlebnikov
2015-03-11 19:57 ` Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHH2K0aFJ1Ti+gWkHM1VC=mdLZQE2Yn+8gpvthOnv89DjmVAAQ@mail.gmail.com' \
--to=gthelen@google.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=handai.szj@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox