From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
Rik van Riel <riel@redhat.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Michal Hocko <mhocko@suse.cz>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()
Date: Mon, 8 Apr 2013 16:57:44 -0400 [thread overview]
Message-ID: <CAHGf_=ruv9itn7fhcL=Ar7z_6wQ5Ga_4kj7Ui3EfDUe_cV7D0w@mail.gmail.com> (raw)
In-Reply-To: <1365449252-9pc7knd5-mutt-n-horiguchi@ah.jp.nec.com>
> - if (absent ||
> + /*
> + * is_swap_pte test covers both is_hugetlb_entry_hwpoisoned
> + * and hugepages under migration in which case
> + * hugetlb_fault waits for the migration and bails out
> + * properly for HWPosined pages.
> + */
> + if (absent || is_swap_pte(huge_ptep_get(pte)) ||
> ((flags & FOLL_WRITE) && !pte_write(huge_ptep_get(pte)))) {
> int ret;
Your comment describe what the code is. However we want the comment describe
why. In migration case, calling hugetlb_fault() is natural. but in
hwpoison case, it is
needed more explanation. Why can't we call is_hugetlb_hwpoisoned() directly?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-08 20:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 18:35 [PATCH v3 0/3] fix hugepage coredump Naoya Horiguchi
2013-04-03 18:35 ` [PATCH v3 1/3] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) Naoya Horiguchi
2013-04-03 19:20 ` Rik van Riel
2013-04-05 18:32 ` KOSAKI Motohiro
2013-04-05 18:40 ` Naoya Horiguchi
2013-04-03 18:35 ` [PATCH v3 2/3] fix hugetlb memory check in vma_dump_size() Naoya Horiguchi
2013-04-03 19:22 ` Rik van Riel
2013-04-03 21:14 ` Michal Hocko
2013-04-04 0:42 ` HATAYAMA Daisuke
2013-04-05 18:33 ` KOSAKI Motohiro
2013-04-03 18:35 ` [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page() Naoya Horiguchi
2013-04-03 20:01 ` Rik van Riel
2013-04-05 18:59 ` KOSAKI Motohiro
2013-04-08 19:27 ` Naoya Horiguchi
2013-04-08 20:57 ` KOSAKI Motohiro [this message]
2013-04-09 22:00 ` Naoya Horiguchi
2013-04-10 1:53 ` KOSAKI Motohiro
2013-04-10 8:07 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGf_=ruv9itn7fhcL=Ar7z_6wQ5Ga_4kj7Ui3EfDUe_cV7D0w@mail.gmail.com' \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox