From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx123.postini.com [74.125.245.123]) by kanga.kvack.org (Postfix) with SMTP id 6FF9C6B0044 for ; Fri, 12 Oct 2012 15:00:17 -0400 (EDT) Received: by mail-oa0-f41.google.com with SMTP id k14so3910454oag.14 for ; Fri, 12 Oct 2012 12:00:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <507276FD.4020808@cn.fujitsu.com> References: <506C0AE8.40702@jp.fujitsu.com> <506C0F53.5030500@jp.fujitsu.com> <507276FD.4020808@cn.fujitsu.com> From: KOSAKI Motohiro Date: Fri, 12 Oct 2012 14:59:56 -0400 Message-ID: Subject: Re: [PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Wen Congyang Cc: Yasuaki Ishimatsu , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org On Mon, Oct 8, 2012 at 2:47 AM, Wen Congyang wrote: > At 10/06/2012 02:56 AM, KOSAKI Motohiro Wrote: >> On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu >> wrote: >>> From: Wen Congyang >>> >>> The memory device has only one node id. Store the node id when >>> enable the memory device, and we can reuse it when removing the >>> memory device. >> >> You don't explain why we need this. Then nobody can review nor ack. >> > > This patch doesn't fix any problem. Its purpose is: avoid to calculate > the node id twice. ditto. Please separate patches as logical change. You should make problem fix patch set. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org