From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrea Righi <andrea@betterlinux.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Minchan Kim" <minchan.kim@gmail.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Johannes Weiner" <jweiner@redhat.com>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"Rik van Riel" <riel@redhat.com>,
"Hugh Dickins" <hughd@google.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Shaohua Li" <shaohua.li@intel.com>,
"Pádraig Brady" <P@draigbrady.com>,
"John Stultz" <john.stultz@linaro.org>,
"Jerry James" <jamesjer@betterlinux.com>,
"Julius Plenz" <julius@plenz.com>, linux-mm <linux-mm@kvack.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] fadvise: implement POSIX_FADV_NOREUSE
Date: Mon, 13 Feb 2012 11:22:26 -0500 [thread overview]
Message-ID: <CAHGf_=qs8-nE6y6EzNYUzgjGo0sMP5zvCc3=GNZmHct6mPecqg@mail.gmail.com> (raw)
In-Reply-To: <1329006098-5454-4-git-send-email-andrea@betterlinux.com>
> @@ -1181,8 +1258,22 @@ page_ok:
> * When a sequential read accesses a page several times,
> * only mark it as accessed the first time.
> */
> - if (prev_index != index || offset != prev_offset)
> - mark_page_accessed(page);
> + if (prev_index != index || offset != prev_offset) {
> + int mode;
> +
> + mode = filemap_get_cache(mapping, index);
> + switch (mode) {
> + case FILEMAP_CACHE_NORMAL:
> + mark_page_accessed(page);
> + break;
> + case FILEMAP_CACHE_ONCE:
> + mark_page_usedonce(page);
> + break;
> + default:
> + WARN_ON_ONCE(1);
> + break;
Here is generic_file_read, right? Why don't you care write and page fault?
next prev parent reply other threads:[~2012-02-13 16:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 0:21 [RFC] [PATCH v5 0/3] fadvise: support POSIX_FADV_NOREUSE Andrea Righi
2012-02-12 0:21 ` [PATCH v5 1/3] kinterval: routines to manipulate generic intervals Andrea Righi
2012-02-13 0:48 ` Andrea Righi
2012-02-12 0:21 ` [PATCH v5 2/3] mm: filemap: introduce mark_page_usedonce Andrea Righi
2012-02-12 0:21 ` [PATCH v5 3/3] fadvise: implement POSIX_FADV_NOREUSE Andrea Righi
2012-02-13 16:22 ` KOSAKI Motohiro [this message]
2012-02-13 18:00 ` Andrea Righi
2012-02-15 23:35 ` Arun Sharma
2012-02-15 23:47 ` Andrea Righi
2012-02-15 23:57 ` Arun Sharma
2012-02-16 0:56 ` Andrea Righi
2012-02-16 2:10 ` Arun Sharma
2012-02-16 10:39 ` Andrea Righi
2012-02-16 18:43 ` Arun Sharma
2012-02-16 18:57 ` Andrea Righi
2012-02-16 19:07 ` Arun Sharma
2012-02-27 2:33 ` KAMEZAWA Hiroyuki
2012-02-27 10:46 ` Andrea Righi
2012-02-14 21:33 ` [RFC] [PATCH v5 0/3] fadvise: support POSIX_FADV_NOREUSE Andrew Morton
2012-02-14 22:06 ` John Stultz
2012-02-14 22:59 ` Andrea Righi
2012-02-14 23:22 ` Andrew Morton
2012-02-15 1:35 ` Andrea Righi
2012-02-15 23:48 ` KAMEZAWA Hiroyuki
2012-02-16 0:43 ` Andrea Righi
2014-01-02 21:25 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGf_=qs8-nE6y6EzNYUzgjGo0sMP5zvCc3=GNZmHct6mPecqg@mail.gmail.com' \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=P@draigbrady.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=andrea@betterlinux.com \
--cc=hughd@google.com \
--cc=jamesjer@betterlinux.com \
--cc=john.stultz@linaro.org \
--cc=julius@plenz.com \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=shaohua.li@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox