From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx170.postini.com [74.125.245.170]) by kanga.kvack.org (Postfix) with SMTP id 53F766B005A for ; Fri, 19 Oct 2012 14:20:14 -0400 (EDT) Received: by mail-oa0-f41.google.com with SMTP id k14so892127oag.14 for ; Fri, 19 Oct 2012 11:20:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <508118A6.80804@cn.fujitsu.com> References: <506C0AE8.40702@jp.fujitsu.com> <506C0C53.60205@jp.fujitsu.com> <50727984.20401@cn.fujitsu.com> <507E77D1.3030709@cn.fujitsu.com> <508118A6.80804@cn.fujitsu.com> From: KOSAKI Motohiro Date: Fri, 19 Oct 2012 14:19:53 -0400 Message-ID: Subject: Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove() Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Wen Congyang Cc: Yasuaki Ishimatsu , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org > Hmm, IIRC, if the memory is recognized from kerenl before driver initialization, > the memory device is not managed by the driver acpi_memhotplug. Yup. > I think we should also deal with REMOVAL_NORMAL here now. Otherwise it will cause > some critical problem: we unbind the device from the driver but we still use > it. If we eject it, we have no chance to offline and remove it. It is very dangerous. ?? If resource was not allocated a driver, a driver doesn't need to deallocate it when error path. I haven't caught your point. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org