From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx153.postini.com [74.125.245.153]) by kanga.kvack.org (Postfix) with SMTP id 1D2ED6B0068 for ; Thu, 27 Sep 2012 21:13:37 -0400 (EDT) Received: by oagk14 with SMTP id k14so3117777oag.14 for ; Thu, 27 Sep 2012 18:13:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5064EA5A.3080905@jp.fujitsu.com> References: <1348724705-23779-1-git-send-email-wency@cn.fujitsu.com> <1348724705-23779-3-git-send-email-wency@cn.fujitsu.com> <5064EA5A.3080905@jp.fujitsu.com> From: KOSAKI Motohiro Date: Thu, 27 Sep 2012 21:13:13 -0400 Message-ID: Subject: Re: [PATCH 2/4] memory-hotplug: add node_device_release Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Yasuaki Ishimatsu Cc: wency@cn.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, minchan.kim@gmail.com, akpm@linux-foundation.org On Thu, Sep 27, 2012 at 8:07 PM, Yasuaki Ishimatsu wrote: > Hi Kosaki-san, > > > 2012/09/28 5:13, KOSAKI Motohiro wrote: >> >> On Thu, Sep 27, 2012 at 1:45 AM, wrote: >>> >>> From: Yasuaki Ishimatsu >>> >>> When calling unregister_node(), the function shows following message at >>> device_release(). >> >> >> This description doesn't have the "following message". >> >> > >>> Device 'node2' does not have a release() function, it is broken and must >>> be >>> fixed. > > > This is the messages. The message is shown by kobject_cleanup(), when > calling > unregister_node(). If so, you should quote the message. and don't mix it with your subject. Moreover your patch title is too silly. "add node_device_release() function" is a way. you should describe the effect of the patch. e.g. suppress "Device 'nodeXX' does not have a release() function" warning. Moreover, your explanation is still insufficient. Even if node_device_release() is empty function, we can get rid of the warning. Why do we need this node_device_release() implementation? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org