From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Michal Hocko <mhocko@suse.cz>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Expose sysctls for enabling slab/file_cache interleaving
Date: Wed, 20 Nov 2013 00:49:16 -0500 [thread overview]
Message-ID: <CAHGf_=py9fq51viTx1RfmAMf=t=TX=86nb8h6F7nW7qw=pCRow@mail.gmail.com> (raw)
In-Reply-To: <87y54kvz87.fsf@tassilo.jf.intel.com>
On Tue, Nov 19, 2013 at 4:49 PM, Andi Kleen <andi@firstfloor.org> wrote:
> Michal Hocko <mhocko@suse.cz> writes:
>>
>> Another option would be to use sysctl values for the top cpuset as a
>> default. But then why not just do it manually without sysctl?
>
> I want to provide an alternative to having to use cpusets to use this,
> that is actually usable for normal people.
>
> Also this is really a global setting in my mind.
>
>> If you create a cpuset and explicitly disable spreading then you would
>> be quite surprised that your process gets pages from all nodes, no?
>
> If I enable it globally using a sysctl I would be quite surprised
> if some cpuset can override it.
>
> That argument is equally valid :-)
>
> The user configured an inconsistent configuration, and the kernel
> has to make a decision somehow.
>
> In the end it is arbitary, but not having to check the cpuset
> here is a lot cheaper, so I prefer the "sysctl has priority"
> option.
sorry.
I agree with Michael. If there are large scope knob and small scope knob,
the small scope should have high priority. It is one of best practice of the
interface design.
However, I fully agree the basic concept of this patch. sysctl help a
lot of admins.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-11-20 5:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 0:50 Andi Kleen
2013-11-19 10:42 ` Michal Hocko
2013-11-19 18:42 ` Andi Kleen
2013-11-19 19:11 ` Michal Hocko
2013-11-19 20:13 ` Andi Kleen
2013-11-19 21:21 ` Michal Hocko
2013-11-19 21:49 ` Andi Kleen
2013-11-20 5:49 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGf_=py9fq51viTx1RfmAMf=t=TX=86nb8h6F7nW7qw=pCRow@mail.gmail.com' \
--to=kosaki.motohiro@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox