From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id AAD776B0068 for ; Thu, 27 Sep 2012 16:12:13 -0400 (EDT) Received: by obcva7 with SMTP id va7so2794292obc.14 for ; Thu, 27 Sep 2012 13:12:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1348724705-23779-2-git-send-email-wency@cn.fujitsu.com> References: <1348724705-23779-1-git-send-email-wency@cn.fujitsu.com> <1348724705-23779-2-git-send-email-wency@cn.fujitsu.com> From: KOSAKI Motohiro Date: Thu, 27 Sep 2012 16:11:52 -0400 Message-ID: Subject: Re: [PATCH 1/4] memory-hotplug: add memory_block_release Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: wency@cn.fujitsu.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, minchan.kim@gmail.com, akpm@linux-foundation.org, isimatu.yasuaki@jp.fujitsu.com On Thu, Sep 27, 2012 at 1:45 AM, wrote: > From: Yasuaki Ishimatsu > > When calling remove_memory_block(), the function shows following message at > device_release(). > > Device 'memory528' does not have a release() function, it is broken and must > be fixed. > > remove_memory_block() calls kfree(mem). I think it shouled be called from > device_release(). So the patch implements memory_block_release() Why do you think so? This is terribly bad change log. it has almost zero information. We can't review it. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > --- > drivers/base/memory.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 7dda4f7..da457e5 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -70,6 +70,13 @@ void unregister_memory_isolate_notifier(struct notifier_block *nb) > } > EXPORT_SYMBOL(unregister_memory_isolate_notifier); > > +static void release_memory_block(struct device *dev) > +{ > + struct memory_block *mem = container_of(dev, struct memory_block, dev); > + > + kfree(mem); > +} > + > /* > * register_memory - Setup a sysfs device for a memory block > */ > @@ -80,6 +87,7 @@ int register_memory(struct memory_block *memory) > > memory->dev.bus = &memory_subsys; > memory->dev.id = memory->start_section_nr / sections_per_block; > + memory->dev.release = release_memory_block; > > error = device_register(&memory->dev); > return error; > @@ -630,7 +638,6 @@ int remove_memory_block(unsigned long node_id, struct mem_section *section, > mem_remove_simple_file(mem, phys_device); > mem_remove_simple_file(mem, removable); > unregister_memory(mem); > - kfree(mem); > } else > kobject_put(&mem->dev.kobj); > > -- > 1.7.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org