linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Kees Cook <keescook@chromium.org>,
	"riel@redhat.com" <riel@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [patch -mm] mm, mempolicy: silence gcc warning
Date: Tue, 26 Nov 2013 13:40:09 -0500	[thread overview]
Message-ID: <CAHGf_=pbFF8odDqh6jN2rPNh_FJhBqeo=Zf0GwSD-RbwWuopGg@mail.gmail.com> (raw)
In-Reply-To: <20131125162059.6989ef1680d43ed7a0a042ff@linux-foundation.org>

>> diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
>> index 9fe426b..eee0597 100644
>> --- a/include/linux/mempolicy.h
>> +++ b/include/linux/mempolicy.h
>> @@ -309,6 +309,8 @@ static inline int mpol_parse_str(char *str, struct mempolicy **mpol)
>>
>>  static inline void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol)
>>  {
>> +     strncpy(buffer, "default", maxlen-1);
>> +     buffer[maxlen-1] = '\0';
>>  }
>>
>
> Well, as David said, BUILD_BUG() would be the preferred cleanup.  I'll
> stick one in there and see what the build bot has to say?

Sigh, I can't understand why you always prefer to increase maintenance annoying.
However up to you.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2013-11-26 18:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13  2:12 David Rientjes
2013-11-13 19:20 ` Kees Cook
2013-11-20 22:15 ` Andrew Morton
2013-11-20 22:19   ` Kees Cook
2013-11-23 20:49   ` KOSAKI Motohiro
2013-11-25 20:31     ` Andrew Morton
2013-11-25 23:30       ` David Rientjes
2013-11-25 23:33         ` [patch] mm, mempolicy: remove unneeded functions for UMA configs David Rientjes
2013-11-26  0:08       ` [patch -mm] mm, mempolicy: silence gcc warning KOSAKI Motohiro
2013-11-26  0:20         ` Andrew Morton
2013-11-26 18:40           ` KOSAKI Motohiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHGf_=pbFF8odDqh6jN2rPNh_FJhBqeo=Zf0GwSD-RbwWuopGg@mail.gmail.com' \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox