From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa0-f45.google.com (mail-oa0-f45.google.com [209.85.219.45]) by kanga.kvack.org (Postfix) with ESMTP id B1B296B00FE for ; Sun, 23 Mar 2014 13:42:58 -0400 (EDT) Received: by mail-oa0-f45.google.com with SMTP id eb12so4527131oac.32 for ; Sun, 23 Mar 2014 10:42:58 -0700 (PDT) Received: from mail-ob0-x231.google.com (mail-ob0-x231.google.com [2607:f8b0:4003:c01::231]) by mx.google.com with ESMTPS id be9si15370961obb.49.2014.03.23.10.42.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 23 Mar 2014 10:42:58 -0700 (PDT) Received: by mail-ob0-f177.google.com with SMTP id wo20so4633251obc.36 for ; Sun, 23 Mar 2014 10:42:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1395436655-21670-3-git-send-email-john.stultz@linaro.org> References: <1395436655-21670-1-git-send-email-john.stultz@linaro.org> <1395436655-21670-3-git-send-email-john.stultz@linaro.org> From: KOSAKI Motohiro Date: Sun, 23 Mar 2014 10:42:37 -0700 Message-ID: Subject: Re: [PATCH 2/5] vrange: Add purged page detection on setting memory non-volatile Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: John Stultz Cc: LKML , Andrew Morton , Android Kernel Team , Johannes Weiner , Robert Love , Mel Gorman , Hugh Dickins , Dave Hansen , Rik van Riel , Dmitry Adamushko , Neil Brown , Andrea Arcangeli , Mike Hommey , Taras Glek , Jan Kara , Michel Lespinasse , Minchan Kim , "linux-mm@kvack.org" On Fri, Mar 21, 2014 at 2:17 PM, John Stultz wrote: > Users of volatile ranges will need to know if memory was discarded. > This patch adds the purged state tracking required to inform userland > when it marks memory as non-volatile that some memory in that range > was purged and needs to be regenerated. > > This simplified implementation which uses some of the logic from > Minchan's earlier efforts, so credit to Minchan for his work. > > Cc: Andrew Morton > Cc: Android Kernel Team > Cc: Johannes Weiner > Cc: Robert Love > Cc: Mel Gorman > Cc: Hugh Dickins > Cc: Dave Hansen > Cc: Rik van Riel > Cc: Dmitry Adamushko > Cc: Neil Brown > Cc: Andrea Arcangeli > Cc: Mike Hommey > Cc: Taras Glek > Cc: Jan Kara > Cc: KOSAKI Motohiro > Cc: Michel Lespinasse > Cc: Minchan Kim > Cc: linux-mm@kvack.org > Signed-off-by: John Stultz > --- > include/linux/swap.h | 15 ++++++++-- > include/linux/swapops.h | 10 +++++++ > include/linux/vrange.h | 3 ++ > mm/vrange.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 101 insertions(+), 2 deletions(-) > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 46ba0c6..18c12f9 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -70,8 +70,19 @@ static inline int current_is_kswapd(void) > #define SWP_HWPOISON_NUM 0 > #endif > > -#define MAX_SWAPFILES \ > - ((1 << MAX_SWAPFILES_SHIFT) - SWP_MIGRATION_NUM - SWP_HWPOISON_NUM) > + > +/* > + * Purged volatile range pages > + */ > +#define SWP_VRANGE_PURGED_NUM 1 > +#define SWP_VRANGE_PURGED (MAX_SWAPFILES + SWP_HWPOISON_NUM + SWP_MIGRATION_NUM) > + > + > +#define MAX_SWAPFILES ((1 << MAX_SWAPFILES_SHIFT) \ > + - SWP_MIGRATION_NUM \ > + - SWP_HWPOISON_NUM \ > + - SWP_VRANGE_PURGED_NUM \ > + ) This change hwpoison and migration tag number. maybe ok, maybe not. I'd suggest to use younger number than hwpoison. (That's why hwpoison uses younger number than migration) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org