From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Rajman Mekaco <rajman.mekaco@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Al Viro <viro@zeniv.linux.org.uk>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Kautuk Consul <consul.kautuk@gmail.com>
Subject: Re: [PATCH 1/1] mmap.c: find_vma: remove unnecessary if(mm) check
Date: Sat, 21 Apr 2012 19:48:27 -0400 [thread overview]
Message-ID: <CAHGf_=ovyXxNwc8o=MjL9-6eReCA2UzDvLeLMqEHVPxiLiKOPQ@mail.gmail.com> (raw)
In-Reply-To: <1335015755-2881-1-git-send-email-rajman.mekaco@gmail.com>
On Sat, Apr 21, 2012 at 9:42 AM, Rajman Mekaco <rajman.mekaco@gmail.com> wrote:
> The if(mm) check is not required in find_vma, as the kernel
> code calls find_vma only when it is absolutely sure that the
> mm_struct arg to it is non-NULL.
>
> Removing the if(mm) check and adding the a WARN_ONCE(!mm)
> for now.
> This will serve the purpose of mandating that the execution
> context(user-mode/kernel-mode) be known before find_vma is called.
> Also fixed 2 checkpatch.pl errors in the declaration
> of the rb_node and vma_tmp local variables.
>
> I was browsing through the internet and read a discussion
> at https://lkml.org/lkml/2012/3/27/342 which discusses removal
> of the validation check within find_vma.
> Since no-one responded, I decided to send this patch with Andrew's
> suggestions.
>
> Signed-off-by: Rajman Mekaco <rajman.mekaco@gmail.com>
> Cc: Kautuk Consul <consul.kautuk@gmail.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-21 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 13:42 Rajman Mekaco
2012-04-21 23:48 ` KOSAKI Motohiro [this message]
2012-04-23 21:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGf_=ovyXxNwc8o=MjL9-6eReCA2UzDvLeLMqEHVPxiLiKOPQ@mail.gmail.com' \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=consul.kautuk@gmail.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rajman.mekaco@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox