From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx203.postini.com [74.125.245.203]) by kanga.kvack.org (Postfix) with SMTP id 095126B0095 for ; Sun, 26 May 2013 07:59:02 -0400 (EDT) Received: by mail-ob0-f182.google.com with SMTP id va7so186022obc.41 for ; Sun, 26 May 2013 04:59:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130526090054.GE10651@dhcp22.suse.cz> References: <1369547921-24264-1-git-send-email-liwanp@linux.vnet.ibm.com> <1369547921-24264-3-git-send-email-liwanp@linux.vnet.ibm.com> <20130526090054.GE10651@dhcp22.suse.cz> From: KOSAKI Motohiro Date: Sun, 26 May 2013 07:58:42 -0400 Message-ID: Subject: Re: [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Wanpeng Li , Andrew Morton , KAMEZAWA Hiroyuki , David Rientjes , Jiang Liu , Tang Chen , "linux-mm@kvack.org" , LKML , Greg Kroah-Hartman , stable@vger.kernel.org >> As KOSAKI Motohiro mentioned, memory hotplug don't support 32bit since >> it was born, > > Why? any reference? This reasoning is really weak. I have no seen any highmem support in memory hotplug code and I don't think this patch fixes all 32bit highmem issue. If anybody are interesting to support it, it is good thing. But in fact, _now_ it is broken when enable HIGHMEM. So, I just want to mark broken until someone want to support highmem and verify overall. And, yes, this patch is no good. Kconfig doesn't describe why disable when highmem. So, depends on 64BIT || !HIGHMEM || BROKEN maybe clear documentation more. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org