From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH RFC 3/3] proc/smaps: show amount of hwpoison pages
Date: Tue, 1 May 2012 14:14:57 -0400 [thread overview]
Message-ID: <CAHGf_=o_R8k-ywaAodrrHcnnjad01kp1szw_AuA-5AiB19fLew@mail.gmail.com> (raw)
In-Reply-To: <4FA02603.80807@openvz.org>
On Tue, May 1, 2012 at 2:05 PM, Konstantin Khlebnikov
<khlebnikov@openvz.org> wrote:
> KOSAKI Motohiro wrote:
>>
>> On Mon, Apr 30, 2012 at 7:29 AM, Konstantin Khlebnikov
>> <khlebnikov@openvz.org> wrote:
>>>
>>> This patch adds line "HWPoinson:<size> kB" into /proc/pid/smaps if
>>> CONFIG_MEMORY_FAILURE=y and some HWPoison pages were found.
>>> This may be useful for searching applications which use a broken memory.
>>
>>
>> I dislike "maybe useful" claim. If we don't know exact motivation of a
>> feature,
>> we can't maintain them especially when a bugfix can't avoid ABI change.
>>
>> Please write down exact use case.
>
> I don't know how to exactly use this hw-poison stuff, but smaps suppose to
> export state of ptes in vma. It seems to rational to show also hw-poisoned
> ptes,
> since kernel has this feature and pte can be in hw-poisoned state.
>
> and now everyone can easily find them:
> # sudo grep HWPoison /proc/*/smaps
First, I don't think "we can expose it" is good reason. Second, hw-poisoned mean
such process is going to be killed at next page touch. But I can't
imagine anyone can
use its information because it's racy against process kill. I think
admin should use mce log.
So, until we find a good use case, I don't ack this.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-01 18:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 11:29 [PATCH RFC 1/3] proc/smaps: carefully handle migration entries Konstantin Khlebnikov
2012-04-30 11:29 ` [PATCH RFC 2/3] proc/smaps: show amount of nonlinear ptes in vma Konstantin Khlebnikov
2012-05-01 17:39 ` KOSAKI Motohiro
2012-05-01 17:56 ` Konstantin Khlebnikov
2012-05-01 18:08 ` KOSAKI Motohiro
2012-04-30 11:29 ` [PATCH RFC 3/3] proc/smaps: show amount of hwpoison pages Konstantin Khlebnikov
2012-05-01 17:35 ` KOSAKI Motohiro
2012-05-01 18:05 ` Konstantin Khlebnikov
2012-05-01 18:14 ` KOSAKI Motohiro [this message]
2012-05-31 20:12 ` Andrew Morton
2012-05-01 18:29 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGf_=o_R8k-ywaAodrrHcnnjad01kp1szw_AuA-5AiB19fLew@mail.gmail.com' \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox