From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Cong Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Pekka Enberg <penberg@kernel.org>, Christoph Hellwig <hch@lst.de>,
Hugh Dickins <hughd@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Lennart Poettering <lennart@poettering.net>,
Kay Sievers <kay.sievers@vrfy.org>,
linux-mm@kvack.org
Subject: Re: [V3 PATCH 1/2] tmpfs: add fallocate support
Date: Wed, 23 Nov 2011 21:46:39 -0500 [thread overview]
Message-ID: <CAHGf_=oD0Coc=k5kAAQoP=GqK+nc0jd3qq3TmLZaitSjH-ZPmQ@mail.gmail.com> (raw)
In-Reply-To: <20111124105245.b252c65f.kamezawa.hiroyu@jp.fujitsu.com>
>> + while (index < end) {
>> + ret = shmem_getpage(inode, index, &page, SGP_WRITE, NULL);
>
> If the 'page' for index exists before this call, this will return the page without
> allocaton.
>
> Then, the page may not be zero-cleared. I think the page should be zero-cleared.
No. fallocate shouldn't destroy existing data. It only ensure
subsequent file access don't make ENOSPC error.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-24 2:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 8:53 Cong Wang
2011-11-23 8:53 ` [PATCH 2/2] fs: wire up .truncate_range and .fallocate Cong Wang
2011-11-23 10:38 ` Christoph Hellwig
2011-11-23 19:16 ` Hugh Dickins
2011-11-23 9:06 ` [V3 PATCH 1/2] tmpfs: add fallocate support Pekka Enberg
2011-11-23 19:07 ` Hugh Dickins
2011-11-24 3:18 ` Cong Wang
2011-11-23 19:59 ` KOSAKI Motohiro
2011-11-23 21:11 ` Pekka Enberg
2011-11-23 22:20 ` Hugh Dickins
2011-11-24 3:15 ` Cong Wang
2011-11-24 1:52 ` KAMEZAWA Hiroyuki
2011-11-24 2:46 ` KOSAKI Motohiro [this message]
2011-11-24 3:01 ` KAMEZAWA Hiroyuki
2011-11-24 3:22 ` Cong Wang
2011-11-24 4:23 ` KAMEZAWA Hiroyuki
2011-11-24 5:52 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGf_=oD0Coc=k5kAAQoP=GqK+nc0jd3qq3TmLZaitSjH-ZPmQ@mail.gmail.com' \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kay.sievers@vrfy.org \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox