From: Scott Jiang <scott.jiang.linux@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Bob Liu <lliubbo@gmail.com>,
linux-mm@kvack.org, bhupesh.sharma@st.com,
laurent.pinchart@ideasonboard.com,
uclinux-dist-devel@blackfin.uclinux.org,
linux-media@vger.kernel.org, dhowells@redhat.com,
geert@linux-m68k.org, gerg@uclinux.org, stable@kernel.org,
gregkh@linuxfoundation.org, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] nommu: remap_pfn_range: fix addr parameter check
Date: Fri, 14 Sep 2012 17:23:12 +0800 [thread overview]
Message-ID: <CAHG8p1CJ7YizySrocYvQeCye4_63TkAimsAGU1KC5+Fn0wqF8w@mail.gmail.com> (raw)
In-Reply-To: <20120913122738.04eaceb3.akpm@linux-foundation.org>
> Yes, the MMU version of remap_pfn_range() does permit non-page-aligned
> `addr' (at least, if the userspace maaping is a non-COW one). But I
> suspect that was an implementation accident - it is a nonsensical thing
> to do, isn't it? The MMU cannot map a bunch of kernel pages onto a
> non-page-aligned userspace address.
>
> So I'm thinking that we should declare ((addr & ~PAGE_MASK) != 0) to be
> a caller bug, and fix up this regrettably unidentified v4l driver?
I agree. This should be fixed in videobuf.
Hi sharma, what's your kernel version? It seems videobuf2 already
fixed this bug in 3.5.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-14 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 2:40 Bob Liu
2012-09-13 19:27 ` Andrew Morton
2012-09-14 9:23 ` Scott Jiang [this message]
2012-09-14 10:15 ` Bhupesh SHARMA
2012-09-14 10:39 ` Bhupesh SHARMA
2012-09-17 6:02 ` Scott Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHG8p1CJ7YizySrocYvQeCye4_63TkAimsAGU1KC5+Fn0wqF8w@mail.gmail.com \
--to=scott.jiang.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhupesh.sharma@st.com \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=stable@kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox