linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: 禹舟键 <ufo19890607@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
	hannes@cmpxchg.org, corbet@lwn.net,  cgroups@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: cgroup: correct the wrong information about measure of memory pressure
Date: Tue, 19 Feb 2019 18:45:52 +0800	[thread overview]
Message-ID: <CAHCio2g-S6snHsh84r0Wp1RQW1CR3t_eyUUjcdDaxnUHWTcdFw@mail.gmail.com> (raw)
In-Reply-To: <20190218210504.GT50184@devbig004.ftw2.facebook.com>

Hi TeJun
I've built the 5.0.0-rc6 kernel with psi option, but I cannot find any
cgroup.controllers when I mounted cgroup2.

[root@bogon /]# uname -r
[root@bogon /]# 5.0.0-rc6+
[root@bogon /]# mount -t cgroup2 none cgroup2/
[root@bogon /]# cat cgroup2/cgroup.controllers
[root@bogon /]
[root@bogon /]# cat cgroup2/cgroup.subtree_control
[root@bogon /]#

What's wrong with this kernel? Or maybe I lost some mount option?

Thanks
Yuzhoujian

Tejun Heo <tj@kernel.org> 于2019年2月19日周二 上午10:32写道:
>
> On Sat, Feb 16, 2019 at 08:56:04AM +0800, Yang Shi wrote:
> > Since PSI has implemented some kind of measure of memory pressure, the
> > statement about lack of such measure is not true anymore.
> >
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> > ---
> >  Documentation/admin-guide/cgroup-v2.rst | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> > index 7bf3f12..9a92013 100644
> > --- a/Documentation/admin-guide/cgroup-v2.rst
> > +++ b/Documentation/admin-guide/cgroup-v2.rst
> > @@ -1310,8 +1310,7 @@ network to a file can use all available memory but can also operate as
> >  performant with a small amount of memory.  A measure of memory
> >  pressure - how much the workload is being impacted due to lack of
> >  memory - is necessary to determine whether a workload needs more
> > -memory; unfortunately, memory pressure monitoring mechanism isn't
> > -implemented yet.
> > +memory.
>
> Maybe refer to PSI?
>
> Thanks.
>
> --
> tejun


  reply	other threads:[~2019-02-19 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16  0:56 Yang Shi
2019-02-18 21:05 ` Tejun Heo
2019-02-19 10:45   ` 禹舟键 [this message]
2019-02-21 19:54     ` Yang Shi
2019-02-19 16:47   ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHCio2g-S6snHsh84r0Wp1RQW1CR3t_eyUUjcdDaxnUHWTcdFw@mail.gmail.com \
    --to=ufo19890607@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox