From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D8CCD379F for ; Tue, 3 Sep 2024 16:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9586D8D01A9; Tue, 3 Sep 2024 12:31:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 907EA8D018A; Tue, 3 Sep 2024 12:31:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75BB78D01A9; Tue, 3 Sep 2024 12:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5756A8D018A for ; Tue, 3 Sep 2024 12:31:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E76831C364D for ; Tue, 3 Sep 2024 16:31:54 +0000 (UTC) X-FDA: 82523968548.26.3CF4820 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf24.hostedemail.com (Postfix) with ESMTP id 1816518001A for ; Tue, 3 Sep 2024 16:31:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=MaV3XmCy; spf=pass (imf24.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725381038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cA4f6/Q14LkYipHi4xW5E3QoTzXbTWUwWtLbC9c1AmY=; b=dJlyq1rAZDtjtBYBXCwn8cc0piuX48Nb4zEKdrCKM9TOCXLNZqqH8/JBYgCYYA7/8pPSYy RqkIwFCevJ5oy1MQmV5TsI/94NsC+NcYnrRgPhhMhOZxvo+nWX3lC9IDI7XHSC+R3B0q1c rU8YaKnsDV1WBrq8+SSskAsQbSxYaR0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=MaV3XmCy; spf=pass (imf24.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725381038; a=rsa-sha256; cv=none; b=Tx3xt8D4gg4KBZOibGnrhUbUuJQ1tVeXZDdIsyFDk+Fyp3NC9yn2pPTsaJo3QK0cwMG+Gs m1V4Y6kBm1KvXaIuIodwnopD0Wr5LZMcTqfcRoXn4TvubirUp9hLnLimh/FiH1DGF7k1Lo iYi2G0EhgmTEp1Fbs4zV+C4gctYkb+E= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-e1a9f84699cso2685220276.3 for ; Tue, 03 Sep 2024 09:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1725381112; x=1725985912; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cA4f6/Q14LkYipHi4xW5E3QoTzXbTWUwWtLbC9c1AmY=; b=MaV3XmCyKssxBxJlr2L0EvnPxy/xxRQQ3JP8HKJyITvI4vEiSAaxLU/TJVZQhTCPvj rPn5d8YeOJxnGhjpxi04612JcdL6OmqMhXDpUPRvaSOhOJ9d+SkdJKswvpQkvvbev4ph sHRWLlygk6UaRqrAa8yHY/6jZzbEZdi6ERsGK7yBCGsVdJUF3edXohrOCnQWefv7raL9 zXZPM8jmPtWsQH7ZdovFb+/GNY0eo95kGe8JWaRy1vB9sm3lLz4nU6cJ3gTSz93XmqVI gkz3FiOzI9B/F6GyDQsdMC4n7T4/t1K08Ju62MPMlDcXYbjAtaKfIRfOPbEqA/yq3DJv Wh0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725381112; x=1725985912; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cA4f6/Q14LkYipHi4xW5E3QoTzXbTWUwWtLbC9c1AmY=; b=vc8XHFP6iLog2kSLKe5BtQF9QjijP/rxVOZJeCPwJLtk/vvOT0mBzNqu0rBBrHWNrj EHI5Crb5LekiNrOQnEqPSgScXGUk+xnlcEcg58s68Swq4BP3ms5kIIvZETzqXnyLgRdf 0xA6Du5JyPe5qaS9iCdOBas24wO73Vi5hoE1ceVQNgsx464tQfJcod/amKygXcqklARm z4pF7H+nGkqaBNT5dfafe9bRqDX14tXLrmCHzOlsnokm72NBGihODgjdACMxuvmkHCLU 7Z6sbY2nfZAkSk+RGYyJgb3vO6wx5ZQBzm2R3JdzCXWB6DnENv56+ySt7AsiR+Wm1nbY XsgA== X-Forwarded-Encrypted: i=1; AJvYcCVIxR/B1bJ9Mb8q/xb8tLSNsKWqxV372F5XYl7S14Nt5+UbVWwu92Dd5Yaps/enY29t6OyE902n2A==@kvack.org X-Gm-Message-State: AOJu0YwYlKSqJqnYXA5FBLCjU6BtDGcwQJe64DM4DO2/YXdFTZrI/RQ9 QgVWInpIApu3ztkmbmnF5CiX5ZTw6tf7qflH9rX7HNJylglYfKxKeM7d6ZYtd1qMClKMdpLP+Yt Ar4MX1m0tSar3eYLz209qz6vop8W+lxHsW5gU X-Google-Smtp-Source: AGHT+IHa/01qoE/GHcK9QfmQSjlJsmOjJNv/+Qv5fA4SkJmS+bKSV6Q2r3LgScHAw7u0DobQXFY/bSjBLHtbXnRken8= X-Received: by 2002:a05:690c:650f:b0:6c8:1e30:5136 with SMTP id 00721157ae682-6d40f14e2a3mr154433887b3.16.1725381111978; Tue, 03 Sep 2024 09:31:51 -0700 (PDT) MIME-Version: 1.0 References: <20240903033011.2870608-1-yukaixiong@huawei.com> <20240903033011.2870608-8-yukaixiong@huawei.com> In-Reply-To: <20240903033011.2870608-8-yukaixiong@huawei.com> From: Paul Moore Date: Tue, 3 Sep 2024 12:31:41 -0400 Message-ID: Subject: Re: [PATCH v2 -next 07/15] security: min_addr: move sysctl into its own file To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: wme397yh6s1pq8yfsk9o6se8fhu5k4ci X-Rspam-User: X-Rspamd-Queue-Id: 1816518001A X-Rspamd-Server: rspam02 X-HE-Tag: 1725381112-568492 X-HE-Meta: U2FsdGVkX18mFrMndXWaVKu07Hh6x5IR8cgGvVtjxoC8F3mbcN95Zs6pQj7klA/S+3hKZ7ceRkMXExQhq+dDRxQJ1rWi/r+c6jrLXxQ8RA04B9X5cCKejJuwhzGegTnZmBcG/sYL21dZtqRHbIgkzkKaY8X4djI3mpz4NqztVZ59BliPgHyksL0BXXhW3/xTBupwt0bxHHIV5MJaEW0Z50H5VGjJ0DoOPdpMz49HvQoK2hAh3QIly5OtepgdukpyWZEppqyPUqYgQVcroyJfPDCJa60rMQfj7dSUgOzF3rCdbOjfwkY/njGa9Q6OdAdIEKPfPlt9G7xJIlV5zO7LfgFYHonuDys4c2JmS59F3z5xDPb+SJwByh27maAYKh4IGoYg+GpyhHXrpwZyjJ9077xF9M/XaJLoXXvwWUkeDTfHpNEYy/14Gger3QTFkVeebbi+pMYEBMFKyxZcWFEA5nilRqqBUU7DQPsruM7Av9S1vHb+p3n8YR8A4g9iS7wEFOOROeU9+DBzJHDevd41UJHDf665t5K+AK9vFgGabXxOZObjgfsDgb1bUSWrxgJF4SFosJ+jI6uiJmoT2nKynS3kkOwLv2sCfnaeRVtfJX9P6SQXeTaqhXHgfklaq0V7rcyTSgZFSTrMO9jGXEHQSYmsskek1ydD49+AS4NP/dkavDzvbxhoXvv6xot3HS+K/U9IGQJoS7gn5uZPqKsE2Gu0+18ons2p6mJ7iPD2Nsw9OYch688fQohSXpQH6cPQ/jcezyWxtXG+A0zO59OT19QZzLcsbML70rltKHPNKQgXFe3HrpGolYuvw90s2HZi7bGNn/9dQtLhNP5A8XF45Fk1jXCPpNlWTVRIQnQH1VKCofiKCc+15nM5j3BsWIb6JOblg/3gJrz8m3bVuvfJag/8fHexfwkLGIW5RrZawidI1IDxQos5HU3PkxAew3yUUYb6NYsgdMWYzy1wCuk 0gGiN608 FdkqKfJHNxV6IRCf4/QC7AGwIp5sZAhPn3P5H/mB5V1nNcc7XO+fM1KWtmJxu46cn02XXFiZnYGV3cr5pazTdmQpqKGaTw1+NK+zRA5bUaeQfIODVF+8QMCu5kseG7x1a+H+kJqMpyzuiv6TMN/9SVNybodpYzN5fwD5Am7e9oAlTFWHpE6ZX+/VRp6JutZ4Ft2PzU1Nx2tOuC4XidUzgS6k+tN9p8aEw5Nv24Nr9d3KCmfRH86rpIqF7cPbwf/gcDj9Jc1yyWXe7plBLUpgGWB5yv7WfCxwaFIuH6kl5MIaxRfz43Z3UaDAUFPYDeAMnN1EYR5qlbzWmC682P49lt1pkmg82ttXWIUGxcdpx7resl6M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 2, 2024 at 11:31=E2=80=AFPM Kaixiong Yu = wrote: > > The dac_mmap_min_addr belongs to min_addr.c, move it into > its own file from /kernel/sysctl.c. In the previous Linux kernel > boot process, sysctl_init_bases needs to be executed before > init_mmap_min_addr, So, register_sysctl_init should be executed > before update_mmap_min_addr in init_mmap_min_addr. And according > to the compilation condition in security/Makefile: > > obj-$(CONFIG_MMU) +=3D min_addr.o > > if CONFIG_MMU is not defined, min_addr.c would not be included in the > compilation process. So, drop the CONFIG_MMU check. > > Signed-off-by: Kaixiong Yu > Reviewed-by: Kees Cook > --- > v2: > - update the changelog to explain why drop CONFIG_MMU check. > --- > kernel/sysctl.c | 9 --------- > security/min_addr.c | 11 +++++++++++ > 2 files changed, 11 insertions(+), 9 deletions(-) Acked-by: Paul Moore --=20 paul-moore.com