From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDACCF854E for ; Thu, 3 Oct 2024 01:32:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 509C36B04CE; Wed, 2 Oct 2024 21:32:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B96A6B04CF; Wed, 2 Oct 2024 21:32:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332AF6B04E6; Wed, 2 Oct 2024 21:32:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0A61B6B04CE for ; Wed, 2 Oct 2024 21:32:33 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 769781C683C for ; Thu, 3 Oct 2024 01:32:33 +0000 (UTC) X-FDA: 82630566186.01.46844B8 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf01.hostedemail.com (Postfix) with ESMTP id 92EC24000B for ; Thu, 3 Oct 2024 01:32:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=OPHR5uA0; spf=pass (imf01.hostedemail.com: domain of paul@paul-moore.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727919023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1UwXK1FoaoO9CGRgZEvqR8WstJfC7qHQR30H1C7tXkc=; b=5o+o+XlEiNhcB3nC/TY98YtGWYCUvHym46S9QlBTERploa+jzJ0ax5vCY635uNFUH6Fi3Q JfZfQImtT1Q1WXudVcVGbBTA9/Uqep/BC+uHZcLVD2drk4qEAr+gvclgTA7DA3C4drp6Uz 1iPCeyyl1wF1K31swZ4RGW43MwuXnkE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727919023; a=rsa-sha256; cv=none; b=LU/0A+HTT1mIW+YI+GohYurjPiH8CuUWS8sZx1ajYgtQb3Q2Bidqb3DdEKK54LHqc7rj6D B8CxzfNjJ2hTjA3De0+LF4l0cN3F+eUBbKW+f1hzqlcNVu8aOQd1V2vHWxiExsypicsZGY 32X67yCKaVV4/oB7JEwL04oXkpS97pA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=OPHR5uA0; spf=pass (imf01.hostedemail.com: domain of paul@paul-moore.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6e21b4d7236so3643327b3.2 for ; Wed, 02 Oct 2024 18:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1727919150; x=1728523950; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1UwXK1FoaoO9CGRgZEvqR8WstJfC7qHQR30H1C7tXkc=; b=OPHR5uA0z0M05OTKTx2/cFOnK0jJqLsgOUxs8kAHVVZnzLtm6Bedy36Zl43eYeqrr6 Ai13JizwT9d9mO9lJ+3kl0mV1v8RLw4SZg1vCjCYoffUk1jH8HAC5otUTgdkSUUPeN9e G2ftHMli5r78bbuq5Wi+62KY2dM4rrpNrjPklXcXoOXLHpkxhMbApzSFlDD9QbswBwGG sjmKVlNcrNkmh2SpeXwC8u1oQYTrNmJVNgWWCNyMu6AsF+Xb6HE62NDDbM4bkP1IcJ8T 5rmyRjUNG7fwW8Iotete8o2M4PXBW1PpmziqfwEqjCfCkrA8auHv1Te1gYoTlUkZnR6h 2zeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727919150; x=1728523950; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1UwXK1FoaoO9CGRgZEvqR8WstJfC7qHQR30H1C7tXkc=; b=R/JxIpttkv0+dfa7RJTotLPf6T+jtfWAJ49mnji23+i1LdfhXSMDPAmp672XaDqwSn 0FmNZTaQm0622ueDF5F8JDCyO1Y2qgzEWkiE+foTS5/THIizEaTgV93A0b1jkWtj8QGV TpLrQ4k7ZoFf3On9rv5kb7RVJqaCVtVOwSYCKluA6SWDqjbwtl3WISH1XO5daaCYhwEn q2ltMqHIYJ8olyuS59KYNVBnhgyMzm8nnL0JmL3pepitKuD4cvaSkZQsDTzTsn7QyaRM /Y3dunNA78H5BKpBIl/NG4ms9zs8BTXMnHm57ExdcqhxMVaeC+TQHSnpS5y0n9gRw0cD Uorw== X-Forwarded-Encrypted: i=1; AJvYcCUjU3t8MvMOV4AvNJNVDT5uB6K2H11/vZWfY5YJqE4IyB1cW+lmEiOr76YAg2m9hyeQK4xxAgktTA==@kvack.org X-Gm-Message-State: AOJu0Yw/p7Cj+98SPsc9km5JjTa0DChIzVHiZUCCxseL5U8qUHf8IGew 950x4Z2NRIjmExAtnHB2aC7a1Q6yLY6jpx71QM8O5CGtTdEEKX9apckFlyxh1VoCiVJxvsh294t 8WmGnPKDpxNqvdh11PqDmXl2Bs48XUXNZ2l4c X-Google-Smtp-Source: AGHT+IETgnQD+Fykl9pMHACUWHaELEzbCGd7C2GoUuQae4g5nBX1YxBIfvZyaeMKpOabEmP4hEMEj+B8qq4LTRqQDE8= X-Received: by 2002:a05:690c:660f:b0:6e2:12e5:35b4 with SMTP id 00721157ae682-6e2a297bfd5mr57387637b3.0.1727919150409; Wed, 02 Oct 2024 18:32:30 -0700 (PDT) MIME-Version: 1.0 References: <66f8846e.050a0220.aab67.000b.GAE@google.com> <66fcd082.050a0220.f28ec.04f1.GAE@google.com> In-Reply-To: From: Paul Moore Date: Wed, 2 Oct 2024 21:32:19 -0400 Message-ID: Subject: Re: [syzbot] [mm?] possible deadlock in upgrade_mmap_lock_carefully To: Shu Han Cc: syzbot , akpm@linux-foundation.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stephen.smalley.work@gmail.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 92EC24000B X-Stat-Signature: 1bgiaza4dyyygdixdijif1miwzn7dm86 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727919151-231819 X-HE-Meta: U2FsdGVkX1/RExU/Xtq3gIOrBGcbXoVW4rCXFpf6nywu0yFFF3Mb67Aljj4Hq3dnxOs1/88yRA1PdDDT3N/+TMLFqhKFx0aIAmEJ8s7MBqtzXg2bmu7mc7gEuZfnHszg7j5LPz+NuGd0T4J0n3MIQhoqEemyszp6y88gx4sZc472ow8H5gvNM2pU2b2BCNq5U9xbngBHS4rJK6N2viIcwtRj+OXpXMAUwFQjCXPEs3fCuYIbRYC6qfeIfQjURv00I8C3srPrVwd3wkAAHt1b5r3g2N0IrDp6URGnWyTBbnpZheMvsEafvkvoukZ+1CzlTfDWzvkPvmbHlIZe7Wg5bd0rBbWuN2HOl/zWEHChZE324ON3XEqPvUP5W0MPGIEVUSBpL8Yoscp9dFmdBJbO5Yf29lM8IdVycIW+t+dInKgi5phdl0EXih1enn/vfDmowFpp03eLrOeOZS4LeIegq+4qr6BSctCdqM8OBcTApf4kcbOakVw9D1321sMR20VNwKIfm8hFRZTaDeo2O5+zE2v4f18w/Lk+APKrNla5hUi5kwThtKOr4MfDu1bVGs99a85huo1eCAC+omVLPDb2Plz6xemcMRGdwduExdgAFago6ifXsmxGVf8qJv0oyV3TN5gXu29tW4/uYt8K7bj2senqccpiSebCvMbhpjxpTQxZgq4A+RZK0UGDrzZsXbia/IRGuaQSWGIYccwz5Z0UqPHsC8EDcK522ANDbqXlk3rgBu/R9i0GxlZfOeQldsQEWrpHRALrEiustASQIcYM7q0k9a9AkTRGblShehe4tS6eRqVrpm63ZvZXMHQKP6YmiCWI+2P/I33Z3zqkv+wf9vvS5XaUTMrqcxVZm7kn5PuqfyDaygxYJFgiVv1X6LprMwPLAVxLJhLZwhNk6UUcN46RGnLIRs11fWmPW+GJldwQXB50bav9nD6vWM5zxryKuF7UTmievw8ctcROeTx SR3fp7cT SXXVv1nMaVjP826Wx4Gn04/9kABjWbNVpst26Uw3a5akTzOorMi/8vN501aDqv/idtSjbduz7gXWoiGR/8NKcDGnEZIXtKv7BhHnK0oH5PwHGWCe4bCrv//faIT45ih7tHbqWF0GhJjSk9TQ7azkklfU+pTe3jJz8AlsiXxPlO7yj/2pt4uV7i2H/JRDMsxwclOhP0CB07pNJzgcR+Cic0QoyQTZX0eKIAFMkO6TurT3UIctR2pCaL1B1LF5qz/eXARsHG+X3vuPzO5lwkbSdLVvma5bU1c793aGiGhex+YZHmcbpGlTZJQ4ms5wYoI+5SGTOJvQeWOl2QlIxd9AhjWNE5rNlNIGI1hcd3tQUOzHlfK3YltgmS8zgpbXZczArMYQ4fWLvYBfUO4bv3unFWgPaCqERc7qca/jJNuoAkGx/SOtZdTIF2x547nBZ9gCPMMlKkfqdC/UMMaWW3Pjc7m1k/ACxFDoa0kTlYBqtJp1k9smbga2GLDqP1b2Rd62WKuN/bwJ7Z+XB/95N/fx1K/+xNAX+6FPbHNari1o3Kk/Bdv0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000736, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 2, 2024 at 8:14=E2=80=AFAM Shu Han = wrote: > > It seems to be the same as [1]. > New LSM hook position for remap_file_pages + IMA =3D deadlock. > The new LSM hook position is added for a bypass caused by > no check in remap_file_pages + READ_IMPLIES_EXEC in do_mmap. Thanks Shu Han, let's mark this as a dup and sort out a fix in the first re= port. #syz dup: [syzbot] [integrity?] [lsm?] possible deadlock in process_measurement (4) > I suggest fix it by removing the check and moving READ_IMPLIES_EXEC > out of do_mmap[2]. > > Link: https://lore.kernel.org/lkml/20240928065620.7abadb2d8552f03d785c77c= 9@linux-foundation.org/ > [1] > Link: https://lore.kernel.org/all/20240928180044.50-1-ebpqwerty472123@gma= il.com/ > [2] --=20 paul-moore.com