From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3027C5321D for ; Mon, 26 Aug 2024 22:49:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55A1E6B00A1; Mon, 26 Aug 2024 18:49:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3176B00A3; Mon, 26 Aug 2024 18:49:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 383BF6B00A5; Mon, 26 Aug 2024 18:49:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1A4C26B00A1 for ; Mon, 26 Aug 2024 18:49:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8E7AF121467 for ; Mon, 26 Aug 2024 22:49:31 +0000 (UTC) X-FDA: 82495889742.28.3640DF0 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf13.hostedemail.com (Postfix) with ESMTP id B9F7F2000F for ; Mon, 26 Aug 2024 22:49:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=XhsrSMpv; spf=pass (imf13.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724712455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nWTFl5f8OPZ9kYIvj+M7W9eYYEXfjlTCvvmN9eeNnFM=; b=GgBLPlNQg/nzZQi2M4/bdE3DzM0wq/mr1vFclDpLit7x+N49Ejobw/q/SVFoPdEw/xI7a8 opKj/WJPAnobhl+CrnfNwWAvUagNcWGljXyUCD+/EijRkmPpZtY2TzH5ytJzH++NDPZU3D OGQ4G2wqGavM1RNxfggPps7BFVEeEPQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=XhsrSMpv; spf=pass (imf13.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724712455; a=rsa-sha256; cv=none; b=jd04vZpV71CvRFF7JilU8HHW1GIhmwmD/fe08jGZA9+GnObZ7jzTOJVU7G+d9XtKIG2rLt zrxEnBZfiCtM10dUsh+3fJPukF7Sv9E2XMbQ4fkt5pMFLtYH5soBF5a/KJS4V/pjgmwfSX TcXZa2bn1oIkCIxDD+/esl7rSJOX7tE= Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-e116d2f5f7fso4336604276.1 for ; Mon, 26 Aug 2024 15:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1724712569; x=1725317369; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nWTFl5f8OPZ9kYIvj+M7W9eYYEXfjlTCvvmN9eeNnFM=; b=XhsrSMpvLVYULMcxWWQlo1dJpARf33MSGHqgvArZS0mQFfhakO4SS5uTwzaaubU/+2 04LFRq7Ki4l+KfETq+tk2oTOtXHDSbsfKN7ha4ViT6R/LAHKxQWxPiZxluNKnkXxj91N 7DCyHrUsMLIXFyxvy4PmFjArBtGbnaFH3jU8+o+QrUaNZHCn76ys6awBf2ua3utwuP9F LQcGc8kV7V6I9iEPM9mVWHfqFpMOpklaptFB59zh+3Iwgidh6E5TdVLGpUf/OsfMn2KW AcHxp1mRnwHyokxyhFuLoaBSJ4aqCSFcOWCcYv276oePel1a5w++sEb9BZIe49RthqLs DbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724712569; x=1725317369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nWTFl5f8OPZ9kYIvj+M7W9eYYEXfjlTCvvmN9eeNnFM=; b=jFnzTwoUfQsTw4PkZQwKCZuD8qYPR6R76UT230xnUc6+3yu+zwSgvfRUXqP5O5z0zK ZJTcj8irMQERwM8mluqYROxlelrv0kVv2lPr+EoHoOvwy8CSsXn4WvXtocs1zludBoZ6 a69p3dvQrXhqTCw+ZMFNQLz5xhiRxBRJWL3R5Y2oyzH+a/K6ANlg7amw0QPprhJ9dwPT ZMFXRciPhLkswhCpqYTln4xlJqunS2OkFwds0xuluqU5FP6T1+eUws2Gw5ar4bFNbQxH 000hOuGEcxoOO4yRR8dfmCLgkQ8WMRwNrirCd7JkqCMG2jNt4Rtiy6PYUS3OHSyMlf5Z wV9Q== X-Forwarded-Encrypted: i=1; AJvYcCXLO91I6WamdMlU7/tZsDSrHg+OrQ5Ws2biqRceW39EuT+pR/ColmZddKqK+SIIkglAf8OQUwYDdQ==@kvack.org X-Gm-Message-State: AOJu0YwsUQ8+J93HBgesZqzFJSdwXmi0r1EYmixpRXsUYFeL9gKASpqi RqWOkgxmmKu9Y0NeGBl9Lj5+5DbFPv4A7bTfPNlhp+vRWIvj12ajr3qPQdGwAxpM7ZJWiLw/aL3 EgpAiV5xjfdrS8JkETtUAdpu7ywV21BQKY+Pi X-Google-Smtp-Source: AGHT+IFdXwGDNkQJWX/aeiki5niUl6YsOZL7hcKl1t9UskkQFhTdxuBmqzMkoxujlay9La0l7/VeNVTc31ug5dspjrg= X-Received: by 2002:a05:6902:1283:b0:e08:6373:dfc8 with SMTP id 3f1490d57ef6-e1a2984666bmr1176664276.23.1724712568754; Mon, 26 Aug 2024 15:49:28 -0700 (PDT) MIME-Version: 1.0 References: <20240826120449.1666461-1-yukaixiong@huawei.com> <20240826120449.1666461-8-yukaixiong@huawei.com> In-Reply-To: <20240826120449.1666461-8-yukaixiong@huawei.com> From: Paul Moore Date: Mon, 26 Aug 2024 18:49:17 -0400 Message-ID: Subject: Re: [PATCH -next 07/15] security: min_addr: move sysctl into its own file To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B9F7F2000F X-Stat-Signature: fnuhhk4wb356igb7etd6gj7p6bznw8a1 X-Rspam-User: X-HE-Tag: 1724712569-278436 X-HE-Meta: U2FsdGVkX1/Qy85kryrhLyTW0k65UkwR9PX5Aox3vYCu6F8UpAYnT+VL6GzFdV8Fl5sPbyBS3iaVK+qCE+u2tpf7f29vXlGrHV1hBjaF0pQLHhaEy5cj2zxw3U/lS7D+fHFO4+SP1DVNEhV5engtq7OVDpaQVnDjB+KuD4F6v4ZpeEELdWG6IMbk6AprcZ1qJFBlvapTuxF+Qd56Ie1MiMk6qFMDnRg3v2EuCarfWY/z7r4HA/iOml2T9d7okxbuuunaT6B+Z5aCw9tXjG0l/bfjxtfdZEJcrWAL+/EebomJoJfLz6CRj1BY+BMK/p7kAYYrIFdsZ1vCQXJ4t9SOm0owZ+10FycIPAAYSj5+OPq6D079BQ01KsH/5VB2ylEmMAnA+GyBqJJqSof8Vl8ydGodjLq6aMJJDeuDCZLyAXcxIrENUd4ATftHPMKyPt6blGqFv/fjrHgbU2gQp/ISvnwr8CYPsBVER39wrq8fwR9UTt1JvB8axGYTFhjEMj3QMrstl3zkEfyw8c9HglmCc/th/A7xeW/LX3QW+4pM0b+7HHw8WQYUsChVD9dKviLXZYlSBnk8cQzj1iPt9ES8HPLQHDT72K6KLzZc21KmRFgXo2k8hZiyZhc8c8p99am7/epQ6kVVhtrcMdZCTldYlhpZA4Gadq1PQYd6HrBsv1O52DJMv3WZgcbDMhfetERqkGGuVanphgnsfSKmfC3sCPrtwTAGQNM8XUG6pY/kVzsPKGzkAba+JayqHdOgIVKD8dLKvKW9crOhM21kXSErr9vkMPXbwv1BPK4lpI2rpwlr1M5E3bcwTWLfhAdU4xgn68tKzRjMk3/Mwfma24Z39n1beO9ZUNZLeb59Y5IBzPb4G0ixy5vJu1XjtimBM9OEWN3TCDfJhIfHtCAoseeokPMmO3VZI+piUqPt8R4+x/GtkkRBkjf9MTz5zLj+00JTT6OkikWb6iM08+Rjam9 wOs91q8i /Ha504VvfTNXZ3NZc1ELy+lPVFSU/zDCRe7sO8JOBYZpFjLxiUl21chXjUR3YQZ9akZ0g0CRGuX+KtT4KJ3BrLNeduGU36zzdPXfy/Qr2DszwRjVXFnLhZV1oM5ZzK9iEKzIdMu1o0U2L1WJMqvl+hGF6PB6zML87h7cgarSphVEqzbpKhS4Ug9ewhNnh/QgLufRdfah9b2P8p3orqBPXOGkeGfH76LSBhOkBakJPSEt3HnheuiqmfipdWrPlGMnCJ2GRZE4alb9q+WIN6hfZwgHAckRyAs99E4yDNfbiylR8bMeQnCPG7rdu0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 8:05=E2=80=AFAM Kaixiong Yu = wrote: > > The dac_mmap_min_addr belongs to min_addr.c, move it into > its own file from /kernel/sysctl.c. In the previous Linux kernel > boot process, sysctl_init_bases needs to be executed before > init_mmap_min_addr, So, register_sysctl_init should be executed > before update_mmap_min_addr in init_mmap_min_addr. > > Signed-off-by: Kaixiong Yu > --- > kernel/sysctl.c | 9 --------- > security/min_addr.c | 11 +++++++++++ > 2 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 41d4afc978e6..0c0bab3dad7d 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2059,15 +2059,6 @@ static struct ctl_table vm_table[] =3D { > .proc_handler =3D proc_dointvec_minmax, > .extra1 =3D SYSCTL_ZERO, > }, > -#ifdef CONFIG_MMU > - { > - .procname =3D "mmap_min_addr", > - .data =3D &dac_mmap_min_addr, > - .maxlen =3D sizeof(unsigned long), > - .mode =3D 0644, > - .proc_handler =3D mmap_min_addr_handler, > - }, > -#endif > #if (defined(CONFIG_X86_32) && !defined(CONFIG_UML))|| \ > (defined(CONFIG_SUPERH) && defined(CONFIG_VSYSCALL)) > { > diff --git a/security/min_addr.c b/security/min_addr.c > index 0ce267c041ab..b2f61649e110 100644 > --- a/security/min_addr.c > +++ b/security/min_addr.c > @@ -44,8 +44,19 @@ int mmap_min_addr_handler(const struct ctl_table *tabl= e, int write, > return ret; > } > > +static struct ctl_table min_addr_sysctl_table[] =3D { > + { > + .procname =3D "mmap_min_addr", > + .data =3D &dac_mmap_min_addr, > + .maxlen =3D sizeof(unsigned long), > + .mode =3D 0644, > + .proc_handler =3D mmap_min_addr_handler, > + }, > +}; I haven't chased all of the Kconfig deps to see if there is a problem, but please provide a quick explanation in the commit description about why it is okay to drop the CONFIG_MMU check. > static int __init init_mmap_min_addr(void) > { > + register_sysctl_init("vm", min_addr_sysctl_table); > update_mmap_min_addr(); > > return 0; > -- > 2.25.1 --=20 paul-moore.com