From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B03C5321D for ; Tue, 27 Aug 2024 01:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB8A06B0089; Mon, 26 Aug 2024 21:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B68E16B008A; Mon, 26 Aug 2024 21:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A098C6B008C; Mon, 26 Aug 2024 21:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7DEEF6B0089 for ; Mon, 26 Aug 2024 21:56:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2672A1A152C for ; Tue, 27 Aug 2024 01:56:43 +0000 (UTC) X-FDA: 82496361486.18.57C4BBE Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 5787EC0008 for ; Tue, 27 Aug 2024 01:56:41 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=dc1rVsZr; spf=pass (imf22.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724723757; a=rsa-sha256; cv=none; b=HwvXPfj+Jr0J4+hQUDUcGRedjIm+FaOZvqFi5w4r4xzuRe5hEM/MfZ1oqZ7Sxu6/gJJo0t 4TWIvM+dLppD5xkZyCas0VMsaIYAryoLTMnOdAw4k8ErqdIpbEWC0pVANAPGXRXNbZ12dg SjqIQGxkrAuE6GA3Re9447XbB0oV0DY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=dc1rVsZr; spf=pass (imf22.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724723757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZHkpf2eW9vtVI3uQimkDc6XD8VPV3xIbNHiNaLloE6M=; b=CGTYUbG77464pgiu+VmlHBL2lMJF9+YdGfc7bth1WvNiMVFneemWUn184zHiy3e88PCt9B XrRdHAGm+4OtifyyW5OX/8HJAVjhqjjuaObD+l9kq95KYNhliHPmQaefQOu9L85fa/wfXc Srtl+rOUqzSrsvTtYlCIhCjlRQgZvBc= Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-e0b7efa1c1bso4952062276.3 for ; Mon, 26 Aug 2024 18:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1724723800; x=1725328600; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZHkpf2eW9vtVI3uQimkDc6XD8VPV3xIbNHiNaLloE6M=; b=dc1rVsZraO8Nr79bRJJeo9yJ6MuazbZV51EFU7dXGwocwtCXbzhjbR1GDYt4Zm+4g1 MKnh+s/R7c7VwGUaJWwoqKWgGeSH47xzGYxPr0MMqXQQxAUL7WxFOdI4mXS82DPBW3/W SaMfBHQcl+thS0FEp40JjY5M+32Jc3ZVkznDuBn6BKFFt6Eqde5VB7UnUr5jKKRh5gEs hojgpOWi7q9sPDGy415iY3m7Dypkf4xIQJmtXgPa20IE6tHSaAt7150pNtVptVZ3mCEX c2eD2FOc8M4y+z848z+rVMzUz9rNn0f+Hz88noge8FxBxVXqVSwDIigFpYWkPXzMEV40 hAkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724723800; x=1725328600; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZHkpf2eW9vtVI3uQimkDc6XD8VPV3xIbNHiNaLloE6M=; b=nUSAYo8e6mJ4UoNORtJuqeZHswNFWqfGqLgQWIdRarmCwrCIxZN9vnW1xWMhO9h0Ft T8McW/SGLP9+ALlAnwYlJ3TujwEe2szRNvj46CDIZvWwgUbDowkSycxWePduilWrBFO1 VYM/1b0jleY2OofjYUMuw+YaWRK694tXJRU2PY6cU8nznEdnPlJaD/NRFouck0HNytv9 lyb1VXC1DqRVxvRbpy/kEx8HcDRWnr21Hpba8S8F5ETUUOYkA0BBDAER/IV1z23DUSej r56tmSbaD5PTxbzJ1oH1BrFAaVW9KOme4xHAXM5mwwJ0aKHFKtJ0It87W/gF/oRrB0uI vuiA== X-Forwarded-Encrypted: i=1; AJvYcCVRsEkhc2jbz2jlxvN7ZmneSMI9dlYGcpSthqygwCsGqrwrI1x1mtRDFBrPsg5J6ibh36GXGOrOpQ==@kvack.org X-Gm-Message-State: AOJu0YxsKCu77lTf16zmHOEsDoianMg7iA7rxbJvIea4NIajHB84hWLf so30D/C3Myk5RLgu0zpEQ25IhuelIEj4IZsEN/crJrNUdwcIxMKjx/Wh5nN/shYebtiM5IOqnjl Eaeocw+nmCSkMbRMijRi6rZa5tBHO4QlKIJoJ X-Google-Smtp-Source: AGHT+IGAlsSd5u0kuXsprdwgpBWXtwruGr5DEyvE3wl7DuUl9p6ZRcHG5g6fvYorBxc3UuC0PA06wNMuggPIcc4VLCo= X-Received: by 2002:a05:690c:760a:b0:6b1:2825:a3e2 with SMTP id 00721157ae682-6c629159d06mr130236787b3.44.1724723800391; Mon, 26 Aug 2024 18:56:40 -0700 (PDT) MIME-Version: 1.0 References: <20240826120449.1666461-1-yukaixiong@huawei.com> <20240826120449.1666461-8-yukaixiong@huawei.com> In-Reply-To: From: Paul Moore Date: Mon, 26 Aug 2024 21:56:29 -0400 Message-ID: Subject: Re: [PATCH -next 07/15] security: min_addr: move sysctl into its own file To: yukaixiong Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 316cwu6pyf4b5rp9p6jrcnimu1hf1bp3 X-Rspamd-Queue-Id: 5787EC0008 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724723801-986204 X-HE-Meta: U2FsdGVkX18PEWQOJVhyzGRshyvSpZdGse4UfY4QD8TGXcbfNTAPnZaRsDlG44HunBhljKfZzoFca/4Qt9Dl5OlSHd6uNHK2TwAkE0B5eoYCK77FPuIWqum4MuqoMilFiYAJ4GZSjzAZlw5HSYqIQzZytmaycHSohGvn6RBDQ9XHubZl8ZwoRAesBm/E3AHrkWyCHCZJsIiq9slw0NHHEHflGNnuMuxw5Gj8v2h/YMwiXKa8j64Jk/96kScmr42VDn779pm+XL5HCw3EY64iQODl6AAFJPonTSTiFyTP89zHYMM2I29Hs/3n/v7wzETmB/0dzj9y/juF6/TeC91ONlXfW9D/uSZaimfkp5XTvF6/crzXbJLdWFh5qULTh6fiI8GW/+yRkb3ZwkexrfBGHyjvNl85/efr3wrn9ZtiL6kh9ibr5VXFZhmajSi6VKvhxNeFijEyh5bwftYYNv9pMvfUc+mwNKqt57AWd40NUCC3fl+HuWR4uXrVkbVUaUkfX1Fqub/xd+m0AsvuTltHgR/trh6edpFCPh53FN3rfg2TBtNNoQeIFkX61rX4Bs7jGyy1tY1HQQ98Xcqgo4NrQnZ+PxfItWdka88zPKo7JYxnsKMZx+RVNgbpAby1aQjkQtKeCe62BG2/kzEmUy12dGgPnHmMsWcdLHYzETaF2l/3VXdcMxGAlGSeF/EMmZu6lcD9m7k9N9dO0lDdCLg4rTpvz65PYnHSn/g8Y5+OgA5xi68/tQvP7ZkDXsjuEtsjMBHIG2eo2ULNqamzoT55c8oTZV/BF5UiX5Rp1C7mis9OZ6KocxgUPCZF/pzoURjZZoZK2uy74Ve3Tx2urmaLR4oWDuuvkRTzbYXicMrWC2RSt6T6sby8LVxGPRkX6IgrptRNAo5FQ2GiLNb4D+zu2WngDWqog9NaxykDakplIoBuxOaOFMhC+hh5K8BXILIKzssIYYGCm1FgL+HqYvy 62SWFAjO YiV12GRHhMsFE4pMuJmpz3wiOeS5N51mecazNBCTWtph9p/ejKKLJAmgAKwAXoKRjwuz4dAixrd0kaFRIG5wfuPv/bLILNJqBEe8InvRxg/5V7wYO7LLAAHOwmCb0JZxDhx9agyvnkFLCwLSEdpOCDvI3cTww2qHkAe5X3aWSF9ahBLmxMdQzi5039s7BZQJ9CqHaRy4wiWvlvw0ENaW7K5dDHwXCDC3eQGkXuCBF8YdCGEKq3+uXM60BTyY8sFCyr49fR805/dYzkm8+3bGhdhKQ7YCaGavm/BGXKqBOopUE/cyQhXJzy3YWfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 9:38=E2=80=AFPM yukaixiong = wrote: > On 2024/8/27 6:49, Paul Moore wrote: > > On Mon, Aug 26, 2024 at 8:05=E2=80=AFAM Kaixiong Yu wrote: > >> The dac_mmap_min_addr belongs to min_addr.c, move it into > >> its own file from /kernel/sysctl.c. In the previous Linux kernel > >> boot process, sysctl_init_bases needs to be executed before > >> init_mmap_min_addr, So, register_sysctl_init should be executed > >> before update_mmap_min_addr in init_mmap_min_addr. > >> > >> Signed-off-by: Kaixiong Yu > >> --- > >> kernel/sysctl.c | 9 --------- > >> security/min_addr.c | 11 +++++++++++ > >> 2 files changed, 11 insertions(+), 9 deletions(-) > >> > >> diff --git a/kernel/sysctl.c b/kernel/sysctl.c > >> index 41d4afc978e6..0c0bab3dad7d 100644 > >> --- a/kernel/sysctl.c > >> +++ b/kernel/sysctl.c > >> @@ -2059,15 +2059,6 @@ static struct ctl_table vm_table[] =3D { > >> .proc_handler =3D proc_dointvec_minmax, > >> .extra1 =3D SYSCTL_ZERO, > >> }, > >> -#ifdef CONFIG_MMU > >> - { > >> - .procname =3D "mmap_min_addr", > >> - .data =3D &dac_mmap_min_addr, > >> - .maxlen =3D sizeof(unsigned long), > >> - .mode =3D 0644, > >> - .proc_handler =3D mmap_min_addr_handler, > >> - }, > >> -#endif > >> #if (defined(CONFIG_X86_32) && !defined(CONFIG_UML))|| \ > >> (defined(CONFIG_SUPERH) && defined(CONFIG_VSYSCALL)) > >> { > >> diff --git a/security/min_addr.c b/security/min_addr.c > >> index 0ce267c041ab..b2f61649e110 100644 > >> --- a/security/min_addr.c > >> +++ b/security/min_addr.c > >> @@ -44,8 +44,19 @@ int mmap_min_addr_handler(const struct ctl_table *t= able, int write, > >> return ret; > >> } > >> > >> +static struct ctl_table min_addr_sysctl_table[] =3D { > >> + { > >> + .procname =3D "mmap_min_addr", > >> + .data =3D &dac_mmap_min_addr, > >> + .maxlen =3D sizeof(unsigned long), > >> + .mode =3D 0644, > >> + .proc_handler =3D mmap_min_addr_handler, > >> + }, > >> +}; > > > > I haven't chased all of the Kconfig deps to see if there is a problem, > > but please provide a quick explanation in the commit description about > > why it is okay to drop the CONFIG_MMU check. > > According to the compilation condition in security/Makefile: > > obj-$(CONFIG_MMU) +=3D min_addr.o > > if CONFIG_MMU is not defined, min_addr.c would not be included in the > compilation process. > So=EF=BC=8Cit is okay to drop the CONFIG_MMU check. Great, please add some text about that in the commit description as it is an important difference in the code changes that isn't currently documented in the patch. --=20 paul-moore.com