From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1544DD2CDFD for ; Tue, 22 Oct 2024 16:27:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F12A6B0083; Tue, 22 Oct 2024 12:27:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1876B0085; Tue, 22 Oct 2024 12:27:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 469BF6B0088; Tue, 22 Oct 2024 12:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 27E916B0083 for ; Tue, 22 Oct 2024 12:27:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E6EEB1202C0 for ; Tue, 22 Oct 2024 16:27:19 +0000 (UTC) X-FDA: 82701768534.11.4870E80 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf15.hostedemail.com (Postfix) with ESMTP id B59DAA0030 for ; Tue, 22 Oct 2024 16:27:16 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b="TPJDLz/T"; spf=pass (imf15.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729614376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IfcQit/uWdai0Gz1OYnQOrro3YmwaBdxtR4cFYi7qqc=; b=RUjwMab8T9Qn/sNQd5jBlSTe3hFw0VSv1L37l4cj6oz22m3sK/DlcyifBtK2Jwhsa+3ZFe flwelJqd3WmSpXNzgVhA54Gy70mX5po5cshc+yykVWfuk8xYOjAuSinvlQGCB/iIrcY4GM WSMVN7FVXjW5eyPv6BzvLypFDofvTe4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b="TPJDLz/T"; spf=pass (imf15.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729614376; a=rsa-sha256; cv=none; b=jHkUrhmJ803Ta20p50YkaLsXbK/QxZOmvN+9Ni3K/09GGEA72jJbBmOE+96yB9RXfcsFQ0 vKbI3MbdxnYNr94gJ9a6kVP/eLgtkxTUq87CH1E3mPhVDSQ3ZbSBxERPqW1/yk6tHP+CuJ SO+Y0s/39mez+zUs/H6U7tQ+XU3ehmE= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-e290d5f83bcso5296845276.0 for ; Tue, 22 Oct 2024 09:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1729614452; x=1730219252; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IfcQit/uWdai0Gz1OYnQOrro3YmwaBdxtR4cFYi7qqc=; b=TPJDLz/T6B0a2BjyaKrLXwhK6KnVkA2291phPZ/zvtB1Z8ngDpEVL44gL/qKeh2GWn 0f/95KzAIR81cn3W8mld/jY1hS+btmH/pJpJgyhzvgOtFvLE66rik58H6Hyj+pHLeoPD k3R/tqH9KnSCIHZ7wp4SxiVPmgxao69OjTs/UyEhdBodbRgzPMQ1HrTfXwhLZLm6avFK /N+SW2hXGD5iZyThT272FhUqxIZNUCHQ/TuwYmxo9CfUQkeBuSmgItGQ95cYZmQNojbL Q9KiZxTfdzxDxfN+xosVyA4LMVnUy5kmt72nJyu7cJF2uDTsh9XwLMyyAHUzYM/09Dll fcuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729614452; x=1730219252; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IfcQit/uWdai0Gz1OYnQOrro3YmwaBdxtR4cFYi7qqc=; b=RSAvu6/EqYl1d2vWP3oNTeTam9eR+qGhO6PSQfCwFIiLmYvMCaUX9zutY+o/k/Aoz8 UDfoTz6WpdfDi6CG1N6gWBIYnl9++Gb85foDgFlz+1Bh7egXkY7JPQg0ryeJeiv5dNg7 xN365eFsHOxu7Kkd7yQar1VJv73IoL8/WZtIdc/5chKQb3snMeYzNC8wpRjSNKev5cXC Scw0FNd/tLeZH/7G+fQAvsecfToRKOVWPL9A+OFdzmKxFOTUbC+78bqJcwP8IALgIIDF rcdb3PSILAbWFB7+49M/VliD/XPHpNe9cE8fDdBtY0dztLXV1Y6vhGUndFHhBPIbUgVO YQtg== X-Forwarded-Encrypted: i=1; AJvYcCVuO96NZJiSBKcvtn9+VTKjO5x0D+h0/2N5ZYcNMXkbbAOEWsaZ3KDXoxvS2AkP92qbVRreo8rJTA==@kvack.org X-Gm-Message-State: AOJu0YzckuR0xDGv3eKcAhFh5572phYE4wqSmZQuXLAJCE8Ny7XHpGas //d8xA0df9EYwlqSTmmc5IHBzPM4yG3rLOS3nEsdaCsuUvcBUBKzA4tsCi1CIui/VgbYIcobBCs snUcv+S7qXQZT3xm96yhKA9o+0pMffySJjDeH X-Google-Smtp-Source: AGHT+IH6teBDteuKX1IfTUU7aOF/brFPLWkJN/2yz4gkMpur17JiIyAYiy3u4lW9412aaSoQIXj6qPi46aPfQzyDatk= X-Received: by 2002:a05:6902:723:b0:e2b:d610:9d61 with SMTP id 3f1490d57ef6-e2bd610a475mr10370763276.43.1729614452032; Tue, 22 Oct 2024 09:27:32 -0700 (PDT) MIME-Version: 1.0 References: <20241018161415.3845146-1-roberto.sassu@huaweicloud.com> <20241021200636.308f155a72f8a4d1e26f82b8@linux-foundation.org> In-Reply-To: <20241021200636.308f155a72f8a4d1e26f82b8@linux-foundation.org> From: Paul Moore Date: Tue, 22 Oct 2024 12:27:21 -0400 Message-ID: Subject: Re: [PATCH v2] mm: Split critical region in remap_file_pages() and invoke LSMs in between To: Andrew Morton Cc: "Kirill A. Shutemov" , Roberto Sassu , Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ebpqwerty472123@gmail.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, jmorris@namei.org, serge@hallyn.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org, syzbot+1cd571a672400ef3a930@syzkaller.appspotmail.com, Roberto Sassu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B59DAA0030 X-Stat-Signature: 1yf85w9igbofop3fjqmakuz8umuy36am X-HE-Tag: 1729614436-96759 X-HE-Meta: U2FsdGVkX1+Vf7zXZodMh5XjIlaZTQjvsQmnnQv8vRgHnoKPMuhaEKiZXloRDglHDSWboOCp/HLkZi2zGKpz7hNDUAmB8JrS62XVhKRaW72AUr5OrwB2JTjXJXK+RnZbOzfW7UP+S/n/hBaIfoveF97kleKIAAMxfhyN4ZlTAd59O7A0aWxQUD3w6oVm4fFCnUQnTmOinucBHccdX0rKvmfw7bvJ4075E2u8nitRA5dNXy0Jn0NW4sKUMh4AfyQdX3DCuEs9jFP8qCd0pjBKD1/AZlQM7lVEoeOXKsmPpYx9VMRCpdK6qwaX2LXkamckFabHYZ8riRvvd+dGQpFW/tw0ng0UV4aFBKFAn4QrYLPxcMbxMGMuC9A+kFvVGB+IXWJJfyNmbFG4IPQSXThs0i+wcEBObI8SATtcGfeZONacb7ebD6/cYx8doZW6aYxtf41dI43iqwalmAE3Hkmzh1ki5ysHoiuhCokarlw1oMWWEXgJlTRF2OpcApfjR7ugkKe6Lvl2xBsqyC2qIErdGlDvvjc03PpqNsQmIfk7FyIRm7hg54ZdvSSp19QU3omPy4Qdki2fGaXzziEZMDeaUgXrDaXzIdgMBbHpk5q7yzfce040RWiGKYPaqNqEUDlFe1vs5d4hR79DlkWUZo09edpaOW/vS09o9M7199YfgtuuXTRHf5yUjZCD2l3x/9jyWyPQK3MowDqV5MxZLCcichRLvR9DC2HHSevxC7bkG/mf1yAiaoOlD0L8TZXPCD9OHOFjIm0BPaxFMpFcNcldfXo09aNOAqMGPNCQbaisbxTqxbdSJ/8Z443HgjoiaqMMXeWhIzdekF5NXYTGNLjQcV5nQejx9LQzDoPtvCnbZsU2lBT4/8G0JWxLt0WYF3AjVNF1mDbL509MQrFgbLFMKFt9i/iKJQiYag5Xx7jUEDB+fShbYjXVhTMuxqy2+ULGzGjWeDycqvkG8Xb9CFc 9gRQgU4z fQnFfKLWGrCnQ9V4EIu42GUabVql7dee/BF9rxprGkxHWKDbljlJkgbVeop4EXPNOTeibqZkNLbxAn6FAAmFox8isU6xQkDapr8n2o30uKodj6F147QzaH7K5lhhnqk1MrHVGwftkOtnwH+Ee5naSIjRn/+EZoDSnH6+RzMJHLcMoZvpYErDTReuLMpuL8YAJn9hX5sxgo7Q1mkjGoUoMDzVR6vN+Nv/dnKwieQiaqvJYrF9Y5AJ1Tbor8nbqNE0gjs9BpULIMvRYsA+86213iugisM5JNM0rcYmLQG2IvQ0UuBb21h067D7UowJynd10FWIk9mS9ldcL8aQeji7L5hZWeRSaxCNoNPSAZzrSmXVKiWIqwiFV+I4bzvDdSJC1o7W5dIZ9T3bZLhToNaclfuc7OxtpKaoQIbJgeEHljPWeiWaVisCmEhD2aS6hV98oZ2J0FAvzZXaMFWI5LKqn98ZDpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.019566, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 11:06=E2=80=AFPM Andrew Morton wrote: > On Sat, 19 Oct 2024 11:34:08 -0400 Paul Moore wrote= : > > > > mm/mmap.c | 69 +++++++++++++++++++++++++++++++++++++++++------------= -- > > > 1 file changed, 52 insertions(+), 17 deletions(-) > > > > Thanks for working on this Roberto, Kirill, and everyone else who had > > a hand in reviewing and testing. > > > > Reviewed-by: Paul Moore > > > > Andrew, I see you're pulling this into the MM/hotfixes-unstable > > branch, do you also plan to send this up to Linus soon/next-week? If > > so, great, if not let me know and I can send it up via the LSM tree. > > In the normal course of things I'd send it upstream next week ... That sounds good to me, I just wanted to make sure there was a path forward to get into Linus' tree. > ... but I > can include it in this week's batch if we know that -next testing is > hurting from it? I don't believe so, I think this was just a syzbot gotcha. From what I understand remap_file_pages(2) isn't used much anymore. --=20 paul-moore.com