From: Paul Moore <paul@paul-moore.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com>,
linux-audit@redhat.com
Subject: Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file
Date: Sun, 22 Feb 2015 08:14:28 -0500 [thread overview]
Message-ID: <CAHC9VhRPFcEYN7gfMVbVtnQgn=JhXiWiFe4__AHqaC9pqGfUPw@mail.gmail.com> (raw)
In-Reply-To: <1424530825.6539.7.camel@stgolabs.net>
On Sat, Feb 21, 2015 at 10:00 AM, Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Sat, 2015-02-21 at 08:45 -0500, Paul Moore wrote:
>> On Fri, Feb 20, 2015 at 8:23 PM, Davidlohr Bueso <dave@stgolabs.net> wrote:
>> > On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote:
>> >> I'd prefer if the audit_log_d_path_exe() helper wasn't a static inline.
>> >
>> > What do you have in mind?
>>
>> Pretty much what I said before, audit_log_d_path_exe() as a
>> traditional function and not an inline. Put the function in
>> kernel/audit.c.
>
> well yes I know that, which is why I showed you the code sizes. Now
> again, do you have any reason? This function will only get less bulky in
> the future.
The code size was pretty negligible from my point of view, not enough
to outweigh my preference for a non-inlined version of the function.
Also, I expect this function will be one of the things that gets
shuffled/reworked in the coming months as we make some architectural
changes to audit.
--
paul moore
www.paul-moore.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-02-22 13:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 0:10 [PATCH -part1 0/3] mm: improve " Davidlohr Bueso
2015-02-19 0:10 ` [PATCH 1/3] kernel/audit: consolidate " Davidlohr Bueso
2015-02-19 3:23 ` Paul Moore
2015-02-21 1:23 ` Davidlohr Bueso
2015-02-21 13:45 ` Paul Moore
2015-02-21 15:00 ` Davidlohr Bueso
2015-02-22 13:14 ` Paul Moore [this message]
2015-02-23 2:20 ` [PATCH v2 " Davidlohr Bueso
2015-02-23 21:59 ` Paul Moore
2015-02-23 22:02 ` Davidlohr Bueso
2015-02-23 22:24 ` Paul Moore
2015-02-19 0:10 ` [PATCH 2/3] kernel/audit: robustify " Davidlohr Bueso
2015-02-23 2:20 ` [PATCH v2 2/3] kernel/audit: reduce mmap_sem hold for mm->exe_file Davidlohr Bueso
2015-02-23 21:59 ` Paul Moore
2015-02-19 0:10 ` [PATCH 3/3] tomoyo: robustify handling of mm->exe_file Davidlohr Bueso
2015-02-19 5:38 ` Davidlohr Bueso
2015-02-19 11:07 ` Tetsuo Handa
2015-02-19 18:22 ` Davidlohr Bueso
2015-02-19 22:11 ` Tetsuo Handa
2015-02-20 16:28 ` Davidlohr Bueso
2015-02-24 2:45 ` Davidlohr Bueso
2015-02-24 11:35 ` Tetsuo Handa
2015-02-24 19:42 ` [PATCH v3 3/3] tomoyo: reduce mmap_sem hold for mm->exe_file Davidlohr Bueso
2015-02-25 11:40 ` Tetsuo Handa
2015-02-25 17:39 ` Davidlohr Bueso
2015-03-04 17:35 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhRPFcEYN7gfMVbVtnQgn=JhXiWiFe4__AHqaC9pqGfUPw@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox