From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E79C36002 for ; Wed, 9 Apr 2025 20:19:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 109B72800A0; Wed, 9 Apr 2025 16:19:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B95128009B; Wed, 9 Apr 2025 16:19:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC1542800A0; Wed, 9 Apr 2025 16:19:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF76E28009B for ; Wed, 9 Apr 2025 16:19:44 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5B1551A14A4 for ; Wed, 9 Apr 2025 20:19:45 +0000 (UTC) X-FDA: 83315621130.27.C4DD228 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf02.hostedemail.com (Postfix) with ESMTP id C8D7580006 for ; Wed, 9 Apr 2025 20:19:42 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=QjBuoBwO; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf02.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=paul@paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744229983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VsHh17W+bDIV1e4xVUO/JwjeRPH7cOalB9Js2vjnhrU=; b=KFVZ3XHKkOr9yrh4kQX/fkuZaUasi7YseRMj0jXkDfZWgk0hXJ9fWX+OuPCll1LYbH4rMI +hFsFsh8427cki6Q+rZEZawHApJmopezLa/6bK4dFLqjyqd1baJWGdCKI171opxwUqSVLy DLYTRVrxjjU6RrnFqD6BUcwiJhyF1Cc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744229983; a=rsa-sha256; cv=none; b=5UtwlYNPF6tgY/6UOUeEYoxVcmSBl1j9a4JjkmSgHQ9srF3SimfwerZ2n4iP/VKeN8wdq2 YXOP17LKaY0nJKY2QstSud0SkbTEenKk7QzzAnmBZQfnhi2Sonf6MjEQ2LdESk1N+DBPjD 27TMGRh367kYNAfQZ2jZpl1S00yw85Y= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=QjBuoBwO; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf02.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=paul@paul-moore.com Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e702cffe574so53996276.3 for ; Wed, 09 Apr 2025 13:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1744229982; x=1744834782; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VsHh17W+bDIV1e4xVUO/JwjeRPH7cOalB9Js2vjnhrU=; b=QjBuoBwO9c3YCwIS70YgnconioealJmAh3y3OGlgzpMCeNFlZUcCMLGQ5lj30vRN0i UB4XAYcWN+dcYfn6UC1T087ZBBoa+Mj01ZZB3RH+D8UFIluKnTFtDwPw91Jo434IU8X/ zAiS4B2u6BakvumJUZo7lyMCp3cdwEJV9JQl+YzMQiMsRXNh/RlhhjvqW8n+hacmBfL2 mFmlbRWCM20RPVVznnESJHmxwaZwqEDcuei3tGmOZ+CSr4o7dpV3ibqyO15Kx5LvJNWj 5APUvStrvBTlpCTBHq1MDViRMDiOUYYZOvEhyqmZGGwVYeSDlPypCY5RDQidT5/poA7q 9DIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744229982; x=1744834782; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VsHh17W+bDIV1e4xVUO/JwjeRPH7cOalB9Js2vjnhrU=; b=UKGc9fsoGAeOmOspM46FM+hp/ykK1gw+Z+yLPUsr9TIB2RUMlOF58xH0F+vEazOoun Dlpp6oI31e+3BL2Hjmxf/D1ofiRcNN3hS+nyPG6pfu3wpoM9vO7oTKe5D5/vwPQ3EbJ8 lOoLcjSZ8PuisVGN1R9pVYTyWdidUPouEdffjhk8nUmVh/rv/ZMyNC77g+GaGloiXh6q FuZSCdQVIdcXdQSWoDRzZcd7L7tltIjLqEHVtA+2lFR+cpj+xRtzEan+QZbXXPzcHV66 HC0ixqCg8TMKvx6Pqueg2kOTHDXqB96YyRHYlNnOOIuYgwFOEsiyX1xPb8/yBZKozfOz rGfg== X-Forwarded-Encrypted: i=1; AJvYcCUjKHC/gZrgOvbbVWF7dkmXrwkEC7NdGJp2CiivVg6TogMGzHJh0whYpB6ZQRcW6VplVMKy+nHyKQ==@kvack.org X-Gm-Message-State: AOJu0YwUBeIo6nIFpM2batGKUOmgVAD4vBhyjZntP3PEBzX3HN+kZjLi GSvYVT+URqmKwDfT6NwCdxZcUhUO/fT5NuFtZ+I+tAADopHGbC4KZMqiywekg7YjpbnvEvq6fum Vvogbc47jzJtZ4+iBqP6cXMXr+jY6xXg7apTA X-Gm-Gg: ASbGncvgw8XZpK6IGH4zexUxWT6GSqBFvSKIGiv6olp/cLDY2P4we7bmh12BHtGQFt8 AZQ5yhjkZPbQzw1wxmm6/sK1CQaovuuiG4676PS0b4kWQxMxUNTxHUkl43AaNRETZ5v7Y5586ak QPVSgE2/igdaBEJVnRj6IcMA== X-Google-Smtp-Source: AGHT+IEGCJR9IA5jDMT2Of/TaTFQ6Kl+jhMbbHqtWzPYG+QuFj2lKMDW1yD44Tl3NdNB6jTiuM59Ql0Ux2XWfYO9+PU= X-Received: by 2002:a05:6902:1b90:b0:e6d:f3ca:3e15 with SMTP id 3f1490d57ef6-e703e0ecf38mr658467276.3.1744229981817; Wed, 09 Apr 2025 13:19:41 -0700 (PDT) MIME-Version: 1.0 References: <20250408112402.181574-1-shivankg@amd.com> <20250408112402.181574-4-shivankg@amd.com> In-Reply-To: <20250408112402.181574-4-shivankg@amd.com> From: Paul Moore Date: Wed, 9 Apr 2025 16:19:31 -0400 X-Gm-Features: ATxdqUEUOdbJE1FR-JWrcEMUFKxoL7rqK5e8WWf2cXUgc2Yd72xDgueuEkSahFw Message-ID: Subject: Re: [PATCH RFC v7 3/8] security: Export security_inode_init_security_anon for KVM guest_memfd To: Shivank Garg Cc: seanjc@google.com, david@redhat.com, vbabka@suse.cz, willy@infradead.org, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, ackerleytng@google.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C8D7580006 X-Stat-Signature: tugneiorqhye46x5p5po973s477acx9j X-Rspam-User: X-HE-Tag: 1744229982-713180 X-HE-Meta: U2FsdGVkX1/sF3OQ42rcd1L1Sa24FFpm3ng42X9FncPNetq3h9It5csbJsJNzJT/lnPnkLQd7+1zxrhL3bsfUS634Q5Roz3h7LL0VeDSLmtxw/zBl0l3/zrJWaK73A7E52NjglIMAXWspEgcLLQC5Im94+eQBkEywQLu9/y9FvMvD0rFp8vlm3pwF+evGoc3rGDNaWKLbyII2n9WN8VA/GkvPOHmm0XmOP2p6ori8FaX6kPgoa+TIEcd/3rOpMR7DP7dLhF3qeUfnGYjSnOQoP30kJ5uQ1Ok6l5vdaQeYMV4BsM+AeVdGclrPiCV2fcc4Oeb10UsEVtyVqCvyk8AzNKEJlIy0QhtM3bHeJfLNB0TOkVy0RLN+0VpQ63ouQ4yh0bwlgnZ3OefrOJGFNpFtuKZeoJfgesIrYyXOBObXOpbBl1jjhpFPDjhiKcujooTB/qlJKfH0PBqLJ3iwGqWEvANCmKJ87CkB97W51YAc9lVxfLtE4hr7dUdpAwhbdICiCuZef4Klp8n6fN1FfqcQlIn/2i1/n+1Pg34/oA3PgIkUah74hjkaMIulv2P0ejVnqHL62/L3XUw8a5zVxfNkRbWqHGBmPnyhClp9/iy989/QskwB4Ka8XLB6gCtimB68+Qdpgen+x3ENjgagtv2TOSxyncraQkrciKLiglAegfFK+lmLXWU3jDhTFgGVloEJ4m41saWFl67xGI54uiqukE2xpvPS+eMMLLJrfxLEXzlN9BzInf8+sRW80RmbpVLkvsh+vTiC2llDq2Tvn3ZzCFz8QXR9MU2x+UCIBzujjUL3fgi4e9cmab9KXIk0xJTHXmGKrwsVB/onM0uLMbDUO74/m41tyvIKftrpu4hj+EU/K1olIZcoTgogAbxV5TPt6enZuuVkp/PSCtVFpdY7Qk/HHsdwjE0JKwwIXSCsXsCGBTOxlQ+YDeGvx4q/zdH9Vpa1wTTLCIU4z7hWxd K6KirdMN 7K1XubENBe4Rnr9rJH2GEiO56yj2UmaK87fyBc3UYQBCD4ANQdLomjrMYYlyKxLQTHgJDIHncWXzr/P1KS0Ue3AKOzCqfwDCXSVKGjtuDpiZf/V2cLrWgESvgjslUwdT2udRflR+1uXuQgoQXDV/CNX59NpwA97QKKrwJf9jV2TzMrrBWs2KuNALx0NZh3Hp8xQJ/hUZGPqXJ30TpAGKx8rTuV+TlZ9Qj1pqwpJgb36dWwJs/wV1Ozg4T1HlwLA/GaoLgk63WGJIGXpmypBg2CkMG4yTcMtlXn6bNixGGIl6DGXReVlgOsqy2t/GGGDlsKawghZSMFsjtraw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 8, 2025 at 7:25=E2=80=AFAM Shivank Garg wrot= e: > > KVM guest_memfd is implementing its own inodes to store metadata for > backing memory using a custom filesystem. This requires the ability to > initialize anonymous inode using security_inode_init_security_anon(). > > As guest_memfd currently resides in the KVM module, we need to export thi= s > symbol for use outside the core kernel. In the future, guest_memfd might = be > moved to core-mm, at which point the symbols no longer would have to be > exported. When/if that happens is still unclear. Can you help me understand the timing just a bit more ... do you expect the move to the core MM code to happen during the lifetime of this patchset, or is it just some hand-wavy "future date"? No worries either way, just trying to understand things a bit better. > Signed-off-by: Shivank Garg > --- > security/security.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/security.c b/security/security.c > index fb57e8fddd91..097283bb06a5 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -1877,6 +1877,7 @@ int security_inode_init_security_anon(struct inode = *inode, > return call_int_hook(inode_init_security_anon, inode, name, > context_inode); > } > +EXPORT_SYMBOL(security_inode_init_security_anon); > > #ifdef CONFIG_SECURITY_PATH > /** > -- > 2.34.1 --=20 paul-moore.com