From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C23EE0212 for ; Wed, 13 Sep 2023 22:01:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 042136B029B; Wed, 13 Sep 2023 18:01:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F34F46B029D; Wed, 13 Sep 2023 18:01:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFBD46B029F; Wed, 13 Sep 2023 18:01:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D2FF66B029B for ; Wed, 13 Sep 2023 18:01:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 82F0BC0C4B for ; Wed, 13 Sep 2023 22:01:55 +0000 (UTC) X-FDA: 81232947390.17.24B5048 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf18.hostedemail.com (Postfix) with ESMTP id 085531C0033 for ; Wed, 13 Sep 2023 22:01:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=TVKN7cPT; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf18.hostedemail.com: domain of paul@paul-moore.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=paul@paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694642512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J1BzhoPhb2//zdQEYrBqERcWxq7EXQZgg5EE9xLjsNE=; b=265hV1XVbgURzp/FqpqYWPOj6pPnnvwv5gX5J6q/eIJKkhKFZjbBT7tOGwynBU5DFlU/2p Dw7ZGTsE35OT0a7NgjcKvyMEyGL3BkGgIo005UVlXdO9oQOVAjXAbP6LYSS2ZMhJsOAckY HE8XdEl8G3TXqhgFF5CcUOmVb5zswyI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=TVKN7cPT; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf18.hostedemail.com: domain of paul@paul-moore.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=paul@paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694642512; a=rsa-sha256; cv=none; b=uIcoGQzblp5QsdduL/yXqLVCLPHJBmHYcYQ3Q9F6QahEaYAPWk3vcDoMz70+bsALKPDCtO xVCKEHlBgNBIPV95ONZkWxl7LytjCUjfEfFYMxJbgZSNlryjtVB8wN1anX8m1/yEdPN5HB Wxy19EnqP0kb4tHJzaI4cLhzWORb93o= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-59b50b4556eso3378727b3.1 for ; Wed, 13 Sep 2023 15:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1694642511; x=1695247311; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J1BzhoPhb2//zdQEYrBqERcWxq7EXQZgg5EE9xLjsNE=; b=TVKN7cPTgwBYVTQALT84RLd32aYVR+dBCYYy56ZI7OTbpJr2P8xtDsJr1Wx9oevAM9 ZjVoiE0mmQqimT64mWVViTk4JDUdeDpgjk1d5jeXoJM5X8VUZkU+Mcxs1/ZsMv2KVBOy MG96NZ338lUvdYYfa40IDjuA11pCEsUkbyEMfRspnouhbfnA8ZtRYNUH+OopPos2iwjS tLVci66oPhURBerZBqES0pwWjk8eawJw7DzNWXMoZeWdOTAlwwBZNzUPnT3YQ4M6wjAd fvka/z7XNgKDjXs+eSDNC8Prusg6aebg6fLzqcu2O29N7k0zP40UGsBnlxwcUuu45yxH 8DfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694642511; x=1695247311; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J1BzhoPhb2//zdQEYrBqERcWxq7EXQZgg5EE9xLjsNE=; b=DnYAi9C2pTdkwgm9cy4t6fu5Zc5yoq1Tq18pFegkeZ4/wIak27eNBw+J4f8oJcuBjH lntklftnWu4IKJbKxxl3YzJJdi6JoYK/c2xygYTPNwTAgSW2dQWFEJGYYbwEByWpUSdp r6yo3VDVEOSf2zLxlsX2QqmLQsvT2sRiJerDUQil18thVejMcg/Df0FnCtOrKghbikAp +7epPFEKZzBhOdnB43/SnVJYLiveMg81MwN+rwMxAxJyQJa5FyfrFfpuPqL0csn8EwLe Dcm7UATxoLY24nlq5za8/JYPOZioJIInK/39f9zgc9Q7FHrj6D8PjJZfxbx8TaxhUbQQ WQGg== X-Gm-Message-State: AOJu0Yy7nXwKjXXJC1WIdApUKL3/hcXmiBDIh9Voc+QbvwbrYa0htCcG B4TAP0y4MEgrNb0Xmf8wL5a5ps/BvpnmT4UqH+we X-Google-Smtp-Source: AGHT+IE/S8VnWj48T5HhcdZ/RxneEfjJCCSGxot8kBZp01rmiH8JIaXQtCkeGNS/ETtaApzkkbtjU52xB6QNSy4jSfg= X-Received: by 2002:a81:8392:0:b0:595:2de4:c991 with SMTP id t140-20020a818392000000b005952de4c991mr3691240ywf.29.1694642511140; Wed, 13 Sep 2023 15:01:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Moore Date: Wed, 13 Sep 2023 18:01:40 -0400 Message-ID: Subject: Re: [PATCH] lsm: constify the 'mm' parameter in security_vm_enough_memory_mm() To: Khadija Kamran Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Serge Hallyn , James Morris , linux-security-module@vger.kernel.org, Stephen Smalley , Eric Paris , selinux@vger.kernel.org, ztarkhani@microsoft.com, alison.schofield@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 085531C0033 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oowdrxsn63wn6qjmxdy63zoqxzxbdrwr X-HE-Tag: 1694642511-369315 X-HE-Meta: U2FsdGVkX18ePk5xL06qOTwSYFSFxBtLHxHN43L6URmmbaoL8lTc6vHeKnCkzKUVVifFAIsbrdo5ub+GuZIPMYelwxGkKXFayqvQ5wbPOOy529g1v3ZCMH8uEg75qB7MZh7LwcVNGbkqTRPh17X6QNT74LXiVaSGBc7te4AAEFrB5XYYaOrdvYWSMtctd8wBeMOi/saSoUZuC8mbF6WX1ia31fJMUOuR8lMVj8qx06MFaQ6U4Dg80Pc5O8lnYazPQdJS+2NgNYl6NBTvsRS4lRH7BMlcRsX8DAbWvxeiZlJMelT8m0yAMeL4IKNkPOXNvWWCCYzt1ZXJ49Ait8azgwTTCaQc6kJ8HOeA4/3hWXrjPfAAzdu6f3MUWqgPHLJ1728zKwwElbLw+6uhS42l3O+3xx18S6V/Y/dKAedvROIi6vfJhNUU24D8N80ULmMP9gIgUk7SRcE6/5ZuDwZxsh2G6MT/WuOboRkDCT4iLkQwbktLOMR3JqMTzD/BfVSSJ49CAtj+MGoB0fipcC+tiPO2yEGnfLO3aTaN+3EbEUYRDDjoC6u8VJmn39N5HcEJjwIDXaQWl0/mXs7JhNJDEoUHmeOvFEsee9YOHQfKR1QkhIzg21rLBOLrNbEIldsOWAFuQuLibCC3QWKhxnT94ySuDUoQbIbpUZ/vcGJKX2ylBvMNy3jgC1Bm9i/Wg1wllJHh0+LW68HesZzahgnfEdVg7jruPdgZiDlZzxTT84mYJl4e1gUscYrbX1X0B/wbfE86yiJ3pBRkERoVPVanfMJ6Vj0XC8pAn/F/GBlsSVTwQdzuxAfcVK07Wd00thLAA18mpR2s7heDxy0ogl3jYmavVE0ZxMgWRYhbWXd5U/Wli+9sqHiXo9QCXkPfzxI/4Fxss0imPtFzMbKuDCpD6ag72XdVg38/hJnRD732qXwIPnT8ZCG8BlvdsgHzhY+iYBEPj3g0BaTEK7kJuV7 K5Tn2TaY fKcE9TepuM/9q79JR5m7pBXDPThkjOhIr2ZRGwD2zaFUKOfgtGsMRXNlfou+mrNSgPpd55fXd85DtsdKdUenxbrRmrXYq9+SeG5dDapEV6M2DJc5bN/uajx3swBr5NLuEScrfcpgHY/4auO7+0/tOwP065/xP7AEINkSScGWjg18wI8J88HZ/QqCOWP2Rzp7RMaoJcJxG6joA7JIH8je0Hb+9qYKbf2ZQQ5SvVFCtFfeH22AIBEvmdfC5U4LBfr1fVOnYFkhkHIm3hSKL2SAPcavfoBeAO3pg1156FDkX5M/d1fMBacj9eyAmM5E9IQzWi0KwYACCGBo5vY3eBDvDrOowaxlvhdzkR0ooaNhos3FeysCvLWmqxs9M/XR51cFvI9Xp7CiLQm2Cdtj/6BjlqHOEjZyGoKuTzlOYBfjggZb/KRxud1JALZe5xzB4Lx5YzbFJAQ7wiUkgZ/Eu3c5vbmgioH7l2bHnS3Z1Ce5FoOKbcBygwLJZIlui3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 23, 2023 at 8:07=E2=80=AFAM Matthew Wilcox wrote: > On Wed, Aug 23, 2023 at 11:53:57AM +0500, Khadija Kamran wrote: > > +++ b/include/linux/mm.h > > @@ -3064,7 +3064,7 @@ void anon_vma_interval_tree_verify(struct anon_vm= a_chain *node); > > avc; avc =3D anon_vma_interval_tree_iter_next(avc, start, la= st)) > > > > /* mmap.c */ > > -extern int __vm_enough_memory(struct mm_struct *mm, long pages, int ca= p_sys_admin); > > +extern int __vm_enough_memory(const struct mm_struct *mm, long pages, = int cap_sys_admin); > > Could you remove the 'extern' when you touch a function prototype? Khadija, can you please make the change Matthew is requesting? --=20 paul-moore.com