From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C605C5B543 for ; Thu, 5 Jun 2025 18:23:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1BED6B00BA; Thu, 5 Jun 2025 14:23:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF1EF6B00BC; Thu, 5 Jun 2025 14:23:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A08166B00BD; Thu, 5 Jun 2025 14:23:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 803606B00BA for ; Thu, 5 Jun 2025 14:23:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 01B891A12FD for ; Thu, 5 Jun 2025 18:23:34 +0000 (UTC) X-FDA: 83522169990.16.F8027F1 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf03.hostedemail.com (Postfix) with ESMTP id D20AE20015 for ; Thu, 5 Jun 2025 18:23:32 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=dNPj1F5x; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf03.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=paul@paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749147813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vo6V4Ppsn9eFIGNfpfF7fHNiUwnu2FfDlKV+ixE/pPE=; b=0tM2ZS12DH3Jk230cQhIQ5Qct8XGZHTFNjnNEf1MpM4IKz1tM68EkPFkVSvxkAgXsZaF6S 2VZxvW+JDlo7rz4JUqDJzMPd0dVDHJqRAE4YyaPtEvzQJCbcyjjrzI0P1L4uAK/BhRWHqx qsiszFgvT43jEEooBNQwar3LlONHvFY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=dNPj1F5x; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf03.hostedemail.com: domain of paul@paul-moore.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=paul@paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749147813; a=rsa-sha256; cv=none; b=6LvY1MQ/VXQAn5g1mXFA+0ZY7VLqnVbwzoXQ/DJErpHUyz4yp2mWwFzLzBGrCU15aX27OM nGfzu0NycX5JIp0VxXYQMlt6RhSt7qKCFuc9Bn8NHqKPGPDT41UlKHWr04iB2sxshoUmgg kDyIqf2Olx7mRMyyaeh8tQh8NANK7fs= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-e812fc35985so1303798276.0 for ; Thu, 05 Jun 2025 11:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1749147812; x=1749752612; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vo6V4Ppsn9eFIGNfpfF7fHNiUwnu2FfDlKV+ixE/pPE=; b=dNPj1F5xOpGvrjvNX1P9Kt6uxLSDillSAIH7K2iwwnFtoatsHo0S+nISPuHmCTY5oY N7xJD5Yutr687vHfwBmwRpYk1DCKPEFyXwbIDegA3SLrVexbYyscjEhxuCQ4jKG2pFll hSXJKEXX5CI5AUwo+LHXuJ2kGNoe+2LCe3dPMd307pSmt6Nyp+iyDq5hWkUsfaMteDlm z1swzBDtDTTwYZcLeuZKo46qtgO9YnfKtG0zIc8S/5fgJxyHJEeql/K+8myj5YP2U2ub msR2lQ1iEO2ZUfaELNl2XcCUu5xiHqIJamGkARLzJv0liwFU8mu8LupGschzFWJqVX8L v/3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749147812; x=1749752612; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vo6V4Ppsn9eFIGNfpfF7fHNiUwnu2FfDlKV+ixE/pPE=; b=sHGOgyDQ9g2333xRkaXRIuAMlxrQ0s9N4r1oyZqUhaFo+QXthUc6CUcnTGkaAFkfrc henI2i5C/q/ir2KxirsUFMBuKH0a5WIpdra5eI1fWQVGZ8obh557mVPq0J2usDD7Xait 0zdUIOPknVv60FBvnh4sSbO423NTR1th3s45IR/hGsH9bcz18sPS9q1MesA3Bt6rK1+x joUIuWp4VmCw12ljUOLSQh07AvIGxo+ecKKxOdR1fXwXb6Kgf6HjN719cnstMSB8YTGS LfwvgTF6i6zI1VVv4By28NS/Kiq5DyEPCkTQLlrJSjaLvnze7LVF4iSmK9gmZU11xCAe bmcA== X-Forwarded-Encrypted: i=1; AJvYcCVora0B3x9cB78TB79aJ97pBNIt3jGRQO5DpQ2niP9SKQQpQuLVVkMa6qpyd5ZWndT9omLexHzYOg==@kvack.org X-Gm-Message-State: AOJu0YxhF/wZXWcS25zA3a+V63izrsYQLRfYoJRKFwcY4QS8G3nhwSSD CQCF7ayT7JW16f79usA7CxaOccNyiP6sH72VBCI0NYe9jHNipk1rNE/BbE32IAn3Xgl9a/7pDjx 3Zt+ITdVzOFlauJdBApMks3tV7RIoS9FqtJrgF5u5 X-Gm-Gg: ASbGncuItbCcZzFGt/S+CWoBrSd30Wd0xEfFcr5s5swKQ79Dq2WW6EFtU/J2X8FkkQx iyTPzVnANnBnsBuq28maHAFDX2arEDVtugotuKA5ts/+92MiwhVGEZRIofSDXzjjVsFpLFRMUN8 3W2chUKVO3gwPiHMC+J34YY53hfIm6YPgO X-Google-Smtp-Source: AGHT+IFlZbkCKjkkUykBJ3kANNnDocnKVC3Jz2qHpf1mQeqFtAa91potV6f9YRNypDxAi3xWFBKbXGqceEKkdz1Ki5Y= X-Received: by 2002:a05:6902:2e0d:b0:e81:9a1c:1c0d with SMTP id 3f1490d57ef6-e81a22847e6mr978672276.7.1749147811619; Thu, 05 Jun 2025 11:23:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Moore Date: Thu, 5 Jun 2025 14:23:20 -0400 X-Gm-Features: AX0GCFuxDKrPh9BVvZ5a1pei5w2LKJ7senFjfBy4ObZ7zkQcfpax-Jaemg5t1J8 Message-ID: Subject: Re: [PATCH 1/2] fs: Provide function that allocates a secure anonymous inode To: Mike Rapoport Cc: Ackerley Tng , linux-security-module@vger.kernel.org, selinux@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D20AE20015 X-Stat-Signature: kjs6ox5nb4gzgcjtbhgy5pi59rubepbg X-Rspam-User: X-HE-Tag: 1749147812-335630 X-HE-Meta: U2FsdGVkX1+qCdbdtgz4A76iO2i8a0N0xNpmKMm0sK+fc6X8/PYVpHfhcyQR+f4pqlWSmJCxNVXqi0hMguY0uy6RenapW7D9spApT61/LtG0EWe2xGdsbnQfemkGsvDfD6awb5yNI6CZZQOHZOl/LCgvrD3SpQt5w3NS2h9qXMqqHmkwrY1T+I2kVArBi427mIAyR+FoBmKPG4ilNbcmR23DociGm69ZD3qlFRiD7JBkFvZ9D3HVjlvPRaOYqlqCiDtwRBh6tVrEUBESs8VWUwGv+2dBsGCIDE2Vtu70PZEC2XTU+AGRw3cfXTMyKBQ5aNJRCNcTxnHhtz0LSq4vzy88vlllEqygR/GWhI9HhiOSBOCf4WPkzQUTMCwEf/erOaFkeP2NaShfeMWzqD7Olwc5ahPCeYoQ46xt21UqJjbyeGbOuNPA6B9nPGpWTZaa5HgEs5jEMNBqcKHyBnU/ZhnQV6jBv2ufWpIetidlpP7StO8tRjR833QGzD/efWY+ncUYlwBR0VOogC4KJ1JSpwJ9QNAU2ca5PXfDjNkz/lxqBcsfHbyc+OEA8d3vppTStk5azmOWbR9ijImAIlh+iCoYRdv5EcGxaRAD5UtPUQ3d710CN3ccQBn8qmmoEzwv5xsg9BOBPcQbpd3AOlmkhOn6n/QeZA7dpleB0UZIXJJNdpztZP+whJBKYTfcesDFLzCjvKFTkbnEyxPG50gyLJRU4zCPoJVBV9zY2nMpkJpaHuXSdr5pkOM4QyBBt3th6VbPRU+lQ3WEalTNM0TowpHxMiWM1XOTz7D5Vm97RDMGeIRyDO4iRdmXBuJUZDHZy+0QA7aMykHkJ2PYoOholbAwLgJ644KBSEB4mw5UGFfTRgah5UNggc9SJgNSqruMeYb2RyvgZjEo+BLpxk2mzfkN5r8Aoz6yxkp5KnYxP/58/8ZX6EL2L7pG/gUfQyhfoK3ubkt7OzyYHrwx2gI WLy4mIJc n42UbG2YNcMWD6cHvo/ANfqBNolptxZihHanZtcSMV3Dc6bf2BLYvzSpwSjLL2MajJy8o0WF9YI4m5lElzZbFMR2LujUafHKbDOVjXcNmCyb0E++hdkkKxbooDhRfd/jKRm9k/SYGsfGjwj53y8QysuqVDhFYhDTdb4fxxwisHr+tfUrw/yF5qapw0hvEbsFYfRSNvV+qwkb5/ueoP3kH9E8tXJSEqDzK85UH7PyK4Q9K9uGip3auQRkbWtLVMuCeI1TfDlZLT5BcRfsEPVNXw229kNiaui5SJFhd0BRid9wM5kO+tH0vhzqjMoOmDsE5LB0HuMio8Jm6cKICwXusloJC8eog7QkD7oiRCu+OJbkLlOo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 5, 2025 at 1:50=E2=80=AFAM Mike Rapoport wrot= e: > > secretmem always had S_PRIVATE set because alloc_anon_inode() clears it > anyway and this patch does not change it. Yes, my apologies, I didn't look closely enough at the code. > I'm just thinking that it makes sense to actually allow LSM/SELinux > controls that S_PRIVATE bypasses for both secretmem and guest_memfd. It's been a while since we added the anon_inode hooks so I'd have to go dig through the old thread to understand the logic behind marking secretmem S_PRIVATE, especially when the anon_inode_make_secure_inode() function cleared it. It's entirely possible it may have just been an oversight. --=20 paul-moore.com