From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72F1C83F01 for ; Wed, 30 Aug 2023 16:05:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55107440168; Wed, 30 Aug 2023 12:05:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50175440165; Wed, 30 Aug 2023 12:05:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F04E440168; Wed, 30 Aug 2023 12:05:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2E403440165 for ; Wed, 30 Aug 2023 12:05:28 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F09AE1601E0 for ; Wed, 30 Aug 2023 16:05:27 +0000 (UTC) X-FDA: 81181245894.07.5CA3F8C Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf04.hostedemail.com (Postfix) with ESMTP id 29E5040011 for ; Wed, 30 Aug 2023 16:05:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=Mey+6e4U; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf04.hostedemail.com: domain of paul@paul-moore.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=paul@paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693411525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=6wWR6vPSewXdystMdP/BcryutnZfkXis7EkLLpd/jjA=; b=a7x4VguHSypPfvruFiKJiPxijO3aSbhNrYrJAxjbWWasBo4hMNYfk5AhCS3jwHzcpadP+v tEKR3DQeijkw43DkrFF/jLAu8oMplvtGxeNwrZY4nX7PzNAuP0DOJs78qo/fd9e+68R8DA 9QqywTbuZaqRpusyKw3Upbv60MlnGIk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=Mey+6e4U; dmarc=pass (policy=none) header.from=paul-moore.com; spf=pass (imf04.hostedemail.com: domain of paul@paul-moore.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=paul@paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693411525; a=rsa-sha256; cv=none; b=sZzkxyj6u1fkxwyPyUTqUJYC4aF827MiJUzqDGNxJqzTbuBbhsJZwYgMeDuEeTmu3hHbI9 c+fTL1rKgn3xokH7YJPMD9AWxEeXRCKvHRlIBBjwgwkFy8XQAK0fwqwy8Pe5s/1EYIhFVW 496DeOrVF3/3/R5ZEi4JXTPal/1yN+I= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5922b96c5fcso65438897b3.0 for ; Wed, 30 Aug 2023 09:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1693411524; x=1694016324; darn=kvack.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=6wWR6vPSewXdystMdP/BcryutnZfkXis7EkLLpd/jjA=; b=Mey+6e4UaY3EwbqzLkOLveY82F9Gx2/bLAwcNZcZbvZBgy/eWKUmEMxIAtybDP0Lqm UpC7hLX3G8A3exEo/+sPnftirw8oJhzBuOOwvLDVs6MqEYE4XO/S0GX2ZFA6YEkrZd2A Wdv4M3iiW15Z63/tvI4q9L5gR5SqIwgrn1PYZ5mHX65+F+te5L9fOTvcOCgqrl6domj/ 9x8miLICizAZwbH7SE2IJbkVj4B0K5YVGw/+nsPgu1wc/nFayX5cm5FB4VqlUx3T8vRg Nm26q1AsONx/ZUWkTWl2m7wISDATlJNGUB8hC+KuraQa3BQMhUIl28BBV9FCc/LyJQ26 4DzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693411524; x=1694016324; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6wWR6vPSewXdystMdP/BcryutnZfkXis7EkLLpd/jjA=; b=hrdpo5QDTI/lDYJGnYn7FijP44rfI5NrRtvWUdq/jooRym1m5NDWDLQUhMnMkKANxY 2gE2EApEB2FUrnD2ZuqHw7QVTPtXCmeLpX3SwLS8xlOq7UmKz07M9S3heVoRhtFTG81v F5Se6X0CAfTwxBm6EkoJMcO4RcXd95OBAAWvnMU2NpQbJILil2IAr3m6VGd9exuz1CE/ mrveFge8kMLmBJnMMdKLanW6fP4+i9K//Q55YOYAcExNACVCgLYMRqIZmUH9bVpvQvyc pmIE+J9m8A2AV5f3DCrd65u7QiEdXWxxgtKl7OVT9N9kzZ9E89fnKnL/ackogFyQgtPI LwvA== X-Gm-Message-State: AOJu0YyStUhHivCJmCkL8fovEM2GKR2/Pkp0Id4aQC/PtgTJ6qRu3IdI BZW/wRtYZDboGH4QtCMnwnamooYQMU5KjEhUVXpGB5nLS/Cv3dhMQw== X-Google-Smtp-Source: AGHT+IG6O2vD9Ui9R6aID4YcLbGDbyy3BOVdDWgdUShKy6tkG2weeuIdcj1Dzsn85ebN3Q5Fbo4k8brbkjhEGBtNmqQ= X-Received: by 2002:a0d:e483:0:b0:595:2de4:c991 with SMTP id n125-20020a0de483000000b005952de4c991mr2549978ywe.29.1693411523984; Wed, 30 Aug 2023 09:05:23 -0700 (PDT) MIME-Version: 1.0 From: Paul Moore Date: Wed, 30 Aug 2023 12:05:13 -0400 Message-ID: Subject: LSM hook ordering in shmem_mknod() and shmem_tmpfile()? To: linux-mm@kvack.org, linux-security-module@vger.kernel.org Cc: Hugh Dickins , Andrew Morton , selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 29E5040011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sic8ncqs9ifgs3fmoceg9izb5bjsdzhj X-HE-Tag: 1693411524-625024 X-HE-Meta: U2FsdGVkX19gDa86MHzLVICp+/3ZQSeuLt9rMp6d9OX00vK1o8pXaK/ZPmlq9EVsdfcmQv1zLTbZv9Cd8KSskR6NDxY5URHLx9b2OXxcKvSok9tVe4Jfaf+2hHec9OuMN7d0NE3RwQ1EUWS1ZOHbBztTGPBrZtr2Nbj9K3dY7sEgKf6477SZekBCxl790p9t4u3jEt9fxr7x042U9Ivm0Wm9X6mtkCa6saQtbAW0x858+j6YxruyxI13wJmOj/99C+O0ehCNt3rPaEEnnBEcd5tFwPdRuH+1WNpdWpSK5zFchVplqMkBp7v3cuIRi2Ub/zq/ONe6k5Xu4q5ET81hyeq18zBUhJTCFe740kERD0KRb465MyvSWqqGZhKJggcf1jD3EH0tWzskcwfpRoqg/miU8If74qnxWNwDqRhK9nQ1gGUhJuiYlJFuQ23sQyLb/l79xIwjKRp+fDbKnNgK5x2HMgm72OEgEU1Puzx0EONrbZvxq345+5wg0ZSlt2LWSIN5BpUbCo4HPbudJPN4Vb8l26vi1O3Qe/bJJD2UDWc1F/uttn1nF1wq/WKVuTSQMxoJzh6esmUVldLV8xwQ/H8PdOvqrwYdIoKzHCXVYtpw1a4NNdDRsKZphYRIXAlVu2uhbVhu48tIGP46XRXH+vOj/XZispUki+OPxTrbwMk7ZcrosEXCdULQuscipE0Cx6oRwKT2GIdm74Ty+e3eoQrzmYrXnP2mMEtqx1bPYDyzzVRLd4z9vrexfaMg+pAKrHK5MKQ97U6m79GkVKwwMDYNlmOSfkcwwc7Ds+57H6gMnLRg2U7j5QPoKTbllGd6qndD+NAVL4QZQllYmlghWRhrGp8GC4uxT8Ej13A01uuJ3NY74SE6iAcDzhmHNtcqz/pLmMJjVXyaMxg/cwy8KqUjvtFrDKw2QVJdldxHrtFnQKkAHUIp1I6xseC9jNQ9bnyhaiKPbcLm8kVzPkz Ud5G8nA4 pxZmgt/cYdhW6Mtr/9x+9n2Cvh+z/1gTb1DLuDw4z69fXaeWAJ8OD0KYfY7lExW0OxPLJnVviYkQ8ouupfA9TT17gHelt9VogkIkI9nX9W8OZiPgEyiCAu2yTvqiZy+g6UoAhuG7ir91jObH9fKheUc+Fjr3i2jGS/6TlKJvxT5aJkUQvXZ3hcaJ8YAPQc3gN4op8VRqvDJ0ewaw+5zTxfuhTpHBax/oPy84g3B0z+a41T4r9KJQ+cQatZpur0kTgetTlxucVmMc+kgzDRzS0CxjtYcSeddiemzHwLoQ30buWMv1LeSEwZBXJFRS9VZsGHNQA8b0UHJLNrnxJystceqrHzPj0LyZLQ47qZ5qnp4YG+E2I70G5TgyR+zEEGUoWzRry X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello all, While looking at some recent changes in mm/shmem.c I noticed that the ordering between simple_acl_create() and security_inode_init_security() is different between shmem_mknod() and shmem_tmpfile(). In shmem_mknod() the ACL call comes before the LSM hook, and in shmem_tmpfile() the LSM call comes before the ACL call. Perhaps this is correct, but it seemed a little odd to me so I wanted to check with all of you to make sure there is a good reason for the difference between the two functions. Looking back to when shmem_tmpfile() was created ~2013 I don't see any explicit mention as to why the ordering is different so I'm looking for a bit of a sanity check to see if I'm missing something obvious. My initial thinking this morning is that the security_inode_init_security() call should come before simple_acl_create() in both cases, but I'm open to different opinions on this. -- paul-moore.com