From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67B6C2BA1A for ; Thu, 20 Jun 2024 16:18:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38FCF8D00BE; Thu, 20 Jun 2024 12:18:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33F768D00AF; Thu, 20 Jun 2024 12:18:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22E638D00BE; Thu, 20 Jun 2024 12:18:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 021278D00AF for ; Thu, 20 Jun 2024 12:18:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5343980322 for ; Thu, 20 Jun 2024 16:18:24 +0000 (UTC) X-FDA: 82251774528.28.1215326 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 6F5284001D for ; Thu, 20 Jun 2024 16:18:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="jIOvzh/A"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of takayas@chromium.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=takayas@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718900292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pr/Ikd1c+WzW4xHwcwh9vXtLfFfjK/HDJCD0eaHhW+Y=; b=VZtgund03Cs9atpUQV2hwlMskNuUGY3m9eiRY6dFEIIoGoEj4rsrakHQXRjLmVrfak9I4E n3ZQfocUdtJrRv1cPuUAohTzxnGxdXFG7XJ0rr+3w8QnRuNsqnfP7BN9fsFXKh4KwiAgHZ jLJXw/Kd8EElo3Hfwgkiyw9bSgarMks= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718900292; a=rsa-sha256; cv=none; b=CtnEHgOHCG8+0wWP7SfJsjaTf5tgy1/AXEIVDXBxGf3whLfCR3rlcAK8V58/lymvytY0BF b/M8OUM7AuBIQVAeczX/oCy6R1tsP12oYOGd4pDE9lq8fHM04Rw7brx2B6P7dmtktLlH/l 7Q0R0aGrQs4cy5oN4KI1eCUTJ645QgU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="jIOvzh/A"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of takayas@chromium.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=takayas@chromium.org Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5295eb47b48so1385449e87.1 for ; Thu, 20 Jun 2024 09:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718900300; x=1719505100; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Pr/Ikd1c+WzW4xHwcwh9vXtLfFfjK/HDJCD0eaHhW+Y=; b=jIOvzh/AUifozmSWlsLzhItEA/SmGx2O0UBQ7ujPo9SBG4Cbpbsyx13zefqm0r46TC Dlr4MHpPWW5nNZ31SH+sh2eky6S/u4or0WDjBrjpTMnJoskvXaxqMfV5gbZiA+ThKRQ/ /8w5BxgGWtdSFL8nC+W+zXWdLEuk9n2/AGaEU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718900300; x=1719505100; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pr/Ikd1c+WzW4xHwcwh9vXtLfFfjK/HDJCD0eaHhW+Y=; b=hI/eQlVcf/YR7pkhnyEHCeMcwczWXpbk6yuWVKmMJpOgKE+A7qhYp9PyfHKszSmGhr 411PceU3Zfcn5491nYvIk0e6Xzj6Utpr3fN+tKAvHWJl846O2JlfkBXAfWTED2w1kg1g xfnbNnc7F5U47OnWn5IbYwndKimNWmG4YH/wj5bGAJpUjGhKL6FXAXYp3bTP/QnWBeYB 3Geu2AJQXSTHLa0PgSM0QeOny4pJZzPm0OPNbVIrHAyWeZdBplfXB9Ot3CoGcxgbsK1o lQwrLyXI0Amg7oPs4rgaScK5aFXCWPuKt3NnniBg2WZNsUaZ1m+Rfrb0FtzMECiNtWir ci+w== X-Forwarded-Encrypted: i=1; AJvYcCWnQ9bUz5dyNfUeeBo0AR6QxCorzwrPZ96zAU+B9tctf2CQZE5io2CBHltV5ENG6Qzxz2CZjneobIGBki0udrTgMt0= X-Gm-Message-State: AOJu0Yw6ByRZ7fZsY+szuhb+nGRM80Y3i3S61JUbweaaYkQEwR4KQBXt 7F+b852KPUuS8KXvfv717oFZGXLKFgJYcLSlczGjnMH5QO+f8fJeYMY6ihx6caK7I0PnGfPDgNG fCJGRUy0XYFXwMTkuJZdFlra83WbrrwGkaIY= X-Google-Smtp-Source: AGHT+IHDU8ss1nc317vIe2fyNJOwpxsq9qAqH9/zotSaIpik4JcCY87vNSLPwSCr4vV4re+EvLAuOJ0Jy254SowvUGM= X-Received: by 2002:a19:8c0d:0:b0:52c:af5f:8535 with SMTP id 2adb3069b0e04-52ccaa5a8cbmr3226753e87.18.1718900300382; Thu, 20 Jun 2024 09:18:20 -0700 (PDT) MIME-Version: 1.0 References: <20240618093656.1944210-1-takayas@chromium.org> In-Reply-To: From: Takaya Saeki Date: Fri, 21 Jun 2024 01:18:08 +0900 Message-ID: Subject: Re: [PATCH] filemap: add trace events for get_pages, map_pages, and fault To: Matthew Wilcox Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Junichi Uekawa , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6F5284001D X-Stat-Signature: toks4fq17d1kc5ygcyfm5up9x7amo934 X-Rspam-User: X-HE-Tag: 1718900302-776746 X-HE-Meta: U2FsdGVkX1/NYyVseYoXDUU9z8LTjFGuj4TdQcPaUQteBCc8XWpFf4ahDq9zhePjJJXf1w+KmfO3Iaf1WselKbmrrcvm7Mz2VtQZGCBnoHfqLXqoRP6ydEvkcSCRovyj+Wz/IIg2IwYfzIETap5IQzkxQ2I2Pa62Do1xCrF8g2IwOh4LZTJfJZvDQ3b3SyTWXsaA8Bf+lUnT56rEhCX/4HGP63nQtrzBr0/LPWCJMqjV58j9zEaSsXjv/cUp1N1c3c9wEVeISbwzzgDq/2tCtW5PDvK2GKVDsUNOdQvaJGFEZCUOho1vDdYG5KcmnbHm6jl82Klyl6mCFm9xVVhS8kuv0QA6prvWNS8yPeP2qiJZice6m9jez8uhwTxZE8kGtsr06CJ/qLJl6YtSswDhUl9IMIc2hktx8IWGou92O9vbpKQYrmc9mEIdz54BLkQec6QkKWg2qs9QbsYcYEcmV9pWkt6LYNfAndtSjCVbSrHtLeLWxHeRLAzgdcfnvqnCzI3mS03NfUsYQDHxMcWIi3/KdsTtwXpGEOJh+/VYrmRVPax6EirEDVPtjjjuve6+qVQckN89MXm66C9wpFVVnWOmAXRGtdBRl/3Jce01RvYdyGfWNfW5TdCPLU2IofqVZrJR7YrRTXx57V9wZH9E0ihdkghG3X6RXRPJ/KFRus6IQYIXSUO3HNIVduaRsVMP4Cg6rksiODOIE/4VuF8LWc7zxIzNeHPbhAxCilEpYDpubiPGNY14+oDw0+Axzl9pme/1lX7iXJsWbE4vFz/V4D+HcdYYZbQr2lvMNkCkvO8zCoDok6WDU+AEx334FNlXiE8kA9eNa0sVntQkuOhQTpf0xAwaxRoMJBBRkHY8miCcWoRUL+oLv/OTvLiIN1VWb7LyTj1TeDpaNK9YDW6MrEATwLEDp6IHjRzEu6klmwyuxMKU1VW43eLdpRIAIFsOdkIsJehsxSfWsiDJakn t5HBaEIh /eY9boYA+npmw7KTkGqEgctJQPwruJXd6l6QBJ/i2pb4Cf0EnOPI47z7Kdeh8enqjEnfaq0pv++FzwYngtavvKoXGM2EsO0mLW/Ea+4KvstUpzZtfmYnlkYtjB+x2vrW5Wa2V1ii2K88vI86qcRFa9448TK2gZkpY2lfQGvgZBCV9eofsO0qMrgQRSf9FEWhKxK0wz56KFniX2rOdAYD9sSLEYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.081901, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thank you Matthew for taking a look at this! I fix both points and send a V2 patch. > This needs to be cast to an loff_t before shifting. I found that this applies to add_to_page_cache and delete_from_page_cache, too. I could fix them too, but I didn't since it will change the max value of those traces from %lu to %lld on 32 bit environments, which would be a breaking change. However, let me know if you think we should fix existing events as well.