From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D121C3064D for ; Tue, 2 Jul 2024 10:27:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97E0B6B009C; Tue, 2 Jul 2024 06:27:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92DEE6B009D; Tue, 2 Jul 2024 06:27:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F4CF6B009E; Tue, 2 Jul 2024 06:27:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 621786B009C for ; Tue, 2 Jul 2024 06:27:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0ACA1820D8 for ; Tue, 2 Jul 2024 10:27:32 +0000 (UTC) X-FDA: 82294435944.12.908F1F8 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf10.hostedemail.com (Postfix) with ESMTP id 1F69FC000E for ; Tue, 2 Jul 2024 10:27:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WofzAbOY; spf=pass (imf10.hostedemail.com: domain of takayas@chromium.org designates 209.85.208.175 as permitted sender) smtp.mailfrom=takayas@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719916038; a=rsa-sha256; cv=none; b=KnT/9N15fHpU+Fk3mLA4vdBAX/kIg2ZqgFKkndEFvYsKL0Mn4jGsMaF/LGsz7813MqM0LB CPv944YzJfZ9AO+ZFl2cvA2fz81wYbkn4iDHolfXM8yY+j/PpAS5a0q9SkWCbN9Tuzpls1 ueTvYaP3MAkFSyWE5ji/vvpFp/s7XOQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WofzAbOY; spf=pass (imf10.hostedemail.com: domain of takayas@chromium.org designates 209.85.208.175 as permitted sender) smtp.mailfrom=takayas@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719916038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KGXL9UIXbhLR/5JvNqArR0R/XDUz/ACK4RQxzl9anNE=; b=u/AUgI61HaKrUTSxK3vo28RIh9ssi7r5deFxoB97Iur5DrL3n/6vQOqIaffLhhuMnDTx6z FevHrKp8zbUE6PnhA0xpQ2FzZRhd1vmo4VbmlHMEaJXYAzhJX0EwjoxHmz6+LVrjjoz+uq Vhs8loUzjeniBiJXsUDVSS9Qmr8LfFo= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ec6635aa43so40095181fa.1 for ; Tue, 02 Jul 2024 03:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1719916048; x=1720520848; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KGXL9UIXbhLR/5JvNqArR0R/XDUz/ACK4RQxzl9anNE=; b=WofzAbOYOY+XZ0h0y9nt5ybwm5gfSu00P633tbecaWWL39b3RAhXgzqrybmGb4/3+B K25AckfK76Y5Sjn8JZE1cnC1CoiEsUwtkV/fyNEkFkq0478N5oP0G+czwQ0HjXMHW6iD /AnzFa8OTDLiJeTGwAzWUeDDOIVDb7UN0Msto= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719916048; x=1720520848; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KGXL9UIXbhLR/5JvNqArR0R/XDUz/ACK4RQxzl9anNE=; b=ks3voZK1byqMnXJx2pozWC4JxGxjLdJCoe1bSP/hAL4cVHd4lGAqhPVh+m9y3ef0Qz KluxLugj0CglAlAQCllf+R+umCMjmLKYX1v9Xd4pSencOixeIPHpbtde4d0s4Dpcu/GK m4hN45rYDK/BhjtPwXbKOLn9+e7kGOA8Fs0RyW20h1OeuA0bcWrblkM7IxagFf1DEMRn UTOEsKoMCSuW1pjP8C/SUBWZQd8SSV+nJd/9KqvFNNAJLjJJqhzCgV7h4v6NXtt4mEtQ qgfJ4xP72hbL+d7K5lr6AXIZgcuUZ0WX462HcJ7/vF9UYt6e0mIQoBu+QpM2QHfr7i1s ApFA== X-Forwarded-Encrypted: i=1; AJvYcCWk46T1rPDcpL3yhTrHMhtzkH0djxnVs2JVrezrSLE0yag/bMK5vcBezIjJSimf1GRHbqmVAY0lUukezio+Y8xJ0vE= X-Gm-Message-State: AOJu0Yw1B6MApGKl1xX722r/6kZRF4TbUw9ng63OH7aLy0C75+jp9Cjc Q3YH84e9e3e2JhLr3E+v3fY3SsMS+DlMRkIK1RPYodFOXlQ6oKxgpfWkIhKoLMKUHB9gVKlTjyn 6hIEcwgQt2yihLvILxXIqILnzB5vUY3f54uOPJl+tGGiAIGPd X-Google-Smtp-Source: AGHT+IFt9f8DTWYXKkF3t2wQ2KUJR9FCI77sv6cMg7QIh3R6KT4/CDFbLN8uqeQubI+1wZca4MimuTa7HkZzfMW2UOo= X-Received: by 2002:a2e:9ece:0:b0:2ee:594b:8b80 with SMTP id 38308e7fff4ca-2ee5e6f7a8fmr43928381fa.52.1719916048118; Tue, 02 Jul 2024 03:27:28 -0700 (PDT) MIME-Version: 1.0 References: <20240620161903.3176859-1-takayas@chromium.org> <20240626213157.e2d1b916bcb28d97620043d1@kernel.org> <20240626095812.2c5ffb72@rorschach.local.home> In-Reply-To: <20240626095812.2c5ffb72@rorschach.local.home> From: Takaya Saeki Date: Tue, 2 Jul 2024 19:27:16 +0900 Message-ID: Subject: Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault To: Steven Rostedt Cc: "Masami Hiramatsu (Google)" , Matthew Wilcox , Andrew Morton , Mathieu Desnoyers , Junichi Uekawa , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: jjzduzc8ay8awmg44idgxhgeo3qpf8qj X-Rspamd-Queue-Id: 1F69FC000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719916049-79695 X-HE-Meta: U2FsdGVkX1/Z4iacJGFctNBUFtc9NYtQKHLuuHv3n+doPo+JkkysKE6A2JjYaA3Gfc+xtVI8IC+hiJVBG8QoYOgcjFjJsfwf6u27b8gZFQQK6d/tZcU9rZQzRZpcER+5tt3TSUx1LB4vslq4tmgYB5iaWJoEGR+IqRRjUotyTMCfCJ9rdd+wz/mLxd66pa5AN8noIu3WcreX57eRFWXDDI1OPuIR+cgKhjTMwRZi7bX9V7TCTaUfsZwEvZdFzPw9r5BESCKTTx4U5VLnjx05mxlyhYMY4jzMHyxKyPc5uF148aoELTHPgR5IQHmcKMxkqaAMfyci+mQYsMdcXPIcOkcB74c1h2lkrU14HxNxyfIk88p3G092Wnm3SIoqV9BDtRGNQaFOe4Z0BCGwhOsjB7EsuOLP5/SH1Od0zlRzJTTQGeuhYRgLlmDinaaZuG+2GmjMOuMLRn2Ad6O8Gt/dGpvWbke1wGMC7c03L8beG6QWJ37lr8IdT44pNYVGJC1Jb560mSzAfMuQPeq+hd6kGzmxc4DwALc6GrearIFLWzCGBX9H5v3sYbiW0wZy/ZxP7jwXUFwhS5ZyqiYdTcx/eMnienmLUdzyb6Fg+EnOVqZ9xqBR+TId/5Fzo+/vNboW+4hYZzYBNhhheqnqFvuAgXGYB8rj/cujxJ43CQNQQjglFXU2S+t15phwv2oOibBzUEP42j89CtuwO3KKNGt8YnLbyTBFypUlurl7186m+gq4Ronivn39ms3wE6krRoBf2guy1IjMBDwl61h0okconKUUUG25Ii5KrxmY22LBogb62Z+R1vo8bk2E/wcww9ah0xImFBgnVtU8R3eamSBEBy0Vr5tx1WFH6CqVYDDz2zFBVOVweij3E+V4ZLgefcwnnFkb3YRO4KeBJjBpO1DligKokw9onir0zkHJFrjK9wWSl5OncAnv/fqetT1rlRaoMtWzgMdLPL7c1blWUR+ wVsb3QT7 tI2reGpYicJjyu90YesZ4GWILydJ/2CDKgBSKmFvjeClXBTbBWHQc6/abIEJr5F5ZtUImrBlU1ThQFhMkhI2iTGcKLJQmUIHYhmTmuP2I5ausirKUfONtVHhWEOjzL/kNQMZjPqK2zIjdARk+qY35ct/5D0YDBRH5yTaguEVd0vLGdyvjf0pR8PnI4mBZoN0AphNVXDNUR9blpFsEWlbvdF+WWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.115206, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello all, and thank you so much for the review, Steven and Masami. I'm currently considering replacing the `max_ofs` output with `length`. Please let me know your thoughts. With the current design, a memory range of an event is an inclusive range of [ofs, max_ofs + 4096]. I found the `+4096` part confusing during the ureadahead's upstreaming work. Replacing `max_ofs` with `length` makes the range specified by an event much more concise.