From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx157.postini.com [74.125.245.157]) by kanga.kvack.org (Postfix) with SMTP id DD6696B005A for ; Fri, 7 Sep 2012 04:57:18 -0400 (EDT) Received: by wibhm6 with SMTP id hm6so5899450wib.8 for ; Fri, 07 Sep 2012 01:57:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120907081718.GA31784@bbox> References: <1346832673-12512-1-git-send-email-minchan@kernel.org> <1346832673-12512-2-git-send-email-minchan@kernel.org> <20120905105611.GI11266@suse.de> <20120906053112.GA16231@bbox> <20120906082935.GN11266@suse.de> <20120906090325.GO11266@suse.de> <20120907022434.GG16231@bbox> <20120907081718.GA31784@bbox> Date: Fri, 7 Sep 2012 17:57:16 +0900 Message-ID: Subject: Re: [PATCH 2/2] mm: support MIGRATE_DISCARD From: Kyungmin Park Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Mel Gorman , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Michal Nazarewicz , Rik van Riel On 9/7/12, Minchan Kim wrote: > Hi Kyungmin, > > On Fri, Sep 07, 2012 at 04:31:17PM +0900, Kyungmin Park wrote: >> On 9/7/12, Kyungmin Park wrote: >> > Hi Minchan, >> > >> > I tested Mel patch again with ClearPageActive(page). but after some >> > testing, it's stall and can't return from >> > reclaim_clean_pages_from_list(&cc.migratepages). >> > >> > Maybe it's related with unmap feature from yours? >> > stall is not happened from your codes until now. >> > >> > I'll test it more and report any issue if happened. >> Updated. it's hang also. there are other issues. > > It was silly mistake in my patch and I suspect it fixes your issue > because I guess you already tried below patch when you compiled and saw > warning message. > Anyway, if you see hang still after applying below patch, > please enable CONFIG_DEBUG_VM and retest, if you find something, report it. > I hope CONFIG_DEBUG_VM catch something. > > Thanks. > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6668115..51d3f66 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5705,7 +5705,7 @@ static int __alloc_contig_migrate_range(unsigned long > start, unsigned > break; > } > > - reclaim_clean_pages_from_list(&cc.migratepages, cc.zone); > + reclaim_clean_pages_from_list(cc.zone, &cc.migratepages); Of course, I tested it after local fix. and got the results as above. Thank you, Kyungmin Park > ret = migrate_pages(&cc.migratepages, > __alloc_contig_migrate_alloc, > (END) > > > -- > Kind regards, > Minchan Kim > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org