From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B3AC52D7C for ; Thu, 15 Aug 2024 12:35:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95FDD6B00B8; Thu, 15 Aug 2024 08:35:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 933A26B00CE; Thu, 15 Aug 2024 08:35:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FCB16B00BC; Thu, 15 Aug 2024 08:35:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 622A96B00D9 for ; Thu, 15 Aug 2024 08:35:08 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CFFC4160733 for ; Thu, 15 Aug 2024 12:35:07 +0000 (UTC) X-FDA: 82454424654.19.8D13DB5 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf27.hostedemail.com (Postfix) with ESMTP id D1EC94000E for ; Thu, 15 Aug 2024 12:35:05 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mnkv9KwM; spf=pass (imf27.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723725234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dGIDF+aYZNgQXSDZe/HjaDy7QWphoJnZtou4CagSDHc=; b=1/AtKYHsDf21TQsxky280/dMoex7l2jlqzaK6l9noiLHN7pwKrGMYq6Fui6NprjxNvkjrj x/uuOU3Mu1FIHxgUDP3YAQsyUV7It6ieMddG/Vgb/orS1stOKYjA/HyliLNLidhEqK0ACm JLlr8XOwaNQkW1H2xy+4H9QP24g1rzc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723725234; a=rsa-sha256; cv=none; b=DIPAkbMtZG5kvMKE3vjbpiK+ZWZMXti5Aby7zXeX3y+pSZ1mppx/4q7z6qQ1lLuMSNEq8y uIz1ZHFE9yYm4u41wTB390uHv6Ob+db4mgt78ULZxRVh1ElfDWX5CVnMUSLF2P+Iqsz4K5 5lOQGZwcb0ZX12DxOvG6/od+fX7PgSI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mnkv9KwM; spf=pass (imf27.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-37189d8e637so345114f8f.3 for ; Thu, 15 Aug 2024 05:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723725304; x=1724330104; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dGIDF+aYZNgQXSDZe/HjaDy7QWphoJnZtou4CagSDHc=; b=mnkv9KwMcrL0OWAWHa2yzDvt1OuMEBVXlvQUF9AR71mjq+EZE2gyiY1YRM6PlTn2tf FdcaCWU9r8uEIZ1nTI+uCNQSTz2LD/iG/FLTRAFFxZ7Cgx6Xsth60Oupl3eh8iUZ7fqn lHuoSuHMideixIvM+McE0dmEQW0zo97CfrdKZkjFHAhhFodl2xesGr6w91bnjzYRSoxo GwhYKPNV3jRQGd5u6qxF73y3LEDPIkHLLFtLfPzJRZ55hqbduHjfrFbupyL8RHbCbtOY D4oyA7MyzqkncJGc83ladxXEd1zjQUE6PrI8zPWRn15ptwsYT4BJPhDst9eimwSFrlZh uWrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723725304; x=1724330104; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dGIDF+aYZNgQXSDZe/HjaDy7QWphoJnZtou4CagSDHc=; b=vMUE4vXFGSxh+q7BSALb6OWus+HGV7+yzar7JrfB5atKh2OzckokUNitfFQ/GM6xSf FaQY0Wm/pjd0kfXQRvyurrXPf8JbaIeL+GWcw9sNa8poXU0OWU1yZj/sJ72d7xDBWVKX ZlTPr6XT9HPfD7Yjj/i79BCtvFxm6fvzY2Aco9q7sfMaqtBCz3tajGAgJxYM6U2d9Jbp rgvqK9TJ0RkNafL4V0VggNPfoxKULx8PLDviHCYbG6ArxmkU9ymx20hwUkyFhW4ISWt/ DIWJ2ROA4Te2u96GBU8gnmWp3cPnUp79v0tIzzDgSGfoyOI+b2Gp4AVAnff1gR+I/rPf 71Cg== X-Forwarded-Encrypted: i=1; AJvYcCV931VRFNkItEAK0PY7qQ5j3BETuGjcN3KQ3vi6qaHmwn1/RXBRiTzEJw1yg43+qQucoPzys1c3MHJ8oGkJCdZiDy4= X-Gm-Message-State: AOJu0YwmFKeRUdEhp3fc8rKGDcbOkBK4PULS0MQHxEwdgdzPXwpsjr4J 053oIrSrnY3cSrJc16mVbgXtAzo6C790wydHqk35/6x/7aDuDllnPO+oqhuv5gTPsWo7YQbuYPg Q7fCEOw/JL8oXQLiOivSJpblBNkdiRG8KEL13 X-Google-Smtp-Source: AGHT+IEAwSQtJNHUdRPQigq7uRt4SoNYYsQGSkn4XDCbOAfrLnsv+ih0U8e7xn81tFFxQq6aOGcjZ+3/+n3gowswxD8= X-Received: by 2002:a5d:5d84:0:b0:371:7e73:eb43 with SMTP id ffacd0b85a97d-3717e73ec6emr2109262f8f.42.1723725304072; Thu, 15 Aug 2024 05:35:04 -0700 (PDT) MIME-Version: 1.0 References: <20240812182355.11641-1-dakr@kernel.org> In-Reply-To: From: Alice Ryhl Date: Thu, 15 Aug 2024 14:34:50 +0200 Message-ID: Subject: Re: [PATCH v5 00/26] Generic `Allocator` support for Rust To: Danilo Krummrich Cc: Boqun Feng , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D1EC94000E X-Stat-Signature: nwnu17ndita6hazh7bu1yq47pb6xbc3r X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723725305-241148 X-HE-Meta: U2FsdGVkX1+6eIetJleXZsjKK6MkMdtIdlqgXKWE38zWwpWEmXwWUaFUWjFjjUmAT4IyMl5q1JVBx+ACW86kWxRAuJCZqBRD/uGy2mokilM5mcJCSUbT7SlQUy0PafaMUmM3uJjm13v/OtSg/DF1UoqbQc7prSpdPka34aEtmpey/YVT0EVXixNXYOQv0HckViPxAJ6X7UY0QNoqaXpc6tJCVrh7aQQjAmHAtcrCovL0Yb5VPy8fSIgNFXQhLJkQpPAwIuy2zD9qpUF8oSWY1mpZ71POxs6ZZAWI/Ua51GAa6n7zGweAb+0W9mcU83aZKbAG43D9/vEmD55LYEWct05eIR4bbJBULK0iIxFojG9LZnosO/aa3zvdd/L6k9/1j7brMVOFHQh5qE6k1FOr2qO3IrTAK8951C8pVb3TL6Vq5fClfLucOmZeU+xgx+cxSb2flfSLZ9wZKCCKb9CZdE4J132skm6/gyhgWLY1E+n/2LpvM1YhdlA9bO94Vk721Kt2IErWIQkSs15uquqSpuCR9kD4AmxksJhhJ8ocaLxX29mqtdbarQy/pXimt6QZW6RYNhJVFpHlhpW+gUb8RqqP+1EUhbcdJgGE67RGT1tMmJC2r5dLzaP8PwmtFfPlCU8ToAIzEcRS3DCyHpyzPFoEBKiLJ0Cf72oDC9bacGNMgOwtjLILLuAQ0HZo/+3El9WYLCInzheq1MdyqSHRhJQdVzhsIgMRy1TL/lzrxtY/GFTQVCvw0zGMMYbhTt9Fm0Lrh01WBfjx3IsZuz1hHw/C+0l4zhd3LKqAxaqPinq/zKMfiWdPI04rB5c7cYKYEVYie75aLXQA/v+R/ubR/SSJ8QfiflKzVGW1igQst2igsP/02es6QYjyTwUA7K7Xwu2pGoqugxEo/42VJvwrMMAfFp0DOOIMXmH3ZW4/aAisNpVxMzkDmbD+e+qakfeTPK8Rb2PbP1c5CBsAqd9 5V+R61Kh 3uOlBen1M5zhJ+1f+im4494yGl7TSEpFzxN+6omshaL7bk/1wrYuYH23goBTC+Gftrd7PNhFsABlvizts1ATpAfZbhOoA6ero4z+SB1MBtVCQThroXFG+U7TPSFeFqxw2z9EXFx1cnxXfXeKCJrvV1OiSMC5lqx43jzhxj8q6neOVsfMDtXgybBj6fJU2EgMTrPc21KP1YQKw23vV/7reOJ3mw0+kaHw6kSAPCUtCiP7/iOHAU+lmuONHR41pwF/xy/ERUgxWRGHZwGpmToMLLGqw6NwbR8pa6R+WtZYesTgi2UQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.172073, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 2:33=E2=80=AFPM Danilo Krummrich = wrote: > > On Thu, Aug 15, 2024 at 11:20:32AM +0200, Alice Ryhl wrote: > > On Thu, Aug 15, 2024 at 4:52=E2=80=AFAM Danilo Krummrich wrote: > > > > > > On Wed, Aug 14, 2024 at 12:32:15PM -0700, Boqun Feng wrote: > > > > Hi Danilo, > > > > > > > > I'm trying to put your series on rust-dev, but I hit a few conflict= s due > > > > to the conflict with `Box::drop_contents`, which has been in rust-d= ev > > > > for a while. And the conflict is not that trivial for me to resolve= . > > > > So just a head-up, that's a requirement for me to put it on rust-de= v for > > > > more tests from my end ;-) > > > > > > I rebased everything and you can fetch them from [1]. > > > > > > I resolved the following conflicts: > > > > > > - for `Box`, implement > > > - `drop_contents` > > > - `manually_drop_contents` [2] > > > > Not sure I like this name. It sounds like something that runs the > > destructor, but it does the exact opposite. > > I thought it kinda makes sense, since it's analogous to `ManuallyDrop::ne= w`. > > What about `Box::forget_contents` instead? One option is `into_manually_drop`. This uses the convention of using the `into_*` prefix for conversions that take ownership of the original value. Alice