From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7310CC3DA7F for ; Thu, 15 Aug 2024 09:20:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AAE76B00B7; Thu, 15 Aug 2024 05:20:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05ACF6B00B8; Thu, 15 Aug 2024 05:20:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8B506B00B9; Thu, 15 Aug 2024 05:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C6A686B00B7 for ; Thu, 15 Aug 2024 05:20:47 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 77ECF141004 for ; Thu, 15 Aug 2024 09:20:47 +0000 (UTC) X-FDA: 82453934934.20.6193B1B Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf22.hostedemail.com (Postfix) with ESMTP id A7E02C0022 for ; Thu, 15 Aug 2024 09:20:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vLtKb0aQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723713564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=80zm8jzgImQ04ZpZHXIv+bJT/2HKQyCzED5vbg8c5F4=; b=YNCf/8yDHchyN90Quj5Htv2tyZ/fzhONHtzFdOlS4SkTZSA32yPSQOVr4uGSCVeTzhNp6+ BGUBXTkxk5HMvqegRAOaQgOVkMxrpPwF7GIlM/b08+ohhdBTiMEkS+Aul4qM1XtCDz/3BO FSkV9X+fb2nLe2QzvUiWrrV6MkWPz5k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723713564; a=rsa-sha256; cv=none; b=M8f5cDVP5xx/lxT3wSy90o1QOxoB7yENzKGxMpqmg6D/ojWwvJCZvwSuehZQBj5hnJMNLi Ao7icF+c0rmPM1PsRTgcJwmTV41g4joSODF4ajc7EftNXeO9Nm26HwHrclHSGVXcCTbqSk CHMfp6IxClL1grZAy63gMpiBvZB8gTQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vLtKb0aQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-428e0d18666so4162585e9.3 for ; Thu, 15 Aug 2024 02:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723713644; x=1724318444; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=80zm8jzgImQ04ZpZHXIv+bJT/2HKQyCzED5vbg8c5F4=; b=vLtKb0aQY11KcWee7r7JOYp8qGqRr0HHa1U3t9CQxMY+CfG+53SCO3qqik0IGZXVhI boGxZ2bOct7Y5SIwsumXWrzCzWYhB1pPmBHQPG0WeL8/l58sujAx5X/8GnCBYFPCrraU KsHCd/L0xSwE1+uH5wntl2Kq0FvtI+d59jypovvy7ThqIdUJXaIMr4lC9HZPjeWygjRU mmggZu9re1fBwiO5GSiOdu7edWgAZ1i+pTqEtOCBuUoghi+xtkHPYW0o+rovHZHQchf6 mtK/tMXdqGU34ZlWJ+erdLcuESCscpIO+E/jSPy9fmM2rZn6gRfH3PDtbY4RtZ5dT6Ce F6FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723713644; x=1724318444; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=80zm8jzgImQ04ZpZHXIv+bJT/2HKQyCzED5vbg8c5F4=; b=JUWA00DiEnC4WJHg+0gLQROcsWvX63WANEgi4VNxP8CNbsIAHtL3bAHb8yz6ENNwNI 6XON618rLLOme7AQWc0Ksk8GBAsJ25nlttygeTxtIkcqzRlBpipq8M/BsSG/eNFJQAeu nsbvGPXVjwZoX/Y43O0v5djPwfR2FUgjLKG1YeOQ7efOCPB8Q+urzKqSDsC1KuDiSF5a veMT1kpV9bIBzSkyNwksJGBfq0PTloZWnPMWS66LkyXMwnA4MxPU6JPXbp2coCvPFN37 5dhEZX1G29cBuq8Rsg4pFecbsHFBx7j9bnG/rcMMX437UFmhOq8cSsEQ0yXVs+m5z7MN ghIw== X-Forwarded-Encrypted: i=1; AJvYcCVFIEs9/f6rxqcWeoWFUCX5STiY9W6qO0SPnNPNTu8fad+9AD/jW9fL5c2I+lMqty4C/aFhXiytDSYQ9qLLHPM7xeo= X-Gm-Message-State: AOJu0YzsYhznyNjjq+P1UekAc3QheOGGpr4Gb8sUTBXjD48UPZovofo0 A3CeygP+Wbi86I7VBInAuxzaT8j7OXCJg70Xp9NJUPp+CR2NpnGSdH8RM27eY4C0cWJAHh6xGN9 VIXjphRHu6l9otuDmiwB5p6c3dux65kVTAedi X-Google-Smtp-Source: AGHT+IH7lkn/aRzWqScZW92BYvziPxjfQGa2Ww0aXoS67wvigoKomhvmcMOLmj0n1Ikrp2fMRD48McZ45QoGO5RKsGU= X-Received: by 2002:a05:600c:3542:b0:426:5269:1a50 with SMTP id 5b1f17b1804b1-429dd2364bamr32348045e9.11.1723713643657; Thu, 15 Aug 2024 02:20:43 -0700 (PDT) MIME-Version: 1.0 References: <20240812182355.11641-1-dakr@kernel.org> In-Reply-To: From: Alice Ryhl Date: Thu, 15 Aug 2024 11:20:32 +0200 Message-ID: Subject: Re: [PATCH v5 00/26] Generic `Allocator` support for Rust To: Danilo Krummrich Cc: Boqun Feng , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A7E02C0022 X-Stat-Signature: 1czaeo641i18eebadtsutkxux1wsii9d X-Rspam-User: X-HE-Tag: 1723713645-704449 X-HE-Meta: U2FsdGVkX1+AkhCA8M1qMoijQliUXdyLbhDJeS5D1G4UN0gLyQmrW7dkS6V5JrCVI++i8YqvfwO3iIt8Sc1VKSe0UdHNFLJ1T0iWd1yVg/E92wAFSSSITft/wRjIY+nInTPEwL38TEg0huy6zwVvMHq/jP8o3EWbUljveue77Su31PUcoTzK81tpfsM45oR93gVNA7ABg7EGh6qse2UoZ3wMHiwdo/7kwK2axC/33EdSr2TjDCZrWnhbGYy8bvxYyVpQEoQvossLj+HbFH/2wzRov7CTmDOxEzOMgBlJLxfYntj0UbSqoqfM5IERSGGHik+6zZ5DFJZRy5VF/4b786yDuoVNnlqS/fVf7ByPg5v7yN9gkBzYHemVNX1i4YONr/2qMPBkXm0vum3s+iimT8Zs7a3WLIGjoS/h9rYAvotyoJ33v+UeCxX8MjL6RvP1cispkY73tSoIhSgeZT3nVPlQSsdgI4dliBBsUf8kW9VgurP02IL4LxQMxa0N4HTNjvb/fvgzmLKS6vF0SGE+amxWHUbwAUADi98uVq/FTFE91BGGYBNyIhdSKEJg1YskHI3Yf815d9UlfA7ZQkWztvltJ2Anx2zpptZKk6kHmb+4gu8G/9Wqs3EVwp5KoxIVAYCZL0AxC707ml+z3Qc3k5d1cp4LpKvbHHrQDo8JANqEOZYXW5gUbI0H3Lismk/n1LzucI5LcLP/UWGxHtmbjOW0mL2EgkTUiZG29ddAaeP++TAFL47hYKj1rpwxI0UaBEXPxPz6h8N/icqu9wTlycwMLFS4oYCQrmQ1lLao4a+fjaKk3LhiYV5Cx6DCHmWPqFYPoOV2Fr9kGkNy2Xpmq0y0X0uyr4d6OPqd9Wr11IxDuyge4I5jjI1eX6y++W+ISkipkK8et8dbmaA+NysUR88ZZTCOT8x4Xj+8MCN9i6b8OQP5tlEFS41apv6ad1JFiViP2tAjjpSVW03xb0i wQ8u2e/M bYvEGrYpU/YJRnLCd380MzdPqhWtAiM+j93ZR+1piVK/eSe/a5bJxkdCZCyVHid0rTi0nQXw7RZ5vSysxc8+NEc5fqThzKo2wcIje7zesmGVLIplWt5gEGW3r0EIFHzZRL0crH574DB19YkuP2jAzEU17fnFZ68qtQfJM/LeC+8s4K/Vfos2nNrMavp3GsMmRq1huIcS3PpbQL90xTrXDJRwsyTCJSxAcpGvjvB7kKxONgmdyEUds9mxeUFsUbvK1BalOEEJ6YNf8TGQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.228257, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 4:52=E2=80=AFAM Danilo Krummrich = wrote: > > On Wed, Aug 14, 2024 at 12:32:15PM -0700, Boqun Feng wrote: > > Hi Danilo, > > > > I'm trying to put your series on rust-dev, but I hit a few conflicts du= e > > to the conflict with `Box::drop_contents`, which has been in rust-dev > > for a while. And the conflict is not that trivial for me to resolve. > > So just a head-up, that's a requirement for me to put it on rust-dev fo= r > > more tests from my end ;-) > > I rebased everything and you can fetch them from [1]. > > I resolved the following conflicts: > > - for `Box`, implement > - `drop_contents` > - `manually_drop_contents` [2] Not sure I like this name. It sounds like something that runs the destructor, but it does the exact opposite. > - ``move_out` [2] > - `BorrowedMut` for `ForeignOwnable` for `Box` and `Pin>` > - `InPlaceWrite` and updated `InPlaceInit` > - for `RBTreeNode`, make use of `Box::move_out` to replace the original > implementation partially moving out of `Box` > > @Alice: Please have a look at the changes for `RBTreeNode`. Maybe it's al= so > worth having them in a separate patch. RBTree changes LGTM. Alice