From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B563AC02192 for ; Mon, 3 Feb 2025 09:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A4B128000E; Mon, 3 Feb 2025 04:09:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4549E280002; Mon, 3 Feb 2025 04:09:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D0B128000E; Mon, 3 Feb 2025 04:09:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 08244280002 for ; Mon, 3 Feb 2025 04:09:00 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B50A449654 for ; Mon, 3 Feb 2025 09:08:59 +0000 (UTC) X-FDA: 83078058798.23.2DDDC67 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf12.hostedemail.com (Postfix) with ESMTP id C709740006 for ; Mon, 3 Feb 2025 09:08:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1QAH69oD; spf=pass (imf12.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738573737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RtOwM5RxJfd+VfcKZGXtlLQFSXd03HQ8e4rhtGXZjtM=; b=sSTLJrxkEq/Q2zhVu4OZKm+5mFKpzrBtxkdFQev41OrVud4k1dneMmgnTs4IFdJLvmBFBK KwztPuE1GQvka/oq7retyWr3gKdD6GkxFfhq5PH9HXpAsIki5reuPUX2C5Nwz+fVwq9GK4 Q9LV/TN/Vu1SBulNKG+GjlPD0GuY4N8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1QAH69oD; spf=pass (imf12.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738573737; a=rsa-sha256; cv=none; b=Gj0wbRKxWLku1sXDZY+vfI5idqRovJqB8bI870fFxUvJop+ChTrbRZAjbongu/YU73XAx2 wj6SfEmxF+DzKnF823rUBNaYhrSevyUvrrfKjkvK7w9HA7wjY2RP7VDTF91GGmNKe1RMw5 s7FICR3dKNG9aXMhF1h4EAoz9FuSbQ0= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4363ae65100so47451275e9.0 for ; Mon, 03 Feb 2025 01:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738573736; x=1739178536; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RtOwM5RxJfd+VfcKZGXtlLQFSXd03HQ8e4rhtGXZjtM=; b=1QAH69oDa0inaRrnyzg5aEj+KkXiQxrV16ea3oPZcyD6wsQ2ooOtdGtR9os6SM7iBO caSlvFN+pSxuHyNTwzlWmf/rPal2Lg6Q+bdORW0L5urn46DEAqSp3W4BYyVcgWoyRLTE DDkfULP3QIAnZRl5fmmaezZ+BszhSAkMAt4+zEYf3zxhKw/8vsChyRw8Klhg8kPi88NA BvA0+Xf8YJH9Py+5jQNe9q/tvqgvo24AKAkPB1/HnMLQ1jsxIiNwuMFG+8H2BKxtysPs rn9nJ0qB8Tu2QJBrSituLN2xteVeYDIyRABwoCMHBrCCefw6c+dUe4HaG9dlb+8OKrlO /Mhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738573736; x=1739178536; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RtOwM5RxJfd+VfcKZGXtlLQFSXd03HQ8e4rhtGXZjtM=; b=jJ0qe2T9Pwr7CFqtyq3N37qMXHQBxO+nU6C3B+rQC0BTxhFxSoKvxkmo0a9cw9xo2h 8WXGuJ6DaKaWDUSLlWmNfTpOwE10C9MjHbmBbI2WcgT88frQ9i727DrxNOYlv05Zc+I2 +/DYceBNr4+2yTXu0luzEeqM6I9cn1K9K9sR7oFu46vA7UjSaOheFqllbjCFCIzcxDwK VRByJH+CwTtlctcsQt8ZJSnpO6AWWKUWCXTVfs3fj7OzWhZwf6djMKeLzIO11BwTTYVN zs+gLtFonVZAHKPxxDunyU822qem35BLvrfBMkpR3o8sb3kZ27ZFft97F2hqDmQ4yaXd ZVww== X-Forwarded-Encrypted: i=1; AJvYcCWNyOGC9Z9fx6qiVn9X2WpCPz2VLOgYUEdYTMelMYUgRXlCxhSYWqvmtypyHIHO1bL/0/wX3ZJ4UQ==@kvack.org X-Gm-Message-State: AOJu0YwzM3do4SfFPGTru/OmWDz002pzD1iktSspGsAwqeXS+gdPt26G 0rCklTkD7q7IUXifdpqM4N0WVO/6xpoxM2ZEnvTDdy6ZEN56fZcCZuVR4kaSPByqobS54Otwi60 +naFfRXdNtsvoBipgPU9x0vzNkxWqspyHSW64 X-Gm-Gg: ASbGnctESviwYJzbIBC37G437koKA+AAM5UcJOvnERKT5TeYvyfhJajSnZgS+dmV6ln UkIevxnBn5HIMw1zS3LvqxUBqnjGXAgtEOpjifjvC+VvsWGJw3NrsOrrMYqciz2dYN/ZjwBjNJE u0i8jlBIoVfnWjbb8trLifOm47 X-Google-Smtp-Source: AGHT+IFbq1pWVjjFTT5eK9hOL6FRx5b2gIclK01nWaF+0UuNV0XQVQD1CBTLjwH7htojNlMdbttCQobb6NaNzGYfeNk= X-Received: by 2002:a5d:588f:0:b0:386:375a:8322 with SMTP id ffacd0b85a97d-38c519506eamr20704188f8f.13.1738573736075; Mon, 03 Feb 2025 01:08:56 -0800 (PST) MIME-Version: 1.0 References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <20250202-rust-page-v1-6-e3170d7fe55e@asahilina.net> In-Reply-To: <20250202-rust-page-v1-6-e3170d7fe55e@asahilina.net> From: Alice Ryhl Date: Mon, 3 Feb 2025 10:08:44 +0100 X-Gm-Features: AWEUYZlZbKxfLpJhhJPVmBfowDaLOLNb2zkL0fALAziRhJs2A8Tey8gfRdFIvFA Message-ID: Subject: Re: [PATCH 6/6] rust: page: Make Page::as_ptr() pub(crate) To: Asahi Lina Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Jann Horn , Matthew Wilcox , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C709740006 X-Stat-Signature: xwjxms43zhbs6mwzjjhtwij3ew8ouqmn X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738573737-657840 X-HE-Meta: U2FsdGVkX18X3npWBp78nsCvGb+NIMPpu1XqgHWilF950WMtYoQG/9h6tKt1/uhVG1IcQ5GjVt7+KKQd8CH538uarYNQZytxzvhgqPgTQQEJDDp+U2D1cqZ9pZB9yNLc5oVqRCVNW1EGsLHSOeuuN4D2rjIgWvX6I0XEWfiosdX6qfZeN9M/VhcI8+w4bjzx+46t4Us2GoKLtFTist4dcqowWsnzDUkYhXQwon0eHQ1J4P+Cdq5o+fMLx93LkeSTMu3SaCAnTYQhRKK0OXml0C46N4/VWI03lSzYXVRNMeNiPbKyrECcRzoFc0KoctN5fg39XefuH4e70TC+xJYyUBJe/kx5sj+7/LX5NtY4gxjem5DoaflD+n4lYMSh5X4DrDGWMuP8wY3nIgspKhz5IqHDiWG6Az4i4645qR4q0X2ZZguXZsG575HrZzHdymRBRDSbwjPNsWvLr9wZHJPH4zyfCV+iVL4IGWEWKyhY6Z1EcKl8omtX5dsIawmpAoSU1HlR/Hv+GUgiOzNUWcgmv7XfiQUdX4t3eRkMLxr8H2Oio+f6GJxBADcTFq3A3daYAscivsQ+1YunJunwfdthqtnWvMJ0pGylwGJY6YGmF3BvA9W/lbirpHc4Mt9cgOqZ92RaOmNCRyD+EgXCJ6dqnrQpmsK2WW3Ulf4XE6m4bcx+BhpBvxl2fSvww9+O0c0eA3N/REMzBBavsCRziesQh2T9YLY+UJNDplJt3nBgycl1Twk6LJZ+lhkZYIvDZYoMqocTSr6WiI6NbdSOMj4qa3qGz4pBBs37hKk0EDHmb3VEDfhXAEouQt2djdlAR3P57l6sbBDb/b/RodlkBcL2fClINqElKLsOyasujFZHNB+Z5v8nSDEZloEKe/z1QUuEfDCpNl7FgWXP75J7bvAOMHQFMalnXyNDLljT2mjteGFIxBvhsKYt6bRz3CLzezuzF0rbU8q94UNIdOGznlV QSuq60SI vkufqfpc+3Gcv2TS/IYikQDh/SHq9vx+RB8qsGUgQmi2z2de7NB5gSX6OjcvCcEbdwz7QvS8iFFzwIhCP2ZZhhTRsL9oqaYXpjsmZLWv8xN1VkK8rlkuyVZ8mifbBgxPrqUjn0dV84hGkHHNW/SGpjz+W8ZWIKaOnORraxZU0Czbbar7oMPH/FuNNclTeI+JxefSJPFWfA5f/hyP1PoUKnWL7TS1mQt6p/Jigkulqa6l/aWp7rwTmbniKtGXIyVZHKjiRSuZysr5dYH0+zG+haQhP6Qgz0JEQJtmNGKH7DDipY2EsNxhcy8WeOJDla50PjmtT+f93oU7Rn+S+ennX7llZgNieoD64WE27C4OMnBW20blSc/zekJeaJ6GEuu1+DwiCyNV2LH875tc= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 2, 2025 at 2:06=E2=80=AFPM Asahi Lina wrot= e: > > There's no good reason for drivers to need access to the raw `struct > page` pointer, since that should be handled by Rust abstractions. Make > this method pub(crate) so it is only visible to the kernel crate. > > Signed-off-by: Asahi Lina The Rust Binder driver has a C component, so it needs various as_ptr() methods to be public. Alice