From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF13C3DA4A for ; Fri, 2 Aug 2024 07:32:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD9566B0085; Fri, 2 Aug 2024 03:32:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C89226B0088; Fri, 2 Aug 2024 03:32:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B50C46B0089; Fri, 2 Aug 2024 03:32:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 924E76B0085 for ; Fri, 2 Aug 2024 03:32:52 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F11E7160ABE for ; Fri, 2 Aug 2024 07:32:51 +0000 (UTC) X-FDA: 82406488542.21.07357A3 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 244D6140010 for ; Fri, 2 Aug 2024 07:32:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K7Ykjbsv; spf=pass (imf09.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722583924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WQnIf0ueFkYF1XhpqiJ9sQBTc6MnrP0aayXu2YYdYWs=; b=fMf5VL/2dwh0AVHNaORlAjMxdOnW/AfPF36z0+u4aZ3QGcsQ2oHwYTsFLWyCXbMiFhXUaR 9rubZn9aQqq2k8O49/XspEx6uDHO6vtVNRbNvdrUvcLmtk8I/ioOJfG/ngWK+SSW4/rEXI 0OWGiLlyzGN0++vHMJW7u11Og4zcWhM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K7Ykjbsv; spf=pass (imf09.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722583924; a=rsa-sha256; cv=none; b=ETAwnOEBV4YvhPFbvdbtM5ZKtvEcC2df+9IlKH8RLD8evwdCED5fklWac3SysMVSe91dAL yJlB3fM+FgJEeaA+eRbEwxgV4A7PGa50jUA/Vh6DwOhlGpfggkAPaE3Gdi5ukbUUfWzgjs QAnqXVJUOCVGabsVMcpE1LvdU1O+7GU= Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-368584f9e36so3851132f8f.2 for ; Fri, 02 Aug 2024 00:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722583968; x=1723188768; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WQnIf0ueFkYF1XhpqiJ9sQBTc6MnrP0aayXu2YYdYWs=; b=K7YkjbsvX99a/KNm1wCrwie8Aoz1VJjsZHq57SHQvTOmVIp4Jx/IIwnqnuvXCBFMu4 VYz3mzO+toMkaC7GShfirOgAApLHClOUoI1h+4LH8K0k3ryl5m8lpVQlxV/0rK4GO5ZE V5krR7+ey2g77bTSGgAhrqky96Y3clSRp+ilVT96hPOu00U9ktLb97dEXXsLJLl9RDs/ I4SJOkIK5W9aHqPt6y3C8hz74zfh1nkQCf9qSD+2fnw7U38xj3HbQMLOkzXTuXv3e8Al YMBZWQPGW6hXI7UfB7Z4Q+zwA6dIOu0pQr5ANAwET9wsc/728OFFPRMmqlHO7Vk9YbH/ gqng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722583968; x=1723188768; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WQnIf0ueFkYF1XhpqiJ9sQBTc6MnrP0aayXu2YYdYWs=; b=aHXUpNGM5k/e+ZkrrquLIOnzXu2fZePFZxn/sx2Futuc+/WprfIPj76vc9iS/VQx/R twpdilZJKRJYZpyoZrJVDadHAObmEA56SgY33rOz4pvA5RsTIzQhNr6ewveKSBHxIgtA ejsuv8UwMLoGltNkPFs8VMz5OH69JIC0xHFoqYca0theSSBxt7fq8eU5eMfrtOaPt0tT y45cJI8mUj9YOk4+VlLkxauXTAJw/yhq/c7Us22Lb9BCQh4wQapZSIZiZeCmS2k7f5vK AErjd5LWyKdx9MYcLlOB56v9gSVYCaXKMXknt8j0Jn6E2Hj0f2pKJSO5km3ezysKFcon W46w== X-Forwarded-Encrypted: i=1; AJvYcCVUMQ30V2vIz11/ZjxiWcmsRBQNIbzG1S9mDnZXxvS4MvFu+7aIIksE6kCoUfLWFqq6QhHFHML/sMwtdC/pKI+u+bI= X-Gm-Message-State: AOJu0YyJbAgmjx8S3KpzsgYUH5WHNP2FmSS/qZ6RGEKPPYWVhg7z7Nj0 4v58//EuukwJn1DZ0tI5D7F25xCnp1n8+ybwvm+yTJbLSq9WNIGe6xn3xQj/ynIzP5GXAgIvpcT QqN3mkpV+828if8v3qmDVanMH4Z4BcuEpqLbl X-Google-Smtp-Source: AGHT+IE+7pgvDLTDQLIF46tLw/dZy4324VcvctZdCzjB81g57GdEwK+6Bpx7ukgJy1JFDgrhal60MeO6nhwqSsFQ42Y= X-Received: by 2002:adf:f283:0:b0:368:584f:9e08 with SMTP id ffacd0b85a97d-36bbc0cc53cmr1654013f8f.22.1722583968125; Fri, 02 Aug 2024 00:32:48 -0700 (PDT) MIME-Version: 1.0 References: <20240801-vma-v3-1-db6c1c0afda9@google.com> <82e4816c-cada-46f3-bebf-882ae8ded118@proton.me> In-Reply-To: <82e4816c-cada-46f3-bebf-882ae8ded118@proton.me> From: Alice Ryhl Date: Fri, 2 Aug 2024 09:32:35 +0200 Message-ID: Subject: Re: [PATCH v3] rust: mm: add abstractions for mm_struct and vm_area_struct To: Benno Lossin Cc: Miguel Ojeda , Andrew Morton , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Matthew Wilcox , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: d7dci7dpcyps8cq9idtq5q1r7phnxbzm X-Rspam-User: X-Rspamd-Queue-Id: 244D6140010 X-Rspamd-Server: rspam02 X-HE-Tag: 1722583969-454708 X-HE-Meta: U2FsdGVkX18EWq0HraTJ2S+/xkWqZF7rQ2WORuYSRECUtdNXaWFyNSjf3ygKPrzSZ/ECZhEqyFGLQco8U0zgD5aZKBh8cc/TBVpEsvGhr8BAQS7slaIX3T3+j3dvgGd1DFL1n5mZS4Zjq3oGRTF9RLf1UEOOsn7E1gdsTdph0Ei78/LAGO2vBeNOe1TcfH8WcDSpWD8RbLY+OC1TZggVUyTJpM+swGCKvZ4IO6mL5d8jikcWzWSD4pTyaUhF/de3JzUm1E+RvstnumJQpIQ6O7v9mvxkCOZVkLAvbunGBNcp1szsWqeDL91ikwgzJYx8dxwXAbRW1ffS5a/k8EfEq79DXwj+XrNGLGdmfThG21Vl568bTbF8sWC7+bRe3eznQGHtaQl6HM3ZJ5iZi2UrcbguDwf4clVMdQLI4eOwrVhyRfzkBZyIUjE7+p46fTsiSzgy7NHKj/swmKDTtPbgKdI111hH/ioWS4ZO/cS/BaV2cQeQJJ/FapI3gTFEm27RpJECfj23+9/gBwN9C1SR24JnRRwGjtbVNyNo0iqKyfowW3icHREdNSREXjyUHDEra/vWiqULZWcctgIHNotAcsmfT8aIQuK66akn9GqYLrug8bCEAUeTPSrsqTfqqrzu6yuycV9chsFdxP9dNtexROsOnkbxzL84XJLqeZJj43TN5QB24RPAMiSQIigWx20umQogESQfREDstqzU0OZizcVUfOa7mB6sAeYSMqkbkaHXXgOQbHZZSshBxnEaRfkGdPoJ7G5F5FUHTj68ZWUheCdUDZp0bBfCeqf/kJsNrIeKARKwVgkk4YxBJk3LmFPngMsfrDEVmgkTg49kotc0RoXSKnLt/T0a65da5YZwh9Eue0eP9zPH1LRXD2HPRCuWtX3cvm5vY8G+PLj4QZmziZPYzAP/2ogUJDEwsKglSO9aR/kOepe4Mk4/cMQDMW4NAsR90iH1EsBU1duy2k6 h+9OD/bC YWjYK62icprW3UgVJwiomKzNigaXtLT9FwOsQjoJ4GyYpfCqsqkWqkes44A1mmQ4RecU4DI4AGUtFrwknsL/PEfz3/QFOEyAeFi8J8SqsVQ0tKLK7m5CQZg+3PGiswu3NND/C+e7QsbvZwcKAH5GMIK6B2JlNKR+J4gT9pxrg4AoJ7GNFm8fl6/KQfvbVYtZEmhw3XacYwkIwQtIRPBTRmFt9qHdskhxdNDf1lmMeIonWZdNPcdL+lOIRv18+eKXE+ieyTqq7aiSynrarwl/JGYXp5btWCy8o1O2F X-Bogosity: Ham, tests=bogofilter, spamicity=0.011077, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 1, 2024 at 4:02=E2=80=AFPM Benno Lossin wrote: > > On 01.08.24 14:58, Alice Ryhl wrote: > > diff --git a/rust/kernel/mm.rs b/rust/kernel/mm.rs > > new file mode 100644 > > index 000000000000..ed2db893fb79 > > --- /dev/null > > +++ b/rust/kernel/mm.rs > > @@ -0,0 +1,337 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +// Copyright (C) 2024 Google LLC. > > + > > +//! Memory management. > > +//! > > +//! C header: [`include/linux/mm.h`](../../../../include/linux/mm.h) > > + > > +use crate::{ > > + bindings, > > + types::{ARef, AlwaysRefCounted, Opaque}, > > +}; > > + > > +use core::{ > > + ops::Deref, > > + ptr::{self, NonNull}, > > +}; > > + > > +pub mod virt; > > + > > +/// A wrapper for the kernel's `struct mm_struct`. > > +/// > > +/// Since `mm_users` may be zero, the associated address space may not= exist anymore. You must use > > Can it also be the case that the space never existed to begin with? Then > I would write "the associated address space may not exist." > > Also I think it makes more sense to use "You can use [`mmget_not_zero`] > to be able to access the address space." instead of the second sentence. I took the "may not exist anymore" wording from the C side, so I'm going to keep it. Alice