From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BD4D16261 for ; Mon, 14 Oct 2024 13:25:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21CE76B0089; Mon, 14 Oct 2024 09:25:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CCF76B008A; Mon, 14 Oct 2024 09:25:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BBDA6B008C; Mon, 14 Oct 2024 09:25:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DEAD76B0089 for ; Mon, 14 Oct 2024 09:25:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C48971C63C6 for ; Mon, 14 Oct 2024 13:25:31 +0000 (UTC) X-FDA: 82672279956.28.F5C4ED0 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf03.hostedemail.com (Postfix) with ESMTP id 7123920007 for ; Mon, 14 Oct 2024 13:25:35 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="V0w/r6W5"; spf=pass (imf03.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728912150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qcw6vFzAeM6V1uYExGMaM9DjMaXwb3dLyeYvVAn2Ehw=; b=0brQ5Isu1kBHJLaVOD8+GqFK7Y2tbN2sjePB68E2tm+c6tkZaXJkvsDck8BSPZFbYGi1jp 8C6mHEtncBjZ5MyxZmICm0TqeEpkpi1CHnjGcO1LasjkooIkfwBi08g+gbzmhs9lhunsQv YW9SF9tU9OjMpUYMRZ5hd1TVq5i334w= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="V0w/r6W5"; spf=pass (imf03.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728912150; a=rsa-sha256; cv=none; b=fdI6TBe5DdaoDO4xWiT/bHiZh41R2XAdECLA0VfJAC+VXKWt/Ayteed1Y9tEE+xUHylhmF 8hGGI1Ua8nnp/lgbWR0gWJpxFao1ERavJK9Bj6XwGHcCKBKjwxg52+JtznGWXgZL7D1s6M WSA7EuM8ZoFmzplzGfM7FeuRR+cSVOk= Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-37d3ecad390so3381921f8f.1 for ; Mon, 14 Oct 2024 06:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728912337; x=1729517137; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qcw6vFzAeM6V1uYExGMaM9DjMaXwb3dLyeYvVAn2Ehw=; b=V0w/r6W5rPUZw9nd8PUGIyEfr5tvCYAe/ixBnCUHs28gBwjuK5mshRb5f5pSBRmM1/ Vgwe1fRZEmaMmjlN+I4KLvK225AgZmd8Q008rbKftPKVr/oVr3u5xLTUiLt6OO3tYm2z hgD4gYhV6fnguliSaMg1PXp6vSpFsPLGA7kWyW9wbv6OqHup4KKKMKiapu117L8TjVk6 oAZEUkGXSJHcsOKESNPsBzTShCuFD/JKvwhxIio+EwaOhnvDRm32A2KzVzSHjVatJKwa VHif8WdL7Tcnw32K2g9rU+k6JvnqyTWdcjLfM1FOxETSa45Zj8y5YgzTWqTYk5dNIEyR nMqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728912337; x=1729517137; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qcw6vFzAeM6V1uYExGMaM9DjMaXwb3dLyeYvVAn2Ehw=; b=LcKPjOp6y12URuDzqwHWH/+fDAwyNhVu6O2yH/oHm/0xKK8DkXlh354Ig6LKPsNhiJ g7ozCTi62AiF907q/ViQaBFKvxikhc5uxo3KbO+g9pBaFbeG4pAU7pOjN81waFCiINCO cCtDaIbG1VQOPn+VpKO2d8DE1lIy55sPwq+389Razmd/G3SpYd1tsHaOzquyLy7xuSyg UsKIoWK9qsytzMnp2wD/arWbRLgH4BYRPsqH4W92i8Og00ya4k4Ps8WYD4ri8/T0G2ep faS43AgSDCj5pmoC9r4K/VKIaTwT/0DXFbUomIXXhDTFVK/7X05AVFVnemfN44wrfRI7 tKHQ== X-Forwarded-Encrypted: i=1; AJvYcCUabMNNGngfKHm9NrupiBGdMhEsfv60RYrgOoMF8nJh5lXqiQw5LzF6QB+2RDyxEjKK42+YCWSRdQ==@kvack.org X-Gm-Message-State: AOJu0YwzyzJsCUMmXM7Aa6nmU/WV5WpB15np/YxCVsvrlTQMtwbggOx2 o8mKTPE75h1EcrHlor2kVLNp/0Vpc0m3IW02B29RGoC+n98eMWIZG+7nlYAFe1jqmS7Z6q/eonU Em2nXtk8xG+I6TgzZBUx9vPz/CWOavyI2WQvI X-Google-Smtp-Source: AGHT+IGh9g25AxERQtC7Q/z3tZszAdR6jVdmK0ErRScTUABwGozUjqMJMTLChIuJXgSGz4cvgAjijGBqFoiI0/5liCU= X-Received: by 2002:a5d:53cd:0:b0:37c:ca20:52a with SMTP id ffacd0b85a97d-37d551d4f7cmr7789713f8f.8.1728912336980; Mon, 14 Oct 2024 06:25:36 -0700 (PDT) MIME-Version: 1.0 References: <20240912-shrinker-v1-1-18b7f1253553@google.com> <20240914140745.7b0e5d5c.gary@garyguo.net> In-Reply-To: <20240914140745.7b0e5d5c.gary@garyguo.net> From: Alice Ryhl Date: Mon, 14 Oct 2024 15:25:24 +0200 Message-ID: Subject: Re: [PATCH] rust: shrinker: add shrinker abstraction To: Gary Guo Cc: Miguel Ojeda , Andrew Morton , Dave Chinner , Qi Zheng , Roman Gushchin , Muchun Song , Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7123920007 X-Stat-Signature: m3n3k78yhd4tbrj4ce8ds1i1cnw4wpnq X-Rspam-User: X-HE-Tag: 1728912335-351709 X-HE-Meta: U2FsdGVkX18mzycR0SLoi+9KDUvGzKHUYqAitV0KYsSd7oIS31OF8U7wKfJNsR+KQkj2xx+ny2C87AIvVDbQO7h1iAsIDiin0zHZ785z1B9FCBJ+C7/5b9C7Bd+Rmb65bo7XPfspqKG0irn2y1VjV3EF72If7vKAvPoQ95r0kfe66TGtZs1wJI5lAxq9zjtvqu4EE+STPel57pA+D1GHp2hC3cRDA+CqDbXUrqDVto3EAwm3sWO07d4pfULdhls+OSRfWHH84JCbslNsxkZc4xRSmk7TKGyRd1oVbTyVdSOiGgNkEfDmbAef06ZqB7Ffl57+CTjl0udvAgk970bocQK10ucXTQLVlys7PSMNiTAvhXUT9yvaMWHUyNHBEqDv8hrWkudsnFJnNxi7VYYiL9/K/41fneWDgnXLhljlLeMd9GtYscf3pqSWU6fUxzIohC79LGmaV8KkY/Lxow2Bzh0nw7lEkRBc13qTFBcf4CZAOyEcBcRh7W28wBpUuKvWcYKG81EaMHiGJMoUuF8hUtVMd+qhd8ONgYeUOCrkNXtU0ftRTeYsd5dMhxy2rs/Y+nHTcs4NaBqsxHCH3+h6DgnZ8idJGb4gHn72SReC2aor5tPKZOLZB8hTSmS+2/hUapa7dKenIj749pcoQq2piYN0gWVTIezddOQA6l9HhQoXfuiBHZMiYEevR9g+Uj368eDJ15Yyk3e7WHAWWj+VuIZt8MvMwDllnp2i9NbQ6vrCxCQpBN0HlIdy39vOSIZhGUebHcjadSj9Jq2wQiM8w02rswVYQZnnrmN/m3VyyqiO9BYSf1M3+hCAFqAJjxXtFZvE19zqPN+i51ZY8+hNSKmq97dIed0DCGvMeEce+BADZbVDp+eMfUXQb3fgVB/3B8vFbn1jAmPA6QviKS6ZbG3O65H/+9QPgSo73/k5aINJXr1tOpoC4dr9aFZvtKEX8tXZ/cW2i3DBxs7MeIJ ui8OG/Uh VTfZnziHLX8dHmO+UehqiEaoVvvpsJGw6tVMt0BJFQyG//wN/3vW8m728zXpFnkpMtWAr5iZ/GkS1+DuiIecJZm5IZkBAqhooVVrRmlSagw8WhewiFeAx1JdTJyR+eo6mT/O1habYOAR/p2ZPrp1cOlkkpoySysOOCnCBbErWzEU6cadrgcaB1b9+cBHNU2Wc9LP9G3YODgYJIiJAYlJzO0OFigiySM7WnmytQAyB+KYHxxgTYGN/e/uxuSN1slOG7rJnKuy8OR9bLf2BiErLmoIyhjfd1Mc2Skaf+uxW/ePCcQO2UVo6qXN9+qGbeRbGniST6bC7AU4e2/re2hNa0umyNYqyKYf8ndabAzrCeO1u7tY7fyT8GvufYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.007777, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Sep 14, 2024 at 3:07=E2=80=AFPM Gary Guo wrote: > > On Thu, 12 Sep 2024 09:54:01 +0000 > Alice Ryhl wrote: > > +/// This struct is used to pass information from page reclaim to the s= hrinkers. > > +pub struct ShrinkControl<'a> { > > + ptr: NonNull, > > + _phantom: PhantomData<&'a bindings::shrink_control>, > > +} > > I feel like this can just be a wrapper of `Opaque` and > we hand out `&'a ShrinkControl`? We need mutable access, but using a pinned mutable reference is too inconvenient. I prefer this. Alice