From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00284C3DA49 for ; Fri, 26 Jul 2024 08:32:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AD206B0088; Fri, 26 Jul 2024 04:32:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75D2D6B008C; Fri, 26 Jul 2024 04:32:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 624BA6B0092; Fri, 26 Jul 2024 04:32:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4413F6B0088 for ; Fri, 26 Jul 2024 04:32:50 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B80211C0F39 for ; Fri, 26 Jul 2024 08:32:49 +0000 (UTC) X-FDA: 82381238058.24.07232E5 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf28.hostedemail.com (Postfix) with ESMTP id BD352C0020 for ; Fri, 26 Jul 2024 08:32:47 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HXO7sJsc; spf=pass (imf28.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721982728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vwKVjdvi7q/mOK8CLeQJUjtonGZ4eAyz4iuobreU3q4=; b=7jozMcONdGjkHEn6g6LsVmzfx1x9v74c1ex44F6oYNsams3ljVk1ukPa/nvD4YZf/pK7tT PV7OWFzTIczK/Oxrw1wLBNMKcxy3/0SQ5rFfr4gIt7YKlQc1E1IXfwgRbBi9+8/UBI5QLX o1FU/18yEmnYtDiGYYisxsZSKMI7pb0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HXO7sJsc; spf=pass (imf28.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721982728; a=rsa-sha256; cv=none; b=yQfV4lT9NCXcegetQVcLe4+sRrTvPb6f4/GpZ8gf0AqSUQH2F+r7tU/0QBLx9IPvwsCsrI VXqumX3kxQwX+kUu7GQuNlyUKS0eE1mZQYlxV9DmpBvTeS8ZVaYxCJ2vQC784uSibKvwZg USt+08wK7azVlpS3u955u1lTkzCmSW4= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-36858357bb7so1035468f8f.2 for ; Fri, 26 Jul 2024 01:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721982766; x=1722587566; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vwKVjdvi7q/mOK8CLeQJUjtonGZ4eAyz4iuobreU3q4=; b=HXO7sJscmQOC/yBJ5HpLI0WKR6I1IPouAxqFiDcGmpacev1lwafrF4QIz39DJt1+LS /bdKkimp5TQ3ZNJZ9jf0J4U8m/2oao8UtnavDU0C68v/mMfUAaMbKZsbCvv/xaloS8WN V0IloiCOkVbXsPdE02gDAjuuhDer5Gn9J0g6ksyN9hwVvFYFnnzN0ludplkC3o1yKLAY 1yfqFcd7sZSeV8Xhcto/pP0R0BXpLls7neAWGSIWO9KMNp1BAe/2FZqTwuycwsp3JAQX 2xWH6Hqu89BM+L+LUC3cBiGijOhrOkDhe0vNP8c6jBhUx0nsfsgAd0UMC/wuqBQ1Ay0H z51g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721982766; x=1722587566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vwKVjdvi7q/mOK8CLeQJUjtonGZ4eAyz4iuobreU3q4=; b=tJpCJyBlmkn8W5oEZFDIfvPlV/LZnC4JwSd+yzsZ6RHHmJQksmWyaKC1iJFswomytz NkyWgA/XwFjbOpsHraKwgmAjFapEZLgLqdmDiMDEE1O6aFeXZsxiCAmSq0jY/uWHdPAb BPoDMwcvDkqyOqzdyzdM23DjVrju9tSs+znJTM2hCi612vsuNCK25up7fAKa09BPMKp8 /uMS9Qqa4YkXu27wBWNO85Rp53hpuI80F0i8x1exj/dtNiu8v7G1oD3W4c8eklGnnl89 4azKFyKzgEgpBT/J/IdfmTUmWhTas6RbkFIuFQ38Eg2NmFyT2IV1XN8N7bJ9YYDV4Nm4 LqSQ== X-Forwarded-Encrypted: i=1; AJvYcCXizuXaayS0ctn0ASTM+diIkHBzNgMrGhkMhrA9lJRgNLaNuCuVrm9bxLMMHCZYzMZt26tNM7O6SXN4xyiKFbAxA1E= X-Gm-Message-State: AOJu0Yx6fVpTqmHZMmn/yantvxYER/NciEHe7QPwGIghBLn2AmTVRtLm CDuUBU1icgpymWvsSKyi95wlFuTOsq9H9p3BENSnhkU+cEEcivnK++ZSUVA+NP9omjfh8EaSGl/ r3Byif6ivKG434D7MTNNA0/+j+/GFza+TkLQw X-Google-Smtp-Source: AGHT+IFw9aEiWWbNWrKSwIfNsoFiq7Z1Ie3/K23HqXX8wAt/1ZIGy3iHnGySvW1LYIP+uZ2IjLERURUQtmKWmr5gbqE= X-Received: by 2002:a05:6000:1544:b0:368:557a:c64d with SMTP id ffacd0b85a97d-36b319d238dmr4990492f8f.9.1721982765950; Fri, 26 Jul 2024 01:32:45 -0700 (PDT) MIME-Version: 1.0 References: <20240723-vma-v1-1-32ad5a0118ee@google.com> <3bf6bfdc-84af-442a-acec-a58f023d1164@proton.me> In-Reply-To: <3bf6bfdc-84af-442a-acec-a58f023d1164@proton.me> From: Alice Ryhl Date: Fri, 26 Jul 2024 10:32:33 +0200 Message-ID: Subject: Re: [PATCH] rust: mm: add abstractions for mm_struct and vm_area_struct To: Benno Lossin Cc: Miguel Ojeda , Andrew Morton , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 7ypqfcq8tmktcfdoiq9cfejpj4mb1cqi X-Rspam-User: X-Rspamd-Queue-Id: BD352C0020 X-Rspamd-Server: rspam02 X-HE-Tag: 1721982767-137419 X-HE-Meta: U2FsdGVkX1+s6wxoqUvkSs6CeGDCoZHC0W0NcNUoZ+KHnf6+13VpM9Fbgu5BgWLDq75u5aY9JMeejckiPyRCCT5cyBbJ/RIkw7o3huSspvVNohm5RyHzn9vHtkrW0pOqzwvfF70betuYThOHwqDbHGz+65XK0ZpaWqO3gPPQdPE9orqOSp+t/DRdvbYRQijEJdCoPL8Ni+kAsZ8438MD7+lGUiUFWY/c2L2d9wQTbz/e1XMG+FKjknMoAmyr4IjNZIM5b2TA+5yNNzEnfN4H5sN7LBlmTjcbTFfGWONPzjvU8t300ULjRH84Sh6IDlSZ88zVouBfjDrI329S21tLXWYjZKXiEP/bDpGgd7/M19u+bxz03dQApCMpYkDknUlyHv7Cx2PsKMfyBlsTuJ9IftmvpJ0cibyHfWTJCqq5EXqfPfaNtSzA0YQXBU7wawDVpTOWNDu3ADzEpuYHePykaUSMMYAILvlOZjLqxipNWesTWAZbTR7fBd38EDARRNfVoxxb2lXjC03Pn47OkqB7NplXxYropGBIQTwus9l6eKWa7BPWd36h2Yr4bFNOCCx2WXo5Cl6ju/bqtFSZrDquBWMjbNLKBJkD86ZCF+FUbBG4xeUKTw8Vic3UCBTLSFkgGqocHh+0LR3HmdXi90oeJz1CHDi34TE+hKt6SBVoaNkGWP/PN/ZnttR9SbbZsCnlEleowokojFx5W8Yd2+Om9MfffgM41la4a233rB5KE08OeEHhjYI3o7Kbnj3X+XyQxbOc4JmI5CFu2BMPcMUALiSwK5IS1E+nBAediS0FFYGFitckFOUeYBOFTCGhJehbyiJKPdHo1Rj6fKCs0jj7U6kCGwnAjJXIRNr2kAedkukK3nvon/mDTPMSa9yhA/fqpiP/ZC4FLacekMep/ejJtAbRZGn8Tvz+2or45wckZE5DDi49Wv4Dnzy4dsb1fDMblSQ/B7zksrpKyMC5SRG u5z2AN+k kAdYmKexXDDLzL+cwpfaP0lu3Cqqvh0zqdv5PvppLq6svgqBd1BDL3JzZhweXXvIYYuzYQxz+eBR2UdGNCSYVBGVj7+tDzCUN9cZis9kjKOuljK/gH2tOTtB5pkTST8qweKUohWbDNRf2wVFmlt66YpoKMO0SjWw5OyYA+N4o/7SM4to2EWs1uirtJzO9dr48sOd1gYM5uiAb0msBayQ3IGRWY9eEjJkBwO9cTgffGRM2pDsDJXV2k3Dc/GPiMIX8L6OP0TB2Ufi00ovSs1n9vjSQ3f2r3Y5DkLEl X-Bogosity: Ham, tests=bogofilter, spamicity=0.003172, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 26, 2024 at 10:11=E2=80=AFAM Benno Lossin wrote: > > On 23.07.24 16:32, Alice Ryhl wrote: > > This is a follow-up to the page abstractions [1] that were recently > > merged in 6.11. Rust Binder will need these abstractions to manipulate > > the vma in its implementation of the mmap fop on the Binder file. > > > > The ARef wrapper is not used for mm_struct because there are several > > different types of refcounts. > > I am confused, why can't you use the `ARef` wrapper for the different > types that you create below? Well, maybe I can, but it means we have several wrapper structs of Opaque. Would it not be confusing? Could you suggest a naming scheme for the structs I should have? Alice