linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Tamir Duberstein" <tamird@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christoph Lameter" <cl@gentwo.org>,
	"David Rientjes" <rientjes@google.com>,
	"Roman Gushchin" <roman.gushchin@linux.dev>,
	"Harry Yoo" <harry.yoo@oracle.com>,
	"Daniel Gomez" <da.gomez@kernel.org>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v3 03/12] rust: xarray: add `contains_index` method
Date: Thu, 12 Feb 2026 12:19:57 +0100	[thread overview]
Message-ID: <CAH5fLgjfSWfhUkmG6_ugue6Wp5LKtkEFJofWViJSNByq3sO2Sg@mail.gmail.com> (raw)
In-Reply-To: <87v7g2tesf.fsf@kernel.org>

On Thu, Feb 12, 2026 at 11:52 AM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>
> Andreas Hindborg <a.hindborg@kernel.org> writes:
>
> > As far as I understand, this is a borrow checker limitation. It is easy
> > for us to look at this code and decide that the borrow on line 51 will
> > never alias with the borrow on line 49.
>
> I did a bit of googling, and this seems to be a well known issue with
> the current implementation of lifetime analysis in the rust compiler.
> Apparently this kind of code used to be OK [1] but the Rust devs decided
> to remove the code that allowed this, because it was causing excessive
> compilation times [2]. The upside is that this is solved by the new
> lifetime analysis implementation called "Polonius" and it is the
> intention to replace the existing implementation with Polonius at some
> point [3].

I believe the standard fix for this issue is to provide an entry api
similar to HashMap::entry(). See the rbtree for an example, as it
already provides such API.

Alice


  reply	other threads:[~2026-02-12 11:20 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 14:38 [PATCH v3 00/12] rust: xarray: add entry API with preloading Andreas Hindborg
2026-02-09 14:38 ` [PATCH v3 01/12] rust: xarray: minor formatting fixes Andreas Hindborg
2026-02-10 16:44   ` Daniel Gomez
2026-02-10 17:44   ` Liam R. Howlett
2026-02-11 18:30   ` Mukesh Kumar Chaurasiya
2026-02-09 14:38 ` [PATCH v3 02/12] rust: xarray: add debug format for `StoreError` Andreas Hindborg
2026-02-10 16:45   ` Daniel Gomez
2026-02-10 16:55     ` Tamir Duberstein
2026-02-10 17:44   ` Liam R. Howlett
2026-02-09 14:38 ` [PATCH v3 03/12] rust: xarray: add `contains_index` method Andreas Hindborg
2026-02-10 16:46   ` Daniel Gomez
2026-02-10 16:56   ` Tamir Duberstein
2026-02-11  7:31     ` Andreas Hindborg
2026-02-11 18:24       ` Tamir Duberstein
2026-02-10 17:52   ` Liam R. Howlett
2026-02-11  7:41     ` Andreas Hindborg
2026-02-11 18:21       ` Liam R. Howlett
2026-02-12 10:15         ` Andreas Hindborg
2026-02-12 10:52           ` Andreas Hindborg
2026-02-12 11:19             ` Alice Ryhl [this message]
2026-02-12 12:39               ` Andreas Hindborg
2026-02-12 17:49                 ` Liam R. Howlett
2026-02-13  8:15                   ` Alice Ryhl
2026-02-13  8:17                 ` Alice Ryhl
2026-02-12 11:27             ` Miguel Ojeda
2026-02-12 12:47               ` Andreas Hindborg
2026-02-12 13:34                 ` Miguel Ojeda
2026-02-09 14:38 ` [PATCH v3 04/12] rust: xarray: add `XArrayState` Andreas Hindborg
2026-02-10 16:48   ` Daniel Gomez
2026-02-11  7:42     ` Andreas Hindborg
2026-02-10 16:57   ` Tamir Duberstein
2026-02-09 14:38 ` [PATCH v3 05/12] rust: xarray: use `xas_load` instead of `xa_load` in `Guard::load` Andreas Hindborg
2026-02-10 18:16   ` Liam R. Howlett
2026-02-10 19:53     ` Tamir Duberstein
2026-02-10 20:59       ` Liam R. Howlett
2026-02-10 21:22         ` Tamir Duberstein
2026-02-10 21:34           ` Alice Ryhl
2026-02-11 14:32             ` Liam R. Howlett
2026-02-11 18:00               ` Boqun Feng
2026-02-11 18:19                 ` Tamir Duberstein
2026-02-11 18:24                   ` Boqun Feng
2026-02-11 18:55                 ` Liam R. Howlett
2026-02-11 19:45                   ` Boqun Feng
2026-02-09 14:38 ` [PATCH v3 06/12] rust: xarray: simplify `Guard::load` Andreas Hindborg
2026-02-09 14:38 ` [PATCH v3 07/12] rust: xarray: add `find_next` and `find_next_mut` Andreas Hindborg
2026-02-09 14:38 ` [PATCH v3 08/12] rust: xarray: add entry API Andreas Hindborg
2026-02-09 14:38 ` [PATCH v3 09/12] rust: mm: add abstractions for allocating from a `sheaf` Andreas Hindborg
2026-02-09 14:38 ` [PATCH v3 10/12] rust: mm: sheaf: allow use of C initialized static caches Andreas Hindborg
2026-02-09 14:38 ` [PATCH v3 11/12] xarray, radix-tree: enable sheaf support for kmem_cache Andreas Hindborg
2026-02-10 16:49   ` Daniel Gomez
2026-02-11  7:45     ` Andreas Hindborg
2026-02-09 14:38 ` [PATCH v3 12/12] rust: xarray: add preload API Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH5fLgjfSWfhUkmG6_ugue6Wp5LKtkEFJofWViJSNByq3sO2Sg@mail.gmail.com \
    --to=aliceryhl@google.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex.gaynor@gmail.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=cl@gentwo.org \
    --cc=da.gomez@kernel.org \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=harry.yoo@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@gmail.com \
    --cc=tmgross@umich.edu \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox