From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48CDDD1A43B for ; Mon, 14 Oct 2024 10:56:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D424A6B0082; Mon, 14 Oct 2024 06:56:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF2C06B0085; Mon, 14 Oct 2024 06:56:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBBAB6B0082; Mon, 14 Oct 2024 06:56:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 980086B0083 for ; Mon, 14 Oct 2024 06:56:18 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8A62E40CB7 for ; Mon, 14 Oct 2024 10:56:13 +0000 (UTC) X-FDA: 82671903468.25.BF740DE Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf15.hostedemail.com (Postfix) with ESMTP id 71593A0002 for ; Mon, 14 Oct 2024 10:56:10 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pCEx0891; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728903345; a=rsa-sha256; cv=none; b=TV4KKZlCheHcrXUeK1zISzn1MMKuSsttQgw8vA9zH9D+ymN0ndmY5JENvKD22HIJ/jPg8R OeAX2pmmo35zIFmtjC1JB0fjFNkLA9pG/nL3c3lZPTmiriBGqXwDbPyzWhgZyxVySAo7s+ vww5HZYhI5mE1IXGP6raQ+SAtp1XXnc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pCEx0891; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728903345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u4gp6e12cg+sqnH5wDR5jIQXbUcLC2B1xW6NEdqt2eU=; b=ms47RWjUzmt2/mvw4f2TCjdQ4RsX1sQes686+UNehPyEgKOGsij3sKMnAKPHTb6KU6QnLB jQzdjLON/sLJa98MJDUjDMfMdokrh7ePHCnlx6r3tyLEpHvL57DSwBqYqOR8dPcSO2hzFP NokTlWTJ9bdlIDtvPAeXjOL9OYeFqeA= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4305413aec9so40275955e9.2 for ; Mon, 14 Oct 2024 03:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728903375; x=1729508175; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u4gp6e12cg+sqnH5wDR5jIQXbUcLC2B1xW6NEdqt2eU=; b=pCEx0891maXZm4oy++TzU5KS1sNO0nQ0ONfsdCvWcsJZ6z5EobpIGIwc+Fb+N3/sn5 Ibbr8woYDgpaMzQMjx4IpHrR0SPq3OBFSz/69Kw4GpwzAZBrOaGvCn5umRepq6BQZl1v PwvGazs9NeFOCQJERejoxUrDmeTYR/sDTfkNGfN5UmFbynUnhuNy6ncRG8JwjF8fyy3r fV1YZF+woUVoYrHTLehoA58HAhecmRfTXaPtlos1H2VfzxiRT9UoX1dktl9wXv/sMLU9 gNCZTx6dVFap1NzB/L3gl/fZGDqgg393M/Tyh7F6rXAmEWUql58KRlhxPURFmeZk70/d CVKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728903375; x=1729508175; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u4gp6e12cg+sqnH5wDR5jIQXbUcLC2B1xW6NEdqt2eU=; b=gBcTZB6KlYsuWDvAyIBoaVxmwE+Hl+L6HsOw7JdA+KFULiex33i5pIJJZ8Zn2qgFiB 9jgM+WRjvNO43nOKtvleWv9RK+OrGbG7y5UdyQ/JFCdIr/zQ/GT8eVxBfdGkCTU7Cvtd vZSvoYAU86mI3VitWkjl32tCqEjahu5hovvRRDAH0rR6WigyVg/++r5JcXzOsMYaltJ8 99CcZOvAJOr+T8Dbxcpsk/VZAd4EjzY9zfJB9XK0dXhhZMU+LHPre7U8+eeC0NncQAxZ W1fPmI6F2YrgD2hj3KPAF/f+jrqdbhcABECOV2AE2Iibb/0M3Q1exqaIDS4Ml5YzjtXh i1XQ== X-Forwarded-Encrypted: i=1; AJvYcCV84kAf8W6oPKdQ142L2WtFZzy0t4u15qy4qCUPWlueS3SrC2KRicHKM+areE9dnQAe1c26ADmJQg==@kvack.org X-Gm-Message-State: AOJu0YwuwFfVSl3x1Mz7Z/HwbkY5TQ5hEM1F+J06epNd8OeEv9cJ8BKw Sh/YJJtolAPW8Z4YwkLc30LxbVwZtpxJm9zviX/QyJf3873Ud6Z0AyGvUXNo2i0c6xJnycdiZjl 0TDfBfIg61Vy64bn3NWBbtHnAtMiNSkIjmsuL X-Google-Smtp-Source: AGHT+IE5eRoWQDx97xOv2leEqqV4jcEBkFr3gadIwamzFJS8TDNfpmwWZcvrbJruha+0XkR+9A8/cfjYWgRPs4yHYCk= X-Received: by 2002:adf:ea45:0:b0:37d:4cef:538e with SMTP id ffacd0b85a97d-37d552d29edmr7335919f8f.55.1728903374819; Mon, 14 Oct 2024 03:56:14 -0700 (PDT) MIME-Version: 1.0 References: <20241014-vma-v7-0-01e32f861195@google.com> <20241014-vma-v7-1-01e32f861195@google.com> In-Reply-To: From: Alice Ryhl Date: Mon, 14 Oct 2024 12:56:02 +0200 Message-ID: Subject: Re: [PATCH v7 1/2] rust: mm: add abstractions for mm_struct and vm_area_struct To: Miguel Ojeda Cc: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Andreas Hindborg , Wedson Almeida Filho Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 4tzfhp6ofuag6eay86euee8ds5oxu5fa X-Rspamd-Queue-Id: 71593A0002 X-Rspamd-Server: rspam02 X-HE-Tag: 1728903370-874992 X-HE-Meta: U2FsdGVkX19oKArOqVDnxhNW5cc087eMfjPviYcPo4JD5ApTd2dx93J7i9dxqTMyW2qi4dKhJgpfrU1wr2kS5/91pORklXggbva1gOAAY1f995eIzBVTcGtjFZw7Xg+gD9LAd/jPslVbcEPGKWISRf3GlQeOneD1YEzdvemPje2rqAo67GbtE16akrFtB7O/sNxQkvYRzZix5ZeAmA9RBX0vvmzvXDCl891Yyxgao7BPh/K2xJgnUKoSTozcTX6loWFiCVrZ8RcPDxRb5Fw6dnWUEkbREkGtXT5AVT7Y4drgH5Q9ZOi/s47HL9ad24ncmGxHcFhuszHfdEsrDozjdX6lmbeuoN9oEO1r0DHUWpgZ527mxUqY6L7qZ53G+jeqP33sEU7sEoxoXeHg3vWuDcrA+qPbNS3wWCc0TnaAA1G0OdakC8wwehWnX4/vMwdcmWPzlYo5xHm9Uh8GghlgxacmxIIobcUSXTSlWZYDiJsZ7vN/au2e17MmVTMDZzYwrJcmKAeMj/xjCpshb1k5j3dxLIemgv21u/cazSf/e1q7ZkWZVrtZVlpSh7y9p46Ts3gAwngnmmWu5MvsxJeIhn3ieEV5blXNflEWHaLjOaRFoWd5O/7W5AmDi54TkN4vlkHma7WnA7PZcjlx5IGTvVXK4suPQ5w+qDs4CtKa+DhBXkUEe17wvNM5xgZ4R1AqX9xHm1pk6PzGhGZs+PwC7XBEeIVojtJdQRzTAxlJjA3H1JntWRa393KEk3kxLe0m0aaEwiP7VUXHmY/hwEoyQySBS60fUm+0MWJFD/KJRNJN32ZJ7bRy5SZWAYPKPH/9gCfhbqlmLPG6VDs4hyXMpGQDWec00i9x+mNHSy0fRan9FAXj/auSiCHiCVH7OmDkGeiqJ84F8wuw7zpYL0Xf6s2YT3jO68+5GO/zIl7LuAeloHDACvoPkpLvZJg7JlPkoCK89EJ7u1cDg++ywaR Ih13Knag kyuvmddPlKIw4YTltiUIuXrZkqdrVQUJWPtmDQqOHUV1ufaV0xFR8hOMNjzlRuyuJ0blJ0E6doIdgLgEr9My73vJHcILHmI4+9Io/Jml/1YzjYFgZ7Oii4xTxMhxSsYmGw0YO8N3I1+M9hCOE9iW/3POlaw8j7geA5R3pHt5w1Ipoi0BnuffDf1OYSaDZQSFMHefd0Z7lBC28wjYn3LrQ9XPNox8Y5G+9agDuB7DxyFkoVIn4C4Zp9PRo9WjdkcNpdvHrWOcPjS33KeFdM6JoO9rxGcrK70ZNNLI1C1N/TQLEUyWvmbv434oX96aRDEAaRLB16HhzJeePKCBOz7MDHJgm+kTMRkHjUEczvOsg0H6wi5g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001783, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 12:47=E2=80=AFPM Miguel Ojeda wrote: > > On Mon, Oct 14, 2024 at 11:30=E2=80=AFAM Alice Ryhl wrote: > > > > +/// #[repr(transparent)] > > Line in docs. > > > +/// #[repr(transparent)] > > +#[repr(transparent)] > > Ditto here, but in this case also outside the docs. > > Some trivial nits I noticed below since I am here. > > > + /// during the lifetime 'a. > > Backticks (some other instances on lifetimes too). > > > + /// Calls `mmget_not_zero` and returns a handle if it succeeds. > > I would add `bindings::` since otherwise it may be confusing to say > the C name without qualifying, since this function is also called the > same way. > > > + // SAFETY: The pointer is valid since self is a reference. > > `self`. > > > +// Make all VmAreaRef methods available on VmAreaMut. > > +// Make all VmAreaMut methods available on VmAreaNew. > > Backticks. > > > + /// Can contain "struct page" and pure PFN pages. > > + /// MADV_HUGEPAGE marked this vma. > > These are copied from C, so it is fine, but we may want to take the > chance to format them. Thanks for the docs issues. I'll give others a chance to comment too, then send a v8 soon. Alice