From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DB9C52D7B for ; Wed, 14 Aug 2024 13:50:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB1396B0082; Wed, 14 Aug 2024 09:50:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C60B26B0083; Wed, 14 Aug 2024 09:50:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B28576B0085; Wed, 14 Aug 2024 09:50:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 933506B0082 for ; Wed, 14 Aug 2024 09:50:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3D20780F20 for ; Wed, 14 Aug 2024 13:50:43 +0000 (UTC) X-FDA: 82450986366.21.248C823 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf26.hostedemail.com (Postfix) with ESMTP id 658A314001E for ; Wed, 14 Aug 2024 13:50:41 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ehC5LQH/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723643383; a=rsa-sha256; cv=none; b=aI3D2HUg03ZFyFrR6ODtWJAoWra0S98WHRgrf0CVACKlog8qVQ3R6CxdcDIxPg3VBnZvlC 86QcB6iwYXR1Oag+uchJ6toxO9+nSvoEGA7CNt5fiymwCMXLn2NGmLwsZqbR364yEyUxgF YpplmU9NX0tynpRr2PY5wQLNPHiQQjs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ehC5LQH/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723643383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fWlsD742nsSTDR/gyh46VcY1FUTXkxyk9IRkE90yJpg=; b=Gavuj5uQ4ZUqC61uVuJ+kc/CHtFVVlGd7ZVFv8rlaWa9oEy3IspRBfpRUuM8CiBUa/a+93 7PQIZixXshZxjIoUiDExbX7TuZYsmKyVwzt2FXghKJBuGNocK4grjSOc8aKTRdCylfTiGh UUfR9AONdOb5GByuRb+zEs28ZMI37bk= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-368712acb8dso3918671f8f.2 for ; Wed, 14 Aug 2024 06:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723643440; x=1724248240; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fWlsD742nsSTDR/gyh46VcY1FUTXkxyk9IRkE90yJpg=; b=ehC5LQH/8iVJ38eOJHZAWh2A5L2SsPqKb10AyYvECj02JBJR1AsGCaT8mKVxpp0tUQ 8pnI3JyvtzUbRuh3WDCg05XBtckSFxCVtzjeZAAorU6c+XT7pa7cWZmwwx5aHPSw2W0X LPC/3vq3hWbACNW78LsBdijiZ87X4L/HHzQeeY5PPq/Tdm8KpVcWft2YT2avUuiR7nq8 H+QR+0q/kmbR7/WQ4jzfs474mFFBccZwHF+HJZp0AUDZUm2c94kxAtoKuDglwQt0EPNt b1L5Air+dd/IVN1Wp4ZYdaEs+NjryiKb5D4teHTpFS3iQTx2sJWPpUDfFWwJEY9cxcdk ECFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723643440; x=1724248240; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fWlsD742nsSTDR/gyh46VcY1FUTXkxyk9IRkE90yJpg=; b=s2b/L63oxDuSx4tqKrgEIfypeEf1mTu1W+XPL6hhF7LtwX1Abu7ppSQ/I/0fQeBIcU qQ6oUOA9eYirol2TYm35P0YZvEQkG5Qcsa2qvlGBDj5gYN0WkA7KTdqLp1uovyZmBEQD Qunzis9wxNesZxnO6OwXTlmiYfogp9P+xUUTSBpcLshWp9XHydEOmpPtvWdVJbibGKBo BP//rY5e3sTRzFFvDw7iyETtH3RF9lmlO5/iWEWQ926DgQvUQpgE1VcEr76mlKei2gZc 1zdjE4IoDVyQg0su+ZYhnWnQDHSJndY6HtHf/LoFXB+MLC1IaMlteqR5yazFjQ+h32aV IGMg== X-Forwarded-Encrypted: i=1; AJvYcCVKDOs1CYnxgJq61VLs05O+JpAJPzYNvm85AO69FyV5nQGRjq8NK4Zx72Fz4Qib4OeDlX+dorYCRhMl49LjcZC64cg= X-Gm-Message-State: AOJu0YxqA/47Q//8hnNrSlli2cKZmkOu8hisL21hlO7Wxl3NtYB/3XAs KngjW9plUar2WTD8TB+fIXXkRkCQtc1/xndboqJi/X7E1f1mqNb5XnqPmhQwFjdlZ3XC2v7J4Ja rbIE36nRSHNLLv2kEme0glPbJuBlYfaUZ2PWp X-Google-Smtp-Source: AGHT+IHj9I+uFlgfloUdFzGiBbJfNBTblh8QrvW343Z2XsZik76mgZQI5JHuhJhVeWrLt8XtSHObBHSg9NFwSyKv3Is= X-Received: by 2002:a5d:5c85:0:b0:371:7e3f:6cc with SMTP id ffacd0b85a97d-3717e3f07a1mr507220f8f.9.1723643439332; Wed, 14 Aug 2024 06:50:39 -0700 (PDT) MIME-Version: 1.0 References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> In-Reply-To: From: Alice Ryhl Date: Wed, 14 Aug 2024 15:50:27 +0200 Message-ID: Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 658A314001E X-Stat-Signature: ajj13koddk7hk6ec6esnpxz1xdmtxpz4 X-Rspam-User: X-HE-Tag: 1723643441-679373 X-HE-Meta: U2FsdGVkX1/cK9mwdifc615XZO6TYnCTLv1MZspldh/zh7VeHEV42h0DjDFhnSIuqWS9qT3ab4JLgFPQHOek9d4ofxKzg0/1qeOGp+Ye1WTz32NnHwAZ5Pj7XXqc5T9nRFLdthy90O08jsYXxXleOyZckarZ7QHlh0Y/T5oiPUkS42IWxfC+inWTsAPn6Tn/tquhRG43LGuX7V9HucC71MHBZkK76ko4lCGc6iGBg0TucHXVToHuJtFl/wx95VQby6PmoYtHpyJ3FNvi0Gh/gToAKaJAiwqkBjEMXw6smYRTeKO3MpBFnE8i03auw7bTK9QyLaYBZiPQ/L9/gLF6DlQuKMm/XjbHygLq+YHX8QaE7QtTP+cVWnWMq7RY+EE7maM7Pm5930Axtxym08prLerG/AzXSKK9+spt75IEXuVvhYIRe4kANFwEe0YIO4Zn2ZA4PUycz7SzoHovRxpvncVKgpHVDQv7y4lux0Kb5yIdq2ukVXBWg33JvoqGnSMjaJ9osCdOaS2mxJKIlzw0Txv1PGg+7IDD9QaVDusSc+ulEEig2TSpLi7DkKHcHMUNZf3LKN8WJxBLO1qS20b49v6U59WVc5FO5QphtCR1kOGdMMOgqCKzQn9/vqz2fcC8h+1rEaBpbi0lZN5w3hSRrNc2WbvWScdWbSgeN5p2jf9TzE3Or5wLuzCsnbDaRM8aCupiVFd2T6oHnAKvbVWl/Db9YBT77+HrMCeR4q0TNUFXd1W7D1S2Ar4lUx4ZDdqCML0dIQdHkkMUCslu7FsvQsPAD6NNCKBWYYAvQtuFIJZHXdE6qU7K9iNEyln+CksjDLs0QUKbkCrmKZi04tROakIuoTW3G+n++sCoEUMz3m6KGmfDUCXDvi6/KX0nzbWVqUmT22L5LvWDhkEO5O/1q05ka4FNYdcUzoKtcM1FNjjEq19v2iG8xI06M6UikgoUIc8MfUZKM0DdfTR/AOy 0WtpvURc SQtx/KKBrjqUiYBICPOPI9Lk2vEXUD0eT23k7QbB0wmvVstr+am8mFOvkl6o5v5/XmiCQyV34bpVwAMz6vxCKtQDLyf6RtiN2gvTDoXVB2YtJcmxYPzyvAUr5G4os1Be4L3kkNaYhp5c7Ec/UrdmMX5fME9m4MHJ25LBQHcVTcw+CS2pi/3YWS/FWznYaFSsy00B4sxUeYNxyVwvdsWau9Hi4Nu74yfteG2naFItviTZiUxdDPeECoOoU5T10y/5CvEJAMW2agBLDa9HY2srAEf8eGa/k+NAB/1NbUqJxq0x0y+M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 3:48=E2=80=AFPM Danilo Krummrich = wrote: > > On Wed, Aug 14, 2024 at 03:44:56PM +0200, Alice Ryhl wrote: > > On Wed, Aug 14, 2024 at 3:36=E2=80=AFPM Danilo Krummrich wrote: > > > > > > On Wed, Aug 14, 2024 at 09:51:34AM +0200, Alice Ryhl wrote: > > > > On Mon, Aug 12, 2024 at 8:24=E2=80=AFPM Danilo Krummrich wrote: > > > > > > > > > > Implement `Allocator` for `Kmalloc`, the kernel's default allocat= or, > > > > > typically used for objects smaller than page size. > > > > > > > > > > All memory allocations made with `Kmalloc` end up in `krealloc()`= . > > > > > > > > > > It serves as allocator for the subsequently introduced types `KBo= x` and > > > > > `KVec`. > > > > > > > > > > Signed-off-by: Danilo Krummrich > > > > > --- > > > > > rust/helpers.c | 3 +- > > > > > rust/kernel/alloc.rs | 2 +- > > > > > rust/kernel/alloc/allocator.rs | 63 ++++++++++++++++++++++++++++= +++++- > > > > > 3 files changed, 64 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/rust/helpers.c b/rust/helpers.c > > > > > index 92d3c03ae1bd..9f7275493365 100644 > > > > > --- a/rust/helpers.c > > > > > +++ b/rust/helpers.c > > > > > @@ -193,8 +193,7 @@ void rust_helper_init_work_with_key(struct wo= rk_struct *work, work_func_t func, > > > > > } > > > > > EXPORT_SYMBOL_GPL(rust_helper_init_work_with_key); > > > > > > > > > > -void * __must_check __realloc_size(2) > > > > > -rust_helper_krealloc(const void *objp, size_t new_size, gfp_t fl= ags) > > > > > +void *rust_helper_krealloc(const void *objp, size_t new_size, gf= p_t flags) > > > > > { > > > > > return krealloc(objp, new_size, flags); > > > > > } > > > > > > > > Why are the various annotations on this helper being removed? > > > > > > rust_helper_krealloc() is only called from Rust, hence neither __must= _check nor > > > __realloc_size() should have any effect. > > > > > > I also do not apply them in subsequent commits for the vrealloc() and > > > kvrealloc() helpers for this reason and removed them here for consist= ency. > > > > > > > This deserves an explanation in the commit message. > > > > > > I can also add a separate commit for that. > > > > I think your change would be more obviously correct if you keep them. > > As in generally, or just for this patch? > > Generally, I don't think we should indicate compiler checks that actually= are > never done. > > For this patch, yes, it's probably better to separate it. In general. If you keep it, then I don't have to think about whether it affects bindgen's output. That's the main reason. Alice