From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49CD9C369BF for ; Wed, 25 Sep 2024 10:00:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A53906B0088; Wed, 25 Sep 2024 06:00:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A04BF6B0089; Wed, 25 Sep 2024 06:00:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CAA26B008A; Wed, 25 Sep 2024 06:00:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 674106B0088 for ; Wed, 25 Sep 2024 06:00:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 00433AC42D for ; Wed, 25 Sep 2024 10:00:35 +0000 (UTC) X-FDA: 82602816072.29.3CCBCF0 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf25.hostedemail.com (Postfix) with ESMTP id 06393A000B for ; Wed, 25 Sep 2024 10:00:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hzOXGNjR; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727258373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pzoOml1YCYEgfJn8QSXq3DVawdpDp//KSF0cYbIea6E=; b=5ccE/Pk/tWDMCS3bgFTD0yy462BbYdnGSQ8tyMqP9vE3kwQhdUzuzonUw6ihMUm7huTUvT 31EaqUEwvyLzpIhhPwiH3zfVUSz7ByLor2pUNkvFZYUqERmtNUq2/GahJaqAGixPqHgC8m 0HrnXePCYgfzDaWjYuGElUvh++Bgfqs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hzOXGNjR; spf=pass (imf25.hostedemail.com: domain of aliceryhl@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727258373; a=rsa-sha256; cv=none; b=09/O1ip0cwcqQ74OvOfHO5IqYkmHkR7cO7xY1v6bx8ywNFyHBMjAaX7m90+4QT24aZOLil 2zidxAabzvP/qtU3VCW5aQrX+nhDQkqoQTHj1l6OuOWD1NVFxRC774FFCF4vy7ed4CzWSJ DxYm9QCYTaGEuC4VtF/G/+BTfsspXLU= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-42cbface8d6so83289065e9.3 for ; Wed, 25 Sep 2024 03:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727258432; x=1727863232; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pzoOml1YCYEgfJn8QSXq3DVawdpDp//KSF0cYbIea6E=; b=hzOXGNjR2Gks2v5DTnUyd/pPAPPX7Kqc7iYOteCl0tFycy8E0oLDIqBZsxUd8OPz7E adnrmnN7nJIteYMDw+4DiFPfMcHpDA3dSvtm0WNUuMdTy+ZqUjdg4Ho75VJgaPktKkh5 En53IrhlEZT2ZX9Br1mscqwbF5TlptQ0l/lh3kSQCHowzl04IQqCP8bXHF4+rpYS+DrS jNcNnVcVSlqUpcxUKj09jD3AJF4YvaLPuAFItlV4FEi7iaadYhahauSz7uhMcdqwSOHm Gq3qvDz1/MYva8DjEXnjAok1aappKtdi6TiRtS5iQ4AliPo7OSGEXmcUwcKiAc811hTR 0L/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727258432; x=1727863232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pzoOml1YCYEgfJn8QSXq3DVawdpDp//KSF0cYbIea6E=; b=OYYqoDkGV1vwa2W19xlOH1Ta9sWLPtbRKcLS2LLV9vN/7phbj2OQMmBYdXlZDI8ffA TejT8HhLulnfE7cuh+NbXJ1v+/+1dzsEQGpnAWM9W4L5XUH+25i4TKCHulzSm6gF75F6 RUi3r+2lddqt1tnvejzEx0q9Ae8cDTZ7ZEnaCwBVol0XQQ37ejL5hBjt1w4btNDyY7aS 7+Ufl+86cGMOfB5wWHaONSF2gIym02s5hBvakxNKVFNO/XvNSk1YziTPefY7Y/yft5mE dFlQGpE7AzhmOtTa93qDS/HUIn5998sexLDjfp8RsrcVYMtGGjkj7hvbGKvwExhng4a1 vgdg== X-Forwarded-Encrypted: i=1; AJvYcCUEnAZ6o6YEo25RemO6ga8d6aVxPKsFXNu2yflyT5KFn5HlDqaH/9Gmm0qPZiriFreYwuIFi8ToCw==@kvack.org X-Gm-Message-State: AOJu0YyjaZPO6w0QPO3B+wYoORq6/Z9db5IJ1zs/9mtTgcSjghFF1bTJ cex8NL7XzWqppNWvQq77toqSEzNpeTuwLdmN62iOvuQTv6mpcECOHNIWAFvXgQtEXxQTZTG9wAo dqnzC7df01rp59zZn7SwjCjykbYgJh6nvQqac X-Google-Smtp-Source: AGHT+IGKx3uL22uVQI6NHByefGqy6iXJLA73m1W8DO6NEIobANtIbLRvc5jJ2Ew/h8x1OdttDYdjCDqwhHlO027Qz2g= X-Received: by 2002:a5d:5547:0:b0:371:8dd3:27c8 with SMTP id ffacd0b85a97d-37cc246a5cemr1937135f8f.23.1727258432326; Wed, 25 Sep 2024 03:00:32 -0700 (PDT) MIME-Version: 1.0 References: <20240820194910.187826-1-mmaurer@google.com> In-Reply-To: From: Alice Ryhl Date: Wed, 25 Sep 2024 12:00:19 +0200 Message-ID: Subject: Re: [PATCH v4 0/4] Rust KASAN Support To: Miguel Ojeda Cc: Matthew Maurer , andreyknvl@gmail.com, ojeda@kernel.org, Alex Gaynor , Wedson Almeida Filho , Nathan Chancellor , dvyukov@google.com, samitolvanen@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, glider@google.com, ryabinin.a.a@gmail.com, Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Nick Desaulniers , Bill Wendling , Justin Stitt , rust-for-linux@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 06393A000B X-Stat-Signature: 6htohsny54zqudnthsx354bcnqp5a6z1 X-HE-Tag: 1727258433-517624 X-HE-Meta: U2FsdGVkX18XgXX6WWm9iBHplKQLvQ34BqCHO+xR0uyZqfBYALbTU/rZUiEAw+UMYh0lmURxDJzYiW9ZsMibZej07ikFvSXO4ubbiqh4bj8FDoc4w/m/LmZl5cud3WX2piCWNguYqauIwBvoF5HVVYHFt5YpmwLwg9Nq3rslG1/R4n8gxss2bqzBYGgOioiULnT8YL846wY7lmFnq0zaNIw+PUM1nUZj4NhD7ghqM9IvGu0oFIO3eb8Ajeqhy/z4wB40+AShsl/9GasoBfnA4FW9anDd8hFklawCOsedT+3/TANFrSHXXVX9w+enhnt3ETwjvmHhuaOifGzZ7bs+yCNUWJGgl0Egyu9x8L3gNfGgyeM2CkKWo3aqRecsGBSmRLeyTaY2DXj72mPbGTzDUIlE/iuXx+qohPqk+c5ZtkqTbacFq6IX2loiRgAevRTKuzqOk+JoZhUhtAHDw5ojZQmgxCS/nay2KvJeNvJDVdaQHEBleciZ5gVhpnr5LrSLs9vO9kfttcn3reaJyepKyANTTKQvrZqBSzug36GqccCT8GWn1xxCNMUu3N8vfV4wAq4SsceJetKKTqkAE4CsOVg/oj7ozDeM9V0ViWClgHlzw83rJKb0DF5s0aiKHQN01btiXoVZpXA1GbK+PJkny4Q7yXiG/SkFnTyCxM84KJdK3qqWTFb8rG1OyMipxOpFIXIqkTZ5wj5SAmkFhGbwXi4ZggHuArejQLARr7RpvvwBznpn0N28X69bb0qWildEuNchec+0GrUsNEmCr6UEClw1rKii0qf1EJUuUaU4TH6edW0vcN3hFWfs5AcLXfa1TH8NvIhGMJzu7aF13wfWOYgSterV+r5omXKtxYLP1G0lIKeeg85lsBIjLqbkUHRKqImLCiO6jHUaGwvJdbQ3ovMh7QpWnkV4moie1RoGVg4OpFyeXF/TzBfft6dJM2yHHv/eRKKrUCSxfLRTHXo yuegJEO7 yhifJp+PnkePqtfl1Oe8yYHet6JCtIo68D6LZyBOK0c2pfRrjTIEFagMZhY+u2VGzNCvqvofhpO/4rlJzLI/co2RcfPTf4nuDDkcBER1lmgkfxHyqJAO5blyxds1pAtxoavsHm2JoHYEgklA72rVKH2dBdj+C+h6JLviMv5I/bzcGYFfAiVK0tEkOUe9m2CXtikn23pHBwrLclV+9pwDTB2EkKFV4AHbg4f7LxWp8Y+B3FRCW7mp0FwBSsMCWRyBpW6ehxY9YLfkDAv8y1eVZGxaTX0NZkVgDzluztLgvIGC3vaiQbMd/a6+6U1XkpfrS1lh1yQ6DGkvR6+LipworOOQxqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.222819, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 10:26=E2=80=AFAM Alice Ryhl = wrote: > > On Mon, Sep 16, 2024 at 6:47=E2=80=AFPM Miguel Ojeda > wrote: > > > > On Mon, Sep 16, 2024 at 6:15=E2=80=AFPM Miguel Ojeda > > wrote: > > > > > > Applied to `rust-next` -- thanks everyone! > > > > Also, for KASAN + RETHUNK builds, I noticed objtool detects this: > > > > samples/rust/rust_print.o: warning: objtool: > > asan.module_ctor+0x17: 'naked' return found in MITIGATION_RETHUNK > > build > > samples/rust/rust_print.o: warning: objtool: > > asan.module_dtor+0x17: 'naked' return found in MITIGATION_RETHUNK > > build > > > > And indeed from a quick look the `ret` is there. > > > > Since KASAN support is important, I decided to take it nevertheless, > > but please let's make sure this is fixed during the cycle (or add a > > "depends on"). > > I figured out what the problem is. I will follow up with a fix soon. I posted a fix: https://github.com/rust-lang/rust/pull/130824 We'll need a check on RUSTC_VERSION in Kconfig for this. If the PR gets merged within the next 22 days, this will land in 1.83.0. Would you like me to send a fix with that version number now or wait for it to get merged before I send that fix? Alice