From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B82EC48BF8 for ; Thu, 22 Feb 2024 10:00:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E5A36B007B; Thu, 22 Feb 2024 05:00:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 295D36B007E; Thu, 22 Feb 2024 05:00:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1388D6B0080; Thu, 22 Feb 2024 05:00:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 02D686B007B for ; Thu, 22 Feb 2024 05:00:13 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B685D140D15 for ; Thu, 22 Feb 2024 10:00:12 +0000 (UTC) X-FDA: 81818994264.19.BED462C Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf30.hostedemail.com (Postfix) with ESMTP id AF3788000E for ; Thu, 22 Feb 2024 10:00:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BbDkYww5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of aliceryhl@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708596010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xY3a5A8TczyzS4EQy7YnxSv2e9KYZLcka7tIrv2ih1k=; b=d/akZcSps2KTYqhrjla/OYGbJOfFE5uh80EmosYRxsiUcrNKk5KlTpG4ARRKxM85N0edVR lcWRPprOgGm+jTyXbi70ATc3u1rHaLuhjNysl6MaPr2HplXJBxPeYA/t1jwOu/PvUwwT/7 LW5RvfUvtlrck+H+w83xxva0mnI/23c= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BbDkYww5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of aliceryhl@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708596010; a=rsa-sha256; cv=none; b=4zSwBdDwcoSI/JKxvMvayEakyfL4MaT/bZ82YxJ9BDc00A+z0a2Ac5+m63T2sr2Eelb30N 6d6QNhVDiSvfl72nJ8rUO0g6XHoGLgdA663T1ifAHMojqzpzAKTJjA7OS0q+YR/VqktQ2D 3AhaKKHkgWXocQsaMoiPMz5wyVg73jU= Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-4706de5227aso713106137.3 for ; Thu, 22 Feb 2024 02:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708596009; x=1709200809; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xY3a5A8TczyzS4EQy7YnxSv2e9KYZLcka7tIrv2ih1k=; b=BbDkYww5ezAmFC269RpZg9+otTKmJJmYSvsx1pBz5e5sFYgbWX7DQFRYjKIV9lXZoU OhmTX+UHA3wd9W4Om3XaNlrTzzwH+pkYc8UJ/O9Aec0QTMH6EfyEsGWVyla5qApeTEzF ragi8hx/oz5tJEjZptMDl1YjJvxt/b+8B8ION6OpzIFyFGfaPk/jL2v7FuSdP4ipuGcc UVp/PyYJyMQSnfM/XJHnv0CKM7lWEHNVorKJzCF7qrdzd3ld7o8Tx5d2vjtF1mquE9lc yRDGJGXx7VPWXLNpBDQ/rNVScW4xPtA0j35N0LadRwQPGRCMuCSah4qgzb7OQwyP1SPT rQ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708596009; x=1709200809; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xY3a5A8TczyzS4EQy7YnxSv2e9KYZLcka7tIrv2ih1k=; b=YWFvipNIQhUY60hydEnUd7MOOkvZVmkmZrV7xjbq5UC8r/v9M85YkaNDPIuguKE7L3 3fJ8Mu7b9vNkIzIZtppCdKazaJqBuggKPpSX4EbvL49v/vRXInrFpg97zEwWVg4TY0xc C95/B0+qowE1F7TjPKHlYE0MipfXFECunvcrM+TNSZZx8PHpAZmVlfntUS/SYxrU0ybx F5K+iPpVZnpuzERQa6PcHb8DbTd/8E4JAd1O8eGc9wHCgMWUNQK0rVE2CmAOS/nIPwIK PnjF22WSNReujNCkRKpGQMaqHTtOEG2BoHfotj0exAGz4m+d0MW5o3FdSfEjddbk2llE X46A== X-Forwarded-Encrypted: i=1; AJvYcCUGt1T6OBtQSP1QqTwW3WqVlNXIJ3F2Ofbm3aacKXrDUXyaRMYSqiu54ouRhsW4/b0dfea0G349f0UYT4B9XcuJHk8= X-Gm-Message-State: AOJu0Yx4LSXuWzoso9nFjz2su09bnCs/q0BqdZnl3x4gaXToe9u6r7uu 7daMk1T7jgNmMBVGoKft2BdIa2zHVRckihMb/GlclF57SkFMZAu7q4fvxO1ZNRWpUQw0HeTfRRY Zi0DbSP3aSD8CNZXwSE/vZ8JIzF+UEkaDNf8Q X-Google-Smtp-Source: AGHT+IHtNH9SG5kviHG0Zp4ObgcElY0QaPwq/WKIrJZZn0CRZo740etRowxrv/bo9NQSJHSXY5Ib9q+PDO3ajLn3tTQ= X-Received: by 2002:a05:6102:1626:b0:470:4a6e:4a4e with SMTP id cu38-20020a056102162600b004704a6e4a4emr14352031vsb.29.1708596009136; Thu, 22 Feb 2024 02:00:09 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-25-surenb@google.com> In-Reply-To: <20240221194052.927623-25-surenb@google.com> From: Alice Ryhl Date: Thu, 22 Feb 2024 10:59:57 +0100 Message-ID: Subject: Re: [PATCH v4 24/36] rust: Add a rust helper for krealloc() To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AF3788000E X-Stat-Signature: aaw5krigufnwq8685smtmgzamghxart5 X-Rspam-User: X-HE-Tag: 1708596010-403647 X-HE-Meta: U2FsdGVkX1+yBt3hbuTGWUMFj6Vz9kgK2zs9Ut4n9Qx3B6ovqvMkOvTXm48gFS7WdoAJxbt/fE/8GUQEzg21lljj4AwL8I8sNhJ+dUVUpTo9HZN09I6XDzMl/nLdr9UEDznkFBQA5h0W+vRm1VICNXXdTCHki9LyvmdRsrKDLVU+INFXgjObrPGxrmlOycMRVaewof/9+7BJqvbwhoIsx7MFmpINZiLdeAGzb1uZKCgBOA1v1fSZHhz0od4/ZKhEUXZkEE17g6Dgdvri3KRz7LuIpt1a1TdoIUijxkopOmYXMSywlRbq5qBur+SXw0reitQqJGAyghguOzHJ9ZME41putcYR4AzOs6KIMIMFNRtZWpKAka2eB0wqnhftvBu8HMYy3kUyymUAamU7r/Dw+phf/fEVOqoaGQGHLF5kSkw7oCqD27IF2vngUR0gKTtTn4lAPLrrFNPJjn2BprRnSKXm37/Kr5OIPrGr2iV4A9rrBPI3SszknGo3ID1Mclm5sy9G9K6yHNsmHREJckDhOhH6SYwjZ90zRdaLp7kvvrLeuvvPDj7h/7tH27rLUn2SfMt8T+RnJ8d5f0U+rsayF7tPfULo3zeCzsgNEcT7NL2aUT+hv7n79pHIcJdQXyuiKAgkWNBweRQV2KsqEPBS5l7uOXSFVr9vTy+2HZR4cSAB1L/gSe1OLIY4FQEGuhoGHMMc3uoBJ4iNTTnc8oGe7lh7YbK3j/PrfyHRzRuSJZLloe0fHj7dcFByFxvh9tGCkc86RPZR3gtKrBH9Sb+F/bp0cAnLqxU+XMGtv3hB5zw0wZJVNds6r8/evergpVqI0wq7FoN10h62BsIGwN+Ewc2DBYeenUCul9rNhTPGhoZGY6DaQE+5FqWYcw4655pAAaJ6s03LuWSg8wdkaabtEb5hA9lne+984ZMj5BZ3BGc3BW5UsehmJ2O4kKms+sMo5m9y50MEjBGsMBMffA9 zHn2m5W6 xEs2ZMGUpswJVOjfIv8S65GSsFIPrfR7zHWqlCc+b3xl808TRkQaoMfOZ4YNcr9KVURo7HzoXcPTqAa7Ovjbwb9p7cSAD2vKzYo1wWUFQzlSmqjG12XHosUgI9nGe155sm8frLppXQQkkpU/MVH7KZijRR/K60AFRkPDlqal6Y4APdOmjNB2MD+kjN7siD//8WiHfRTLCbHfseHzBJILXJCnOdwbnM8v6HEX4mzfQWznb082juxSqP5deNw4cS9FbspIdNMCEG2WmGQYY9xgRVhJ5qcN7H4aFzPhicXO02NM5XrtEFXt6Y9FTSpE3fRd9ZWsFMa+bTwcBrWY3yJ8gBI/twasHnyV48EPeR5Qk44QG+nmzf36UJLNXDL6RKSAMVY9c/4ldBTL7Dxat79DYJbQTXIpTCko/UAoS+YESNBt8bQe0o4i7AP2UT3le44P5+pMmK0iAudv6R/3yjZ0joAali4PgjrBShmPPNGaKTURD0kLgc9wvVjmqb1z/f6zIY8B1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 8:41=E2=80=AFPM Suren Baghdasaryan wrote: > > From: Kent Overstreet > > Memory allocation profiling is turning krealloc() into a nontrivial > macro - so for now, we need a helper for it. > > Until we have proper support on the rust side for memory allocation > profiling this does mean that all Rust allocations will be accounted to > the helper. > > Signed-off-by: Kent Overstreet > Cc: Miguel Ojeda > Cc: Alex Gaynor > Cc: Wedson Almeida Filho > Cc: Boqun Feng > Cc: Gary Guo > Cc: "Bj=C3=B6rn Roy Baron" > Cc: Benno Lossin > Cc: Andreas Hindborg > Cc: Alice Ryhl > Cc: rust-for-linux@vger.kernel.org > Signed-off-by: Suren Baghdasaryan Currently, the Rust build doesn't work throughout the entire series since there are some commits where krealloc is missing before you introduce the helper. If you introduce the helper first before krealloc stops being an exported function, then the Rust build should work throughout the entire series. (Having both the helper and the exported function at the same time is not a problem.) With the patch reordered: Reviewed-by: Alice Ryhl Alice