From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E032C52D7F for ; Wed, 14 Aug 2024 07:51:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27B246B0092; Wed, 14 Aug 2024 03:51:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 203C36B0093; Wed, 14 Aug 2024 03:51:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4D66B0095; Wed, 14 Aug 2024 03:51:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DCFB66B0092 for ; Wed, 14 Aug 2024 03:51:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F9761C443A for ; Wed, 14 Aug 2024 07:51:51 +0000 (UTC) X-FDA: 82450082022.04.D87E6DB Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf17.hostedemail.com (Postfix) with ESMTP id 8581640016 for ; Wed, 14 Aug 2024 07:51:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xO4d1H94; spf=pass (imf17.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723621897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PT+zi+/D9eO+wh878fg/U/GNgg7iPwjsl30b4TPDHZA=; b=YNh+BFK0RcQvWzMg/NQh2uc3Tfjlfhc1t7c5+LJQ76kEpct/UP+EHWO5HkCqfAW8o9NLcE 62YmskKZxxFVk07wavDUkpNuxmDy0vyJgSb9A3GhZC2o/IBB9lsmnPF7ShbmCbz2h7VqYY X54hxjv7ct6o5NAt6djq+e2wLpDWNJw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xO4d1H94; spf=pass (imf17.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723621897; a=rsa-sha256; cv=none; b=OvGqTRjBMD307jZE7/QslZVks08v1tCgJJJbnjNtHKpViyU0+SHiJgxClsxEmuO20kjr6r D2BtwqJEQfVAoobSIVquYb3R3MdffrXAS7tDIYLHItMf1YqDurOx0U7WLr8EzPri+OUzAD SfLZFwpSHlh7OqYiPajg3IDmu4BbGlc= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3687ea0521cso4489373f8f.1 for ; Wed, 14 Aug 2024 00:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723621908; x=1724226708; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PT+zi+/D9eO+wh878fg/U/GNgg7iPwjsl30b4TPDHZA=; b=xO4d1H94oPgKbDf25FvQtvhEVhxNMe1UfepzzyOH8LK0WMZ2BDBcsWBrLYIKQalh6x iysU9P4jNArz7oswjzi0+b2PPjvAE0rAESXvYNpEh2MdvfZzhIyUsqrq0eHWYDgWRxYZ VBw4K7KBWR+7Qk65sKaTTJMs2wJXSYhhvqBaABvh4+rtKaKhVAsUxwnSdN5utYMthrhX IIh+z8exr5O+gywOw68pGFP5LDP9tv3GIpvo03j+7WUch7dBVI9OEZilHrWiZfP/kDZ+ JGEld/WH9tnEU/+2ZiUM9PK0W1S5hknWfGO1BUPfsfoD5fQMWDbetfSEcjkNGkfO7FVr d7Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723621908; x=1724226708; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PT+zi+/D9eO+wh878fg/U/GNgg7iPwjsl30b4TPDHZA=; b=apFQdiyFEZ9v3nkY4j23lnCcKcjyRYCEh6XB2HD5UclXGzIJi4fpNipBexdv9gYlG3 dbe3zDUXtnr2iD/FOKVfFgy9XE/X0lFCqVk6ih3Ee3sgpda297eH9VjSnkBDHXIdmxdc zb5iTwTHka3GySe58JwvI86DFmPUpxlgBFtxzvoAP7rmoR97baOXkZnQuJk2KmwainUz cmw4HCI9JNNixSEuN67IxclNYy/vBsWYBhZ0poAF52KmvCp41RnPDHFVw4UJnAiLn2Dw glRbgDBpcQIy4xSKgFzDEtr3Ap3hq6XcDsLVUISBo2zly7fQmNGWOwnhdasiA4JAwfJD WVhg== X-Forwarded-Encrypted: i=1; AJvYcCW1N6yFcv6JnGZKJhGMkY/MR++nLW7L4mY2Ckmq07y9G/yjgu1Y7thcucN9+9hCAMgSsyadv3K5EwsePa9RDo57g3I= X-Gm-Message-State: AOJu0Ywof4aWVwz61SqyaelCuGCG3ivv9xybmEiRRLvsEsg1VdN5h0iT DzSacwtsdtpVgrWEDuPM7NPkHBZSwthS/hkUy/dN0EcdX4U2/0oIFbC8UaQb8sVW7fehi2k89L+ mJhqh9J3NRrGnA1J9fz3sevEBlTr5F7679T+g X-Google-Smtp-Source: AGHT+IHNC/TFNKG7R4ZRJeXKfO788rQbS5/gH98Hg+wPjB1fBpqR9ujBShpY4AhPDFKtH2Hl4xoiX6/Le5LMbGM4xCI= X-Received: by 2002:adf:e703:0:b0:367:4dce:1ff4 with SMTP id ffacd0b85a97d-3717775ae03mr1628464f8f.14.1723621907725; Wed, 14 Aug 2024 00:51:47 -0700 (PDT) MIME-Version: 1.0 References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> In-Reply-To: <20240812182355.11641-5-dakr@kernel.org> From: Alice Ryhl Date: Wed, 14 Aug 2024 09:51:34 +0200 Message-ID: Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: wig6ypocyp7388g4fap6mswkd4ej51kh X-Rspamd-Queue-Id: 8581640016 X-Rspamd-Server: rspam11 X-HE-Tag: 1723621909-854598 X-HE-Meta: U2FsdGVkX197MDIHD1cZBOPgFWh+YAHeLHBgOiebI+LdS16maaQvIwIzFlKTKkg2jQFvvHUOdQcbuzaBDKXV3bPsgkDtjeU4Wvnaui1my1ydOOJe/s4kU6GMoELbF022DdH/TlBcFkztoNQysHTUgnyj+7gVgav3lxaaMr87Da+09Ui9z4SWwwFaTCMTmfX2dmTcj8X64THmMC0yWY/FHTuN1OFGqyEAdf1yDfxhLd53aJM42EA6d4TS31qrhO6jKl3yGEYv09OStcMbPCadhOU/1CdCeI6fqStiQJGNGjMOJZEIJ9zd7GfFEfmeZCvtCZuLW8INKLI2ukPw1xt/stSZkSz7cx0BsrIVSqsWFlImWpWNC72nO7wqzpHbY75IRp+j265YaW7OG1uXFjRwn4mvAnH2LnJ6hdg0KVEFUII6e97e/ORHKS3XInDIL4wbo5NRVaEeg5+GM0w5LP9Y8dTU8SMTla/ZLIhK61xlRTqB4bF+Rlz1pKXHrXIxIsbJZNKOaVxqv4wNZWDGI5r2sn+23ga2zVuhndbvvLDwGSDn/QeHOTt43mEAWVE1RWqWkmZTeMCD0U+VZ/KhkbxwUGImkPFpjs3OtpRqBRhA2Und6LmCNhfNnVurJP0++goKsq/DHrF/GwGUe+5189m+lRKTkHIBPB3grdOYHs2tlqaeM1+C8EtPG3T6g4YWS4gQ9E9z8oeN66rT9V6vIAxtLaA8q8vp6keLAhTt8d1+e9ZlMV+7wYY/p/wx6gv+7HRWhhPLapyKVjxoUgp9KbYv6fJm3xKTsSU9gQpIO/HKkHoxL/UZfUc/zRofXwk9efuUVA5isQ7kAxWXyGNn95YGI0X2BBf0iLuyCNtxzSP7q8eIEtR0YF0GdZA323f3BRXyjan2ShP5dcvfsPAzv3cTRbQw0ED39lTUv9OEMpNReTHY/rVmuVY3umbS7JNfMpdxsvuXh6sRa30ueX1Hewt OdtalsKz 4qmqEY48QYoUnc9eUrZ7dDYDoARacW4EZbatPDW35zqxpM3q3qYScwcN7+VhsY258sdOnaNFdzG1kprqKVInhVITTkTuLQFnrSms5ENzNPeqa8MBndGhQYdRRxrQHpq8e8L2Qy7f4EOiNn0Ux+UJ2vjUTCRcWEAYBlozTKofJbG3vkYKlQo74luJzicd9pB9NIDY6zC2j1stRsf4xKAgE15GGe07uZwRrNYBdZB2i+HReSYlrGcjv1lyRgg1Zsx40Vud56eQUt8JFE2YRnzj+VuVRzoa8BO0y4ivPsZuIMGOo7TM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.009022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 8:24=E2=80=AFPM Danilo Krummrich = wrote: > > Implement `Allocator` for `Kmalloc`, the kernel's default allocator, > typically used for objects smaller than page size. > > All memory allocations made with `Kmalloc` end up in `krealloc()`. > > It serves as allocator for the subsequently introduced types `KBox` and > `KVec`. > > Signed-off-by: Danilo Krummrich > --- > rust/helpers.c | 3 +- > rust/kernel/alloc.rs | 2 +- > rust/kernel/alloc/allocator.rs | 63 +++++++++++++++++++++++++++++++++- > 3 files changed, 64 insertions(+), 4 deletions(-) > > diff --git a/rust/helpers.c b/rust/helpers.c > index 92d3c03ae1bd..9f7275493365 100644 > --- a/rust/helpers.c > +++ b/rust/helpers.c > @@ -193,8 +193,7 @@ void rust_helper_init_work_with_key(struct work_struc= t *work, work_func_t func, > } > EXPORT_SYMBOL_GPL(rust_helper_init_work_with_key); > > -void * __must_check __realloc_size(2) > -rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flags) > +void *rust_helper_krealloc(const void *objp, size_t new_size, gfp_t flag= s) > { > return krealloc(objp, new_size, flags); > } Why are the various annotations on this helper being removed? This deserves an explanation in the commit message. Alice