From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A48C021B2 for ; Tue, 25 Feb 2025 16:14:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E28C280001; Tue, 25 Feb 2025 11:14:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 193056B0088; Tue, 25 Feb 2025 11:14:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05971280001; Tue, 25 Feb 2025 11:14:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DD6996B0085 for ; Tue, 25 Feb 2025 11:14:21 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6CE361617EA for ; Tue, 25 Feb 2025 16:14:21 +0000 (UTC) X-FDA: 83158964322.03.817148F Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf15.hostedemail.com (Postfix) with ESMTP id 4BE4AA0019 for ; Tue, 25 Feb 2025 16:14:18 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=w8tYmd7i; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740500058; a=rsa-sha256; cv=none; b=Fy6d3grMzGSTeUYbu3WjVDEkBxOnnE1uep+ZZwz8try6Te6mn5Kcq6ZR/JQQjmcM342+0r nD4zDkpyFLgzNFhltwso4v21FLVAhbRHAl+sxBUqx3K4lRpWdk8VB3v5l6buc6u7qcK5ax E7M0q6AiOG9aExaR49votrhY5Dfso9k= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=w8tYmd7i; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=aliceryhl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740500058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XK+5lo3HBdUQbAUVlBZxC7V4AlAb8QMJsjpC+v4brkQ=; b=FupTqOsr5xLShhGkxGbuqqqGUpJbxR5wo/UCP5EAmu5hoGq41RJWGC5jvvrGPZps/z3qAx Z8RpU9ZvuOi/+hre0MHYYU2kkQ7A0cEM8Mf8JB+FwG2mIvYWyc4gZL2cTuIqLXw9ucVt/v tiVb9AHyerAote1Pja3hqgoPRp95pxs= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-38f6475f747so2736772f8f.3 for ; Tue, 25 Feb 2025 08:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740500057; x=1741104857; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XK+5lo3HBdUQbAUVlBZxC7V4AlAb8QMJsjpC+v4brkQ=; b=w8tYmd7ig/JvW22WSHGUErXkin1zmOUYe+HunVO9RUFLPH0Ii2xwP782sLP3sUCWi3 /KoLOHXfbNGIylWngzByX3bSJKrO8BfbIRKnJu93pb3I3MmKF8Ct+mQOlyvTJZT4XaJG zviWbW0oUx4zUv+hvtcKWVrlGx6Iu6YTj/tXwT8CGO6CB4VwwBTrgxrdOoRBGuChUdny JzQ3d0RVbT/DcqRYbnv+qJDlV7sCLpjMSMEaANfHW9aX1OWsDypnlTM+ZhQJC9L5dhXu rM4QxQjAbk+ERg2veloiyamEeH62HKS2nkjDo04lgGIbDkvBxXGcLluIs3doebGO9Hws mygw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740500057; x=1741104857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XK+5lo3HBdUQbAUVlBZxC7V4AlAb8QMJsjpC+v4brkQ=; b=H3tJkumbDRpma8511wATRMhDO0A5MYOy3ZSammAVQ8E7q1mUZKGW7jZlNNEQJboFG5 RR+0yYsCY6Etw3eSrLMz2zfoOvNiSoOZAObnfGNxxT5WI6PbfR4veeK4CrAFuTtLnVaO /mwFzs7pcV602iNHIUGJL/dwPRUSt8KnMI48kbrvpnfIqNusK74I42dKYpjgxiqDcwAZ N8EerAKa1eg5zt93OJyfnZtIMic1JZ3G1ZggjkfexJ2oHPAbx+ngm6RS+1iSeCfznmHH p8HU0n5YquDtcEOrnDnyDNtp2Qxsb6KduNvn7hqVK74/exKORoaMCY3iceaHhOnmZQX2 DVzg== X-Forwarded-Encrypted: i=1; AJvYcCXbc/tL67l4W/885pY5Qmivs7PBwBT631S1Jd0nFb21EB/hqAR0DRu7hVbvIi3YO0elJm0I3iRBAA==@kvack.org X-Gm-Message-State: AOJu0Yz/8ZhUoR/OzH9QWO7EHQLTLbLvrKRZcsDSALUDahSMvVDWGAeO ZLpLTGbH6Mez5nuspTv6rgtW00UAFIpBmOOkn6IlQFYsvFQcKzekvXYWtbMUASuJt5O/NOzqWZ7 whsMNBNbXsrN5tsvL+I11yKk+8mcRFgdEOQJM X-Gm-Gg: ASbGncsdHUsX4tT2TEU4wx2RXrVtbHsE43Tj6bar7W1tM/rU8SSGVJZZo+p4TDr8W8p KrnQtbwvLO3ZtvwSwBSQr+W5GqaGQbQlecdBTGxV/i9MSPxvjYUJIjl2LcT+O7rRUGhZnt0GoWW b5U9qFQJxG/19O2D7AP4U+9dIb6oanw78NnkRSWA== X-Google-Smtp-Source: AGHT+IFeOrnS2YilApBIdrzwq/ZX/O6MVfPF3KockjevL9jqE9VGA4rrlvEu3VXcwoVdvaUuGAyA9tFzp4UCo8Dc3v8= X-Received: by 2002:a5d:5f52:0:b0:38f:277a:4ec0 with SMTP id ffacd0b85a97d-38f6e74f162mr15327640f8f.6.1740500056610; Tue, 25 Feb 2025 08:14:16 -0800 (PST) MIME-Version: 1.0 References: <20250213-vma-v14-0-b29c47ab21f5@google.com> <20250213-vma-v14-3-b29c47ab21f5@google.com> <20250225160603.4d4a2893@eugeo> In-Reply-To: <20250225160603.4d4a2893@eugeo> From: Alice Ryhl Date: Tue, 25 Feb 2025 17:14:03 +0100 X-Gm-Features: AQ5f1JoGbOrMtDQMPf3ikgvl4jGB3lyR6mbHfF9fDJZgtAdACnHj8fwMViezsGo Message-ID: Subject: Re: [PATCH v14 3/8] mm: rust: add vm_insert_page To: Gary Guo Cc: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Jann Horn , Suren Baghdasaryan , Alex Gaynor , Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 4BE4AA0019 X-Rspamd-Server: rspam12 X-Stat-Signature: zfkhauiio8wm9b1had36dbfp1kmys15h X-HE-Tag: 1740500058-289114 X-HE-Meta: U2FsdGVkX1+MQfCNx6brHMQ7Kj/zWYN9vQgvFTNtES+fxz9jG0bRcpUwwHEIFhmVHy2QPWkyhVhpGBg38VG0rMi5ueEJJcnbsOFLKLViF/X6zWakLG/IKf+bvnkkVMEqYVJOg6cs0BdfxEJHcSzdtWy99KeEhX/fPLfl1F8HkycgiG1AN8oAqZgck1OgOBntasgH3Qo4JXftpqA13ebKAbDydvvhm6WEyRyKaL4OmGwgYpRNASrrvnvyuF0S6uyh/DgKKPci/wX8TJd9ldqge99Ie4On7t2yvkvY6R84PdHtDuqBPaxV4Mjj7lGluNsMxmjrN24GAzmkorP20hcQGQ1Kinurc8sVvVKVkWGXSuHk2HVmwawO9mShHoXOBwtFjvJs65r41xlRRV345XbYV4mRRzJjoDc/Z5QNCU1/EmKUc/bICjPlED2U1uB7XnDy2mAQweW0gkU9cAtcQiBqTPIiuk9zKqtsLIzfiUgRxGSSH2h51CFZQAu4bN/njD8rwb2bxj2P6Ke8cd0kbnmBLeDS4pJQx49ScesLQpPmTjyQmxUXxV1zOVH1pZMTiZ3dWyqmihEZ7y0LlYxbz67h2plSCmjPokK5dEQH31WuCbLbVszxExqEJM8lGZKV0q3+5VRxZqMwZ31ynZLX8JN+v0yaV+LcwQNN93BTkkN7AuUMlfi4i5U4qlAb1ogt1MkTF645GRClyyJc1OqWWn1QRlikF6wzEP6TIAgwafvx83/vz4wPmEsl9isUKvRRM1n8SkR+WuT0d2HAyGdIsDZrkUVfBvlz9liRPQxj0OJbSnUIa1oDbNPXQ6CirEydHKbANCnNO6y1eonA54ADyPo06Za0Ph1oaYUny4l0O47DxVVZde4zNvzMZ8cQsEdmAdNcIP2XpTglXnGBDkL4Ao7Tiz5VMjUG+UJTdnEb+GWl4MMtDGFsENndArCfDxeNEqM8Um7bjatTUJ9Ol5q+Yan tZwA6Dfc Sc32L5+eeKlzIAZfcGwoydWy6Htwd02HLypOOu4o7d3WAX2eUL4zQoEqGFCh/ZfuGsng5xyUIiUk0jWEDE9LgEIiQgW1jhF7NjKdx0D7Z0MlaSk6k4doUMvjD5P8+3LY8msjPx5wQOULHZmzICWGVxMGPAUrc5X9kTXFajDRJZjcZLBpcboYjuC9Liy/lr56rjZi5zDOPI9a7UAqTbEkLORQzbcQED2rbiynrDOa28gWZgMHSEHx9a92y9bLkxPSHIH3Kg8/Bd9ryodg+eGoZrHOt8Bi1mPkj2fajtnpzni/goJ3em2IG0D9nhajS93WvxxbARWBDLVa3+EW/KuCAeOLrlV9/YM756JpAnG9DiTNaqx6v++XRa3Gih7jKQg2n15rRu4wmGVNqDryFPLTscJWXKnSwnTQZqLqJ1lyeU6klBD+VKE77kdz0nju49k/rfMMw X-Bogosity: Unsure, tests=bogofilter, spamicity=0.498848, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 5:06=E2=80=AFPM Gary Guo wrote: > > On Thu, 13 Feb 2025 11:04:02 +0000 > Alice Ryhl wrote: > > > The vm_insert_page method is only usable on vmas with the VM_MIXEDMAP > > flag, so we introduce a new type to keep track of such vmas. > > > > The approach used in this patch assumes that we will not need to encode > > many flag combinations in the type. I don't think we need to encode mor= e > > than VM_MIXEDMAP and VM_PFNMAP as things are now. However, if that > > becomes necessary, using generic parameters in a single type would scal= e > > better as the number of flags increases. > > > > Acked-by: Lorenzo Stoakes > > Reviewed-by: Andreas Hindborg > > Signed-off-by: Alice Ryhl > > LGTM, so: > > Reviewed-by: Gary Guo > > BTW, any reason that this specialised type is called > `VmaMixedMap` but the base type is called `VmaRef` rather than just > `Vma`? I used to have a VmaMut type, which motivated the VmaRef name. Then, I removed VmaMut and later I added VmaMixedMap. Alice