From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8A4C48260 for ; Thu, 8 Feb 2024 15:42:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05D3B6B0075; Thu, 8 Feb 2024 10:42:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00D1C6B0078; Thu, 8 Feb 2024 10:42:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E17846B007D; Thu, 8 Feb 2024 10:42:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D129F6B0075 for ; Thu, 8 Feb 2024 10:42:06 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 53F75A0880 for ; Thu, 8 Feb 2024 15:42:06 +0000 (UTC) X-FDA: 81769052652.10.BAC4EC0 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf30.hostedemail.com (Postfix) with ESMTP id AEE7680010 for ; Thu, 8 Feb 2024 15:42:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=n6Qvep+m; spf=pass (imf30.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707406924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKbb7p+kOEnvs7kyPggNgED1EnVbkGfw9/eZmIaWcyE=; b=V/IPJFznS6X4XPe1AvXVaYrw+2l6h7PECSDqLEijgH9ZyYoaZKvc2hH8K8mZJmunWXt6Mn ULYOKq5ptbbRQ17+YqER7ciSRVF+qD0leOHKZ2LLsoj9W5EzRvCZ1JDjBANFirPrMTFSCf eYG1eSTlJPKuGfZe7TcWzEukgfbPehY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707406924; a=rsa-sha256; cv=none; b=2cRuJbw9/LOMonHoW3LtgcJhpzn84fnRTiAHoRjKo58c9O3QRZeQP7OJ/1Gz7V+V0CRs+k r+p8GO5dCcyyi4ZMdsVAcvU/ZL/tE6XyOEc7gKqgD2IT3qNur/utn2KVuA64bhZAgXsc4t GijgEsELdKh+2C3oKCXIQZ5lPIYbYhI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=n6Qvep+m; spf=pass (imf30.hostedemail.com: domain of aliceryhl@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7d6275d7d4dso804603241.2 for ; Thu, 08 Feb 2024 07:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707406923; x=1708011723; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NKbb7p+kOEnvs7kyPggNgED1EnVbkGfw9/eZmIaWcyE=; b=n6Qvep+msawk/UsWnFCml2L3sLvwJUC37KTCY1wsvO6pRMlROTnyHxzltXjn+68vqW XBYo49ewKuc+pl7qosCnxI1NfPf/DZU7D64TCcsLBzPf3zbHiht1u+1RS6igoPApdpe3 fUhGX8ofnttk8G4p+NnvV1AOHE8FZGUNto9mp7MSrt//MqbHTrQr8BfdVoIEUTzGlUfA A3/e46gp44Qf/U1tN6S/NCz2LBsxnFuGhaa5q1bdBEEUZFi1iQeHoVk50+qpiP7clDYB pQD7zrmitvkaP7BzZi4o6kB0luRFOs7PrTR4dzynrI0WRwzGsh3zbDdzgchfNklML+FX l7Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707406923; x=1708011723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NKbb7p+kOEnvs7kyPggNgED1EnVbkGfw9/eZmIaWcyE=; b=Gt+CyRIaZKigsKUBVz0aMXLgnwxvc9/ASSH7dxpQuUDGnXrEITzQr4tKBNw9bRCXQn sv6mJL6mLFkzyzslKYRhkpasSWaUcI2rJ84o2TYKxrplnQb5gRHzcPTB8Dqm6xW1nkTb KbV1aqN/yfKUT4VLr6VV8iB6zQEVwrUQtoj/rzNovZ5Hm4o3m7S9Ig933UZHKTAzbMOP 1fcrV1ns/A3askMA5Tk4FOAuGWxd88eBShH435/iic7CXOv3d9qSys/utj6zAF4W3ZKs y1kSiilmDJtjTp73JoSXdsH4tyyxkKxLClPc9Wt/6jlFhmEK9AcJnP2/bmouTftFKkWB iN/Q== X-Forwarded-Encrypted: i=1; AJvYcCVTSHZN7rOsFc1dw3eFlt9rx3621xCDOWn9x/5trEY3mQXIZnEEiB98C9zYIfnnoJs40JoCaiGSTPiHpIbS5qeH1Rw= X-Gm-Message-State: AOJu0YzKf8527GMA9exjLD0bSfluLFHkIdheL2w6oNVYQpin3/p+lgjs octsoShw4vOC3C0Qo/8OCp3oyBeM/O1y6RQw+9ZZ8FaD26/Jb3ELPuFoZ5/rUljK2/+33RGeHau Ah4VrgcLYlSSEOcogVe6BBKMvBvf5i/BvzRVD X-Google-Smtp-Source: AGHT+IFDyVSM20AAZOqwIyb4b9dBSIPLnDvdeUdFq1ivHCsKm3z9RezCwd1Tr99hv7eVqI+4NfGUBzCublWFJ7MsYRg= X-Received: by 2002:a67:bd07:0:b0:46d:20a8:cb4e with SMTP id y7-20020a67bd07000000b0046d20a8cb4emr5871603vsq.26.1707406923533; Thu, 08 Feb 2024 07:42:03 -0800 (PST) MIME-Version: 1.0 References: <20240124-alice-mm-v1-0-d1abcec83c44@google.com> <20240124-alice-mm-v1-1-d1abcec83c44@google.com> <2024020859-lusty-ladylike-29d4@gregkh> In-Reply-To: <2024020859-lusty-ladylike-29d4@gregkh> From: Alice Ryhl Date: Thu, 8 Feb 2024 16:41:52 +0100 Message-ID: Subject: Re: [PATCH 1/3] rust: add userspace pointers To: Greg Kroah-Hartman Cc: Trevor Gross , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AEE7680010 X-Rspam-User: X-Stat-Signature: oh4ub9ks78z8xwc49b97dneto9xuoiu7 X-Rspamd-Server: rspam03 X-HE-Tag: 1707406924-158210 X-HE-Meta: U2FsdGVkX19PPToukCnCFotNcj4qIfL4/jWnunYoKyvq1C6wgqbOkNgjpcb9D1XF8+gT4tuiwPXGNM1xSq1VXy5TYex423oEMtITROokrNnQoo9WBAVUPs6SsQ7bgxDIzq8P6iW6uDyQHWrSP6DuwlmRakugkZ8JDlEQtjykbMTpexu7GxWAD0sEodDutvxqOs61k4EWcc8PB9Lphs9TB8rYuK6zGEoCuEVv8wRIiSMrQX3JErfYQvWdHfgpPTOr7HTjPtg8KnCoM1pggIJ9mg7YlIEe6nlXDJUhRbfkC1IPHzgXY93rGEH9zLH2VKDZve0Lf1CGmM6t0m3KAGOzNoYK9V3gn8Ts0qjbLkjgJRUtywfZGar7RmMiRxPqaLnZ0HO395n4oNu4WEk+ciayXSMQwlDCVopg+DP0wJMp7LpgT0RnYWp/+qhqQVb+sAYn7HHbBgbpK/sHT0RRckmoHpaChBVSwACNfY9OUmhcHxN7YrP1xpW2/LtTl4bj4lBuWWgiTDGOEgkBjNzaz+OGuRCL4jnUFXHoiFadHmTPXhxVYulmn5/ImhgHTroeNN8LsD5ivM0bWmIbmOo2frCFgvziyZTDJz0tEHqioKaL8ScEEFNgH6cjqhb2B17ucWwsZ03f9uDMUP5s+MwuSysC44S7rXuWIK82YE4mWOuj2fECGQlBRYKJzA4AddXZNH/qvTN5EX4ZNYZVTdOrGbT1bAyMsq6NfTfVIttBSYvxUN/l19mVOdYYLdwLr5FsofMsY1gEldJZkiKh2azP1FI1XNRC5PobYmvzveSMj8ZSshnKWmve3NR8QO7SIOsVHjkAmpeKU030XUY1R2Lt0jIhUL9kaK9e1wWdmoDkLg/jSsUTRO6SDGQvypMRQ0B3y0uo0mJOKCXaZ/3HqW23Sz4aCyUttpJvilgzYoBt0QzV6sU6D2ZA2pA8kzbOVSsJGJzc9BkP6vr816nA+pQZmxU na5x+rl2 sCH01m8An94aBoFKQWuJDBh2cjQ8qPXbE1xf7CuZSGuAoOkKwF19wNtmnoHSV1ZoDJqiY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 8, 2024 at 4:35=E2=80=AFPM Greg Kroah-Hartman wrote: > > On Thu, Feb 08, 2024 at 01:53:20PM +0100, Alice Ryhl wrote: > > > Is some sort of `Debug` implementation useful? > > > > Leaking pointer addresses in logs is frowned upon in the kernel, so I > > don't think we should include that. > > s/frowned upon/forbidden/ :) :) > Along those lines, you all are tieing in the "I want to print a pointer, > so hash it properly before I do so" logic from rust like we have in c, > right? Ideally you'd use the same logic if at all possible. > > If not, that probably needs to be done so that you don't accidentally > start leaking things. I don't know what the status of this is. For anything I've added, I've just made it entirely impossible to print addresses, hashed or not. Alice