From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B7ACD1296 for ; Mon, 8 Apr 2024 07:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8941F6B0099; Mon, 8 Apr 2024 03:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 844266B009A; Mon, 8 Apr 2024 03:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E4876B009B; Mon, 8 Apr 2024 03:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 525216B0099 for ; Mon, 8 Apr 2024 03:54:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E60CD140887 for ; Mon, 8 Apr 2024 07:54:54 +0000 (UTC) X-FDA: 81985603308.17.253F7FD Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 2716F14001B for ; Mon, 8 Apr 2024 07:54:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gJRbjoYB; spf=pass (imf26.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712562893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RVtr28lBoOHvIvD1ov1ffDQZp850k5qzsqBjP0G6FrM=; b=N2U/anJ4kVw6puZ62IJuD2NS8fGH8sNqzayc5UAnx56WS0w5qp/ZfqV+4iQLyKtjcCDTNt EV22+61vX075LSzCUsa9wpgULORXIokSWQCQvEUSc5DzLfKvZrHQIWPPJHrc/UKwGf/B5Z wx0QHvAas8QcZnRyyMsSKMutqrb3rkg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712562893; a=rsa-sha256; cv=none; b=eWi198FwROrNOu809FnULUH836UFwr6EvIVsEiGHEpbQvs59QyxBJd/D3H6y5wGEi5pdJi lA2+kMmAXHnlCdfPn6AZeX2WLG8QflDCacVOwN2j9roTYQwzewHSEznuGb4rHtqFUK+2qG Wy/dwNMN4xjMUyb1kMJQVpZVfrBjCc4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gJRbjoYB; spf=pass (imf26.hostedemail.com: domain of aliceryhl@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=aliceryhl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-4daa8466d6fso1419619e0c.2 for ; Mon, 08 Apr 2024 00:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712562892; x=1713167692; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RVtr28lBoOHvIvD1ov1ffDQZp850k5qzsqBjP0G6FrM=; b=gJRbjoYBRyAASvCc+riEUx/WR5d2Q+PuYa4DexToo7cN/ukdyJS3b4tRfvW8Z4+5iu ftBIL8zQJtZuQ2ues9nb2B8AyPGLF4l/YGGOl/x4ulL5YzFoHRAv1pRjcvee5HD5y8QM GBi3PeDcswdhO0qeIja+sYIWu4dSwbWqfLpq744sO3q301RjqaKhKPcz5elQhvURKytK zNIpQc7iX/lxSc2gac5wY34Ldq0Fsqk7drQp8mpJ0+y2m5HGabAxsvRAHZI3UGcW0MmR 4zf4xzsljnfFWbynnfkwWmhocT1BXwnc85xoEItW3pp+085fvfMG7t+zhdgS0i/Pt10G aMZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712562892; x=1713167692; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RVtr28lBoOHvIvD1ov1ffDQZp850k5qzsqBjP0G6FrM=; b=dOuyzpnn/ucO1/XaHtEMS5tlqKf0jr/HX+CdxQjulwAwo4mcq41/ctQrlk1hye/huI ZRtSc0lKDys3UrG5qpysYtLwcNSNr/mk4tzSmL+8qhkUDPAVNLA2wgvmJxiI4MYwDztB PAFhCvE1ya92u590Q5GhyWWp6mytb5W+ZD60V2Sd72A5aF3iMS+Npkf9fDsrEih2GNtK K7snM5bv1+heAWSicjRTmTaWgar2BKWAiM607t6n9SYHPtIfYIUiXViKI0ynA7GKEtsA /nnJoLBNNfR6j3N1PJ55gpyw91SyA5H05idcrHgFtudv56xQmNV47CL2NdmhkjBOU6NS vtVQ== X-Forwarded-Encrypted: i=1; AJvYcCUgPimw1Y98r5JjIsldxphnM3GINLiXKRcovWhpqIlj2rXDlzfoVq6YXbe1FuveWCYUY4wCTGwVnHJtnjA7GcM2fWw= X-Gm-Message-State: AOJu0Yw2notjOQqS04MZkhbt/bobAuisY/DwF0dAahNYwcLVbH5KRHsH UoSG+NWEgzN62lTy3PtdZ6Otf299OIN7gbqsHkUJylKezbcmFf8BzaOteAhnjJXJrP/f6FF/Guo Xw+qGEVcaTfeiI9aLHGYBknIriw4hTuiKXLuV X-Google-Smtp-Source: AGHT+IGcCyaNVx367m9DP4JDrvGBbQiY4qh1tbucRREFcDFxokiEPF+PgsM+B5tIkA6dWC++IXhSDVvAoSrUN1h8r9Q= X-Received: by 2002:a05:6122:a0b:b0:4d3:36b9:2c26 with SMTP id 11-20020a0561220a0b00b004d336b92c26mr5325895vkn.14.1712562892077; Mon, 08 Apr 2024 00:54:52 -0700 (PDT) MIME-Version: 1.0 References: <20240404-alice-mm-v4-0-49a84242cf02@google.com> <20240404-alice-mm-v4-4-49a84242cf02@google.com> In-Reply-To: From: Alice Ryhl Date: Mon, 8 Apr 2024 09:54:40 +0200 Message-ID: Subject: Re: [PATCH v4 4/4] rust: add abstraction for `struct page` To: Benno Lossin Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2716F14001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: w75345dyyqjuaterxrnne3yaicfwrr3a X-HE-Tag: 1712562892-652753 X-HE-Meta: U2FsdGVkX18Il8K5CPhpmMWJL4Kfb1c/VUoziYNvGunU+Q/BrcYzwl2HZFREuZc+yXL/2J7jdBuc5/HBeaD7OfczAdWZvga3P9Pqebdk681IOBy0MG+2eBclZDhYI//Inky2I3Y8W1w/EAhAvZMTqGGMCDgcFcynnnoK3J1zo++2oeW5Gs6/FRldgQi8BhPvh9eX7bwi0OMWr4bTzLOgkNAm8QIdHwEnxogoH8NxKiQSo6qVjoE3n32l3jmHV2AJLz0STK0x4iFVGzSrzCpXi76yKzOHX/MfPdumI+jdlvJdQ6hNEFBgoi2pmdBkKzgvaQ44vjpeJ7UAfkpv5lUDZbMWDahkERZyUuzTa0bgZQGbS7KgMKZ1D7naSDYT7Dj3SBFFuCLTzjH9UlhX8XMFghc9cMAkSSMK7OVE06U9reqcq6CDRVu66jzYOC1ui7qJ0yOeI28xzoT+ADoVtJSYWbLaSd+4f1PmJ+xOzplokQ2kg0v+GEKIiDio1CiHLFNAfz4ldd/JdatG46m1FwijzyMmiZ5znXnxbfLcWT22wfLxJ199pGFNpo9zbvoln4vR+3w8XLkL4v29LT8U/LyZZmWSIw+Y5QJkcngA6RGm9tdzdMVWXMYVUBVn46vhjCUJXLPe7epED8uQUjl86//A3wwOa0OQfIIN/FYHQZa1o9YwG2oqRyKRvS2Yp6LOMzbEElSp7tPuPMDyW6jvFGGchr374nXfbMV+BjNHVPpqcerAsx0MY1x/CIDmODiJJzMoveRvnu+gxDzjVdO2/9w20jIjBtDwZkKgCSp5FAV3RevG7jwIwDnsWeWcaAXBx7t3vmVOKntyNdEqD8PPt+hv3XMKcN0A/RMxJjNo7NXpctIVBPugck6VwY3wxvXGKUA1UiDg+/WZso0il8b66AkeEeVJ3BKYH/lQF3dUUkg4LRbu1oDRAyZwA1ZrpLOZEPugn4huTff8sS3jx1i5TYP J8wIbweq 887vy2S+gJOsX+8e0M4AvbvVlHfjL2T0m6Ei7IGHcgBOZjqPcNYDD/7x3Lpfp0GvVbaQFr8qoY1M2FWZgWmv9Xs+GVbkLDDMlZ9DCf74MXOgHsd+oPhbTDSUE7Y99ahVqBCDE/O/lTlHlkjGekxyFDSg9QwrxhLZY04aTLDUJQ9wZXYdaBB3fch4m8wMIqe8XrdpKY/Wnqo524VU97ye1Zv9H9azUSdyhhJ32e64eGdbxfqhvNy3xjb1u4RrCTfzUNw8Y7lwHoeLiwxY3W+DOKPP0ZFWiwC7vCuVhvn0eDGzkaoU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 7, 2024 at 10:59=E2=80=AFAM Benno Lossin wrote: > > On 05.04.24 09:44, Alice Ryhl wrote: > > On Fri, Apr 5, 2024 at 12:33=E2=80=AFAM Benno Lossin wrote: > >> > >> On 04.04.24 14:31, Alice Ryhl wrote: > >>> +/// A bitwise shift for the page size. > >>> +#[allow(clippy::unnecessary_cast)] > >> > >> Why can't you remove the cast? > > > > Bindgen could decide to use a different type in the future or on > > different platforms. > > Did that already happen? > > I think that we might want to know if the type changes, since then the > value might change? I mean, it's quite unlikely that the page size will not fit in an usize, even if it changes? >From bindgen's point of view, this constant is just an integer literal with no type information. So I don't see how we can expect it to always be generated as a usize? Alice